WARNING: Consider renaming function(s) 'ena_phc_cnt_show' to 'phc_cnt_show' #39: FILE: drivers/net/ethernet/amazon/ena/ena_sysfs.c:82: +} WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #41: FILE: drivers/net/ethernet/amazon/ena/ena_sysfs.c:84: +static DEVICE_ATTR(phc_cnt, S_IRUGO, ena_phc_cnt_show, NULL); WARNING: Consider renaming function(s) 'ena_phc_exp_show' to 'phc_exp_show' #54: FILE: drivers/net/ethernet/amazon/ena/ena_sysfs.c:97: +} WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #56: FILE: drivers/net/ethernet/amazon/ena/ena_sysfs.c:99: +static DEVICE_ATTR(phc_exp, S_IRUGO, ena_phc_exp_show, NULL); WARNING: Consider renaming function(s) 'ena_phc_skp_show' to 'phc_skp_show' #69: FILE: drivers/net/ethernet/amazon/ena/ena_sysfs.c:112: +} WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #71: FILE: drivers/net/ethernet/amazon/ena/ena_sysfs.c:114: +static DEVICE_ATTR(phc_skp, S_IRUGO, ena_phc_skp_show, NULL); WARNING: Consider renaming function(s) 'ena_phc_err_show' to 'phc_err_show' #84: FILE: drivers/net/ethernet/amazon/ena/ena_sysfs.c:127: +} WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #86: FILE: drivers/net/ethernet/amazon/ena/ena_sysfs.c:129: +static DEVICE_ATTR(phc_err, S_IRUGO, ena_phc_err_show, NULL); total: 0 errors, 8 warnings, 0 checks, 96 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 33c473ea1ffe ("net: ena: PHC stats through sysfs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 8 warnings, 0 checks, 96 lines checked