WARNING: labels should not be indented #235: FILE: kernel/bpf/core.c:2179: + STX_ATOMIC_H: WARNING: labels should not be indented #236: FILE: kernel/bpf/core.c:2180: + STX_ATOMIC_B: WARNING: macros should not use a trailing semicolon #274: FILE: kernel/bpf/core.c:2220: +#define LOAD_ACQUIRE(SIZEOP, SIZE) \ + case BPF_##SIZEOP: \ + DST = (SIZE)smp_load_acquire( \ + (SIZE *)(unsigned long)(SRC + insn->off)); \ + break; WARNING: memory barrier without comment #276: FILE: kernel/bpf/core.c:2222: + DST = (SIZE)smp_load_acquire( \ WARNING: line length of 89 exceeds 80 columns #277: FILE: kernel/bpf/core.c:2223: + (SIZE *)(unsigned long)(SRC + insn->off)); \ ERROR: spaces required around that ':' (ctx:VxE) #286: FILE: kernel/bpf/core.c:2232: + default: ^ CHECK: Macro argument 'SIZE' may be better as '(SIZE)' to avoid precedence issues #292: FILE: kernel/bpf/core.c:2238: +#define STORE_RELEASE(SIZEOP, SIZE) \ + case BPF_##SIZEOP: \ + smp_store_release( \ + (SIZE *)(unsigned long)(DST + insn->off), (SIZE)SRC); \ + break; WARNING: macros should not use a trailing semicolon #292: FILE: kernel/bpf/core.c:2238: +#define STORE_RELEASE(SIZEOP, SIZE) \ + case BPF_##SIZEOP: \ + smp_store_release( \ + (SIZE *)(unsigned long)(DST + insn->off), (SIZE)SRC); \ + break; WARNING: memory barrier without comment #294: FILE: kernel/bpf/core.c:2240: + smp_store_release( \ WARNING: line length of 97 exceeds 80 columns #295: FILE: kernel/bpf/core.c:2241: + (SIZE *)(unsigned long)(DST + insn->off), (SIZE)SRC); \ ERROR: spaces required around that ':' (ctx:VxE) #304: FILE: kernel/bpf/core.c:2250: + default: ^ WARNING: line length of 98 exceeds 80 columns #320: FILE: kernel/bpf/disasm.c:272: + verbose(cbs->private_data, "(%02x) r%d = load_acquire((%s *)(r%d %+d))\n", WARNING: line length of 98 exceeds 80 columns #326: FILE: kernel/bpf/disasm.c:278: + verbose(cbs->private_data, "(%02x) store_release((%s *)(r%d %+d), r%d)\n", total: 2 errors, 10 warnings, 1 checks, 319 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 2f801b86a7e0 ("bpf: Introduce load-acquire and store-release instructions") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.