WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 WARNING: line length of 170 exceeds 80 columns #65: FILE: tools/testing/selftests/net/proc_net_pktgen.c:19: +static const char wrong_ctrl_cmd[] = "0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"; WARNING: line length of 191 exceeds 80 columns #86: FILE: tools/testing/selftests/net/proc_net_pktgen.c:40: +static const char dev_cmd_imix_weights_1[] = "imix_weights 101,1 102,2 103,3 104,4 105,5 106,6 107,7 108,8 109,9 110,10 111,11 112,12 113,13 114,14 115,15 116,16 117,17 118,18 119,19 120,20"; WARNING: line length of 198 exceeds 80 columns #87: FILE: tools/testing/selftests/net/proc_net_pktgen.c:41: +static const char dev_cmd_imix_weights_2[] = "imix_weights 100,1 102,2 103,3 104,4 105,5 106,6 107,7 108,8 109,9 110,10 111,11 112,12 113,13 114,14 115,15 116,16 117,17 118,18 119,19 120,20 121,21"; WARNING: line length of 84 exceeds 80 columns #118: FILE: tools/testing/selftests/net/proc_net_pktgen.c:72: +static const char dev_cmd_dst6_0[] = "dst6 2001:db38:1234:0000:0000:0000:0000:0000"; WARNING: line length of 91 exceeds 80 columns #119: FILE: tools/testing/selftests/net/proc_net_pktgen.c:73: +static const char dev_cmd_dst6_min_0[] = "dst6_min 2001:db8:1234:0000:0000:0000:0000:0000"; WARNING: line length of 91 exceeds 80 columns #120: FILE: tools/testing/selftests/net/proc_net_pktgen.c:74: +static const char dev_cmd_dst6_max_0[] = "dst6_max 2001:db8:1234:0000:0000:0000:0000:0000"; WARNING: line length of 84 exceeds 80 columns #121: FILE: tools/testing/selftests/net/proc_net_pktgen.c:75: +static const char dev_cmd_src6_0[] = "src6 2001:db38:1234:0000:0000:0000:0000:0000"; WARNING: line length of 188 exceeds 80 columns #134: FILE: tools/testing/selftests/net/proc_net_pktgen.c:88: +static const char dev_cmd_mpls_2[] = "mpls 00000f00,00000f01,00000f02,00000f03,00000f04,00000f05,00000f06,00000f07,00000f08,00000f09,00000f0a,00000f0b,00000f0c,00000f0d,00000f0e,00000f0f"; WARNING: line length of 197 exceeds 80 columns #135: FILE: tools/testing/selftests/net/proc_net_pktgen.c:89: +static const char dev_cmd_mpls_3[] = "mpls 00000f00,00000f01,00000f02,00000f03,00000f04,00000f05,00000f06,00000f07,00000f08,00000f09,00000f0a,00000f0b,00000f0c,00000f0d,00000f0e,00000f0f,00000f10"; WARNING: line length of 91 exceeds 80 columns #161: FILE: tools/testing/selftests/net/proc_net_pktgen.c:115: + ASSERT_EQ(r, 0) TH_LOG("CONFIG_NET_PKTGEN not enabled, module pktgen not loaded?"); WARNING: line length of 103 exceeds 80 columns #164: FILE: tools/testing/selftests/net/proc_net_pktgen.c:118: + ASSERT_GE(self->ctrl_fd, 0) TH_LOG("CONFIG_NET_PKTGEN not enabled, module pktgen not loaded?"); WARNING: line length of 102 exceeds 80 columns #167: FILE: tools/testing/selftests/net/proc_net_pktgen.c:121: + ASSERT_GE(self->thr_fd, 0) TH_LOG("CONFIG_NET_PKTGEN not enabled, module pktgen not loaded?"); WARNING: line length of 90 exceeds 80 columns #169: FILE: tools/testing/selftests/net/proc_net_pktgen.c:123: + len = write(self->thr_fd, thr_cmd_add_loopback_0, sizeof(thr_cmd_add_loopback_0)); WARNING: line length of 97 exceeds 80 columns #170: FILE: tools/testing/selftests/net/proc_net_pktgen.c:124: + ASSERT_EQ(len, sizeof(thr_cmd_add_loopback_0)) TH_LOG("device lo@0 already registered?"); WARNING: line length of 88 exceeds 80 columns #183: FILE: tools/testing/selftests/net/proc_net_pktgen.c:137: + len = write(self->thr_fd, thr_cmd_rm_loopback_0, sizeof(thr_cmd_rm_loopback_0)); WARNING: line length of 90 exceeds 80 columns #265: FILE: tools/testing/selftests/net/proc_net_pktgen.c:219: + len = write(self->dev_fd, dev_cmd_min_pkt_size_0, sizeof(dev_cmd_min_pkt_size_0)); WARNING: line length of 94 exceeds 80 columns #269: FILE: tools/testing/selftests/net/proc_net_pktgen.c:223: + len = write(self->dev_fd, dev_cmd_min_pkt_size_0, sizeof(dev_cmd_min_pkt_size_0) - 1); WARNING: line length of 90 exceeds 80 columns #273: FILE: tools/testing/selftests/net/proc_net_pktgen.c:227: + len = write(self->dev_fd, dev_cmd_min_pkt_size_1, sizeof(dev_cmd_min_pkt_size_1)); WARNING: line length of 94 exceeds 80 columns #277: FILE: tools/testing/selftests/net/proc_net_pktgen.c:231: + len = write(self->dev_fd, dev_cmd_min_pkt_size_1, sizeof(dev_cmd_min_pkt_size_1) - 1); WARNING: line length of 90 exceeds 80 columns #281: FILE: tools/testing/selftests/net/proc_net_pktgen.c:235: + len = write(self->dev_fd, dev_cmd_min_pkt_size_2, sizeof(dev_cmd_min_pkt_size_2)); WARNING: line length of 94 exceeds 80 columns #285: FILE: tools/testing/selftests/net/proc_net_pktgen.c:239: + len = write(self->dev_fd, dev_cmd_min_pkt_size_2, sizeof(dev_cmd_min_pkt_size_2) - 1); WARNING: line length of 90 exceeds 80 columns #288: FILE: tools/testing/selftests/net/proc_net_pktgen.c:242: + len = write(self->dev_fd, dev_cmd_min_pkt_size_3, sizeof(dev_cmd_min_pkt_size_3)); WARNING: line length of 90 exceeds 80 columns #291: FILE: tools/testing/selftests/net/proc_net_pktgen.c:245: + len = write(self->dev_fd, dev_cmd_min_pkt_size_4, sizeof(dev_cmd_min_pkt_size_4)); WARNING: line length of 90 exceeds 80 columns #294: FILE: tools/testing/selftests/net/proc_net_pktgen.c:248: + len = write(self->dev_fd, dev_cmd_min_pkt_size_5, sizeof(dev_cmd_min_pkt_size_5)); WARNING: line length of 90 exceeds 80 columns #297: FILE: tools/testing/selftests/net/proc_net_pktgen.c:251: + len = write(self->dev_fd, dev_cmd_min_pkt_size_6, sizeof(dev_cmd_min_pkt_size_6)); WARNING: line length of 90 exceeds 80 columns #300: FILE: tools/testing/selftests/net/proc_net_pktgen.c:254: + len = write(self->dev_fd, dev_cmd_min_pkt_size_7, sizeof(dev_cmd_min_pkt_size_7)); WARNING: line length of 90 exceeds 80 columns #303: FILE: tools/testing/selftests/net/proc_net_pktgen.c:257: + len = write(self->dev_fd, dev_cmd_min_pkt_size_8, sizeof(dev_cmd_min_pkt_size_8)); WARNING: line length of 90 exceeds 80 columns #310: FILE: tools/testing/selftests/net/proc_net_pktgen.c:264: + len = write(self->dev_fd, dev_cmd_max_pkt_size_0, sizeof(dev_cmd_max_pkt_size_0)); WARNING: line length of 82 exceeds 80 columns #317: FILE: tools/testing/selftests/net/proc_net_pktgen.c:271: + len = write(self->dev_fd, dev_cmd_pkt_size_0, sizeof(dev_cmd_pkt_size_0)); WARNING: line length of 90 exceeds 80 columns #324: FILE: tools/testing/selftests/net/proc_net_pktgen.c:278: + len = write(self->dev_fd, dev_cmd_imix_weights_0, sizeof(dev_cmd_imix_weights_0)); WARNING: line length of 90 exceeds 80 columns #327: FILE: tools/testing/selftests/net/proc_net_pktgen.c:281: + len = write(self->dev_fd, dev_cmd_imix_weights_1, sizeof(dev_cmd_imix_weights_1)); WARNING: line length of 90 exceeds 80 columns #330: FILE: tools/testing/selftests/net/proc_net_pktgen.c:284: + len = write(self->dev_fd, dev_cmd_imix_weights_2, sizeof(dev_cmd_imix_weights_2)); WARNING: line length of 88 exceeds 80 columns #389: FILE: tools/testing/selftests/net/proc_net_pktgen.c:343: + len = write(self->dev_fd, dev_cmd_udp_src_min_0, sizeof(dev_cmd_udp_src_min_0)); WARNING: line length of 88 exceeds 80 columns #396: FILE: tools/testing/selftests/net/proc_net_pktgen.c:350: + len = write(self->dev_fd, dev_cmd_udp_dst_min_0, sizeof(dev_cmd_udp_dst_min_0)); WARNING: line length of 88 exceeds 80 columns #403: FILE: tools/testing/selftests/net/proc_net_pktgen.c:357: + len = write(self->dev_fd, dev_cmd_udp_src_max_0, sizeof(dev_cmd_udp_src_max_0)); WARNING: line length of 88 exceeds 80 columns #410: FILE: tools/testing/selftests/net/proc_net_pktgen.c:364: + len = write(self->dev_fd, dev_cmd_udp_dst_max_0, sizeof(dev_cmd_udp_dst_max_0)); WARNING: line length of 84 exceeds 80 columns #418: FILE: tools/testing/selftests/net/proc_net_pktgen.c:372: + len = write(self->dev_fd, dev_cmd_clone_skb_0, sizeof(dev_cmd_clone_skb_0)); WARNING: line length of 84 exceeds 80 columns #423: FILE: tools/testing/selftests/net/proc_net_pktgen.c:377: + len = write(self->dev_fd, dev_cmd_clone_skb_1, sizeof(dev_cmd_clone_skb_1)); WARNING: line length of 92 exceeds 80 columns #437: FILE: tools/testing/selftests/net/proc_net_pktgen.c:391: + len = write(self->dev_fd, dev_cmd_src_mac_count_0, sizeof(dev_cmd_src_mac_count_0)); WARNING: line length of 92 exceeds 80 columns #444: FILE: tools/testing/selftests/net/proc_net_pktgen.c:398: + len = write(self->dev_fd, dev_cmd_dst_mac_count_0, sizeof(dev_cmd_dst_mac_count_0)); WARNING: line length of 84 exceeds 80 columns #466: FILE: tools/testing/selftests/net/proc_net_pktgen.c:420: + len = write(self->dev_fd, dev_cmd_xmit_mode_0, sizeof(dev_cmd_xmit_mode_0)); WARNING: line length of 84 exceeds 80 columns #469: FILE: tools/testing/selftests/net/proc_net_pktgen.c:423: + len = write(self->dev_fd, dev_cmd_xmit_mode_1, sizeof(dev_cmd_xmit_mode_1)); WARNING: line length of 84 exceeds 80 columns #472: FILE: tools/testing/selftests/net/proc_net_pktgen.c:426: + len = write(self->dev_fd, dev_cmd_xmit_mode_2, sizeof(dev_cmd_xmit_mode_2)); WARNING: line length of 84 exceeds 80 columns #475: FILE: tools/testing/selftests/net/proc_net_pktgen.c:429: + len = write(self->dev_fd, dev_cmd_xmit_mode_3, sizeof(dev_cmd_xmit_mode_3)); WARNING: line length of 82 exceeds 80 columns #526: FILE: tools/testing/selftests/net/proc_net_pktgen.c:480: + len = write(self->dev_fd, dev_cmd_dst6_min_0, sizeof(dev_cmd_dst6_min_0)); WARNING: line length of 82 exceeds 80 columns #533: FILE: tools/testing/selftests/net/proc_net_pktgen.c:487: + len = write(self->dev_fd, dev_cmd_dst6_max_0, sizeof(dev_cmd_dst6_max_0)); WARNING: line length of 94 exceeds 80 columns #575: FILE: tools/testing/selftests/net/proc_net_pktgen.c:529: + len = write(self->dev_fd, dev_cmd_clear_counters_0, sizeof(dev_cmd_clear_counters_0)); WARNING: line length of 81 exceeds 80 columns #590: FILE: tools/testing/selftests/net/proc_net_pktgen.c:544: + EXPECT_EQ(len, sizeof(dev_cmd_spi_0)) TH_LOG("CONFIG_XFRM not enabled?"); WARNING: line length of 92 exceeds 80 columns #603: FILE: tools/testing/selftests/net/proc_net_pktgen.c:557: + len = write(self->dev_fd, dev_cmd_queue_map_min_0, sizeof(dev_cmd_queue_map_min_0)); WARNING: line length of 92 exceeds 80 columns #610: FILE: tools/testing/selftests/net/proc_net_pktgen.c:564: + len = write(self->dev_fd, dev_cmd_queue_map_max_0, sizeof(dev_cmd_queue_map_max_0)); WARNING: line length of 82 exceeds 80 columns #640: FILE: tools/testing/selftests/net/proc_net_pktgen.c:594: + len = write(self->dev_fd, dev_cmd_vlan_cfi_0, sizeof(dev_cmd_vlan_cfi_0)); WARNING: line length of 82 exceeds 80 columns #650: FILE: tools/testing/selftests/net/proc_net_pktgen.c:604: + len = write(self->dev_fd, dev_cmd_svlan_id_0, sizeof(dev_cmd_svlan_id_0)); WARNING: line length of 84 exceeds 80 columns #656: FILE: tools/testing/selftests/net/proc_net_pktgen.c:610: + len = write(self->dev_fd, dev_cmd_svlan_cfi_0, sizeof(dev_cmd_svlan_cfi_0)); WARNING: line length of 82 exceeds 80 columns #659: FILE: tools/testing/selftests/net/proc_net_pktgen.c:613: + len = write(self->dev_fd, dev_cmd_svlan_id_1, sizeof(dev_cmd_svlan_id_1)); CHECK: Please don't use multiple blank lines #663: FILE: tools/testing/selftests/net/proc_net_pktgen.c:617: + + CHECK: Please don't use multiple blank lines #677: FILE: tools/testing/selftests/net/proc_net_pktgen.c:631: + + WARNING: line length of 92 exceeds 80 columns #681: FILE: tools/testing/selftests/net/proc_net_pktgen.c:635: + len = write(self->dev_fd, dev_cmd_traffic_class_0, sizeof(dev_cmd_traffic_class_0)); WARNING: line length of 90 exceeds 80 columns #688: FILE: tools/testing/selftests/net/proc_net_pktgen.c:642: + len = write(self->dev_fd, dev_cmd_skb_priority_0, sizeof(dev_cmd_skb_priority_0)); total: 0 errors, 57 warnings, 2 checks, 657 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 21e7e8aaa968 ("selftest: net: add proc_net_pktgen") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 57 warnings, 2 checks, 657 lines checked