WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 WARNING: Macros with flow control statements should be avoided #45: FILE: tools/testing/selftests/bpf/prog_tests/test_veristat.c:7: +#define __CHECK_STR(str, name) \ + do { \ + if (!ASSERT_HAS_SUBSTR(fix->output, (str), (name))) \ + goto out; \ + } while (0) WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #65: FILE: tools/testing/selftests/bpf/prog_tests/test_veristat.c:27: + strcpy(fix->veristat, "./veristat"); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #67: FILE: tools/testing/selftests/bpf/prog_tests/test_veristat.c:29: + strcpy(fix->veristat, "../veristat"); WARNING: line length of 82 exceeds 80 columns #71: FILE: tools/testing/selftests/bpf/prog_tests/test_veristat.c:33: + snprintf(fix->tmpfile, sizeof(fix->tmpfile), "/tmp/test_veristat.XXXXXX"); WARNING: Avoid unnecessary line continuations #91: FILE: tools/testing/selftests/bpf/prog_tests/test_veristat.c:53: + "%s set_global_vars.bpf.o"\ WARNING: line length of 81 exceeds 80 columns #159: FILE: tools/testing/selftests/bpf/prog_tests/test_veristat.c:121: + __CHECK_STR("is out of range [-2147483648; 2147483647]", "out of range"); WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #197: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:14: +const volatile __s64 var_s64 = -1; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #198: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:15: +const volatile __u64 var_u64 = 0; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #199: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:16: +const volatile __s32 var_s32 = -1; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #200: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:17: +const volatile __u32 var_u32 = 0; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #201: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:18: +const volatile __s16 var_s16 = -1; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #202: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:19: +const volatile __u16 var_u16 = 0; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #203: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:20: +const volatile __s8 var_s8 = -1; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #204: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:21: +const volatile __u8 var_u8 = 0; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #205: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:22: +const volatile enum Enum var_ea = EA1; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #206: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:23: +const volatile enum Enumu64 var_eb = EB1; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #207: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:24: +const volatile enum Enums64 var_ec = EC1; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #208: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:25: +const volatile bool var_b = false; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #215: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:32: + volatile __s8 a; WARNING: Macros with flow control statements should be avoided #239: FILE: tools/testing/selftests/bpf/test_progs.h:430: +#define SYS_FAIL(goto_label, fmt, ...) \ + ({ \ + char cmd[1024]; \ + snprintf(cmd, sizeof(cmd), fmt, ##__VA_ARGS__); \ + if (!ASSERT_NEQ(0, system(cmd), cmd)) \ + goto goto_label; \ + }) total: 0 errors, 21 warnings, 0 checks, 207 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 450b139f30c9 ("selftests/bpf: introduce veristat test") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 21 warnings, 0 checks, 207 lines checked