CHECK: spaces preferred around that '*' (ctx:VxV) #58: FILE: drivers/input/joystick/sidewinder.c:305: + if (parity64(GB(i*15,15))) ^ ERROR: space required after that ',' (ctx:VxV) #58: FILE: drivers/input/joystick/sidewinder.c:305: + if (parity64(GB(i*15,15))) ^ ERROR: space required after that ',' (ctx:VxV) #67: FILE: drivers/input/joystick/sidewinder.c:322: + if (!parity64(GB(0,48)) || (hat = GB(42,4)) > 8) ^ ERROR: space required after that ',' (ctx:VxV) #67: FILE: drivers/input/joystick/sidewinder.c:322: + if (!parity64(GB(0,48)) || (hat = GB(42,4)) > 8) ^ ERROR: do not use assignment in if condition #67: FILE: drivers/input/joystick/sidewinder.c:322: + if (!parity64(GB(0,48)) || (hat = GB(42,4)) > 8) ERROR: space required after that ',' (ctx:VxV) #76: FILE: drivers/input/joystick/sidewinder.c:343: + if (!parity64(GB(0,43)) || (hat = GB(28,4)) > 8) ^ ERROR: space required after that ',' (ctx:VxV) #76: FILE: drivers/input/joystick/sidewinder.c:343: + if (!parity64(GB(0,43)) || (hat = GB(28,4)) > 8) ^ ERROR: do not use assignment in if condition #76: FILE: drivers/input/joystick/sidewinder.c:343: + if (!parity64(GB(0,43)) || (hat = GB(28,4)) > 8) ERROR: space required after that ',' (ctx:VxV) #85: FILE: drivers/input/joystick/sidewinder.c:368: + if (!parity64(GB(0,33))) ^ total: 8 errors, 0 warnings, 1 checks, 60 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit caf809d25cc6 ("Input: joystick - Replace open-coded parity calculation with parity64()") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.