WARNING: line length of 126 exceeds 80 columns
#81: FILE: tools/testing/selftests/bpf/veristat.c:261:
+	{ "set-global-vars", 'G', "GLOBALS", 0, "Set global variables provided in the expression, for example \"var1 = 1\"" },

WARNING: line length of 86 exceeds 80 columns
#88: FILE: tools/testing/selftests/bpf/veristat.c:268:
+static int append_var_preset(struct var_preset **presets, int *cnt, const char *expr);

WARNING: line length of 96 exceeds 80 columns
#100: FILE: tools/testing/selftests/bpf/veristat.c:384:
+				fprintf(stderr, "Could not parse global variables preset: %s\n",

WARNING: line length of 81 exceeds 80 columns
#104: FILE: tools/testing/selftests/bpf/veristat.c:388:
+		} else if (append_var_preset(&env.presets, &env.npresets, arg)) {

WARNING: line length of 94 exceeds 80 columns
#105: FILE: tools/testing/selftests/bpf/veristat.c:389:
+			fprintf(stderr, "Could not parse global variables preset: %s\n", arg);

WARNING: line length of 93 exceeds 80 columns
#118: FILE: tools/testing/selftests/bpf/veristat.c:663:
+		fprintf(stderr, "Failed to open filters in '%s': %s\n", path, strerror(err));

WARNING: line length of 85 exceeds 80 columns
#126: FILE: tools/testing/selftests/bpf/veristat.c:1323:
+static int append_var_preset(struct var_preset **presets, int *cnt, const char *expr)

WARNING: line length of 83 exceeds 80 columns
#159: FILE: tools/testing/selftests/bpf/veristat.c:1356:
+			fprintf(stderr, "Could not parse integer value %s\n", val);

WARNING: line length of 97 exceeds 80 columns
#180: FILE: tools/testing/selftests/bpf/veristat.c:1377:
+		fprintf(stderr, "Failed to open presets in '%s': %s\n", filename, strerror(err));

WARNING: line length of 85 exceeds 80 columns
#215: FILE: tools/testing/selftests/bpf/veristat.c:1412:
+			const char *cur_name = btf__name_by_offset(btf, e->name_off);

WARNING: line length of 85 exceeds 80 columns
#227: FILE: tools/testing/selftests/bpf/veristat.c:1424:
+			const char *cur_name = btf__name_by_offset(btf, e->name_off);

WARNING: line length of 92 exceeds 80 columns
#244: FILE: tools/testing/selftests/bpf/veristat.c:1441:
+static int set_global_var(struct bpf_object *obj, struct btf *btf, const struct btf_type *t,

WARNING: line length of 93 exceeds 80 columns
#259: FILE: tools/testing/selftests/bpf/veristat.c:1456:
+		fprintf(stderr, "Setting global variable for btf kind %d is not supported\n",

WARNING: line length of 88 exceeds 80 columns
#265: FILE: tools/testing/selftests/bpf/veristat.c:1462:
+		if (enum_value_from_name(btf, base_type, preset->svalue, &value) != 0) {

WARNING: line length of 93 exceeds 80 columns
#266: FILE: tools/testing/selftests/bpf/veristat.c:1463:
+			fprintf(stderr, "Could not find integer value for enum element %s\n",

WARNING: line length of 86 exceeds 80 columns
#296: FILE: tools/testing/selftests/bpf/veristat.c:1493:
+		memcpy(ptr + sinfo->offset, (void *)&value + src_offset, sinfo->size);

WARNING: line length of 92 exceeds 80 columns
#301: FILE: tools/testing/selftests/bpf/veristat.c:1498:
+static int set_global_vars(struct bpf_object *obj, struct var_preset *presets, int npresets)

WARNING: line length of 92 exceeds 80 columns
#332: FILE: tools/testing/selftests/bpf/veristat.c:1529:
+			const struct btf_type *var_type = btf__type_by_id(btf, sinfo->type);

WARNING: line length of 92 exceeds 80 columns
#345: FILE: tools/testing/selftests/bpf/veristat.c:1542:
+					fprintf(stderr, "Variable %s is set more than once",

WARNING: line length of 98 exceeds 80 columns
#350: FILE: tools/testing/selftests/bpf/veristat.c:1547:
+				err = set_global_var(obj, btf, var_type, map, sinfo, presets + k);

WARNING: line length of 91 exceeds 80 columns
#361: FILE: tools/testing/selftests/bpf/veristat.c:1558:
+			fprintf(stderr, "Global variable preset %s has not been applied\n",

total: 0 errors, 21 warnings, 0 checks, 349 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 3930f53dfed1 ("selftests/bpf: implement setting global variables in veristat") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 21 warnings, 0 checks, 349 lines checked