WARNING: line length of 90 exceeds 80 columns #68: FILE: tools/bpf/bpftool/gen.c:95: + static const char *sfxs[] = { ".data", ".rodata", ".percpu", ".bss", ".kconfig" }; WARNING: static const char * array should probably be static const char * const #68: FILE: tools/bpf/bpftool/gen.c:95: + static const char *sfxs[] = { ".data", ".rodata", ".percpu", ".bss", ".kconfig" }; WARNING: line length of 90 exceeds 80 columns #77: FILE: tools/bpf/bpftool/gen.c:120: + static const char *pfxs[] = { ".data", ".rodata", ".percpu", ".bss", ".kconfig" }; WARNING: static const char * array should probably be static const char * const #77: FILE: tools/bpf/bpftool/gen.c:120: + static const char *pfxs[] = { ".data", ".rodata", ".percpu", ".bss", ".kconfig" }; WARNING: line length of 82 exceeds 80 columns #96: FILE: tools/bpf/bpftool/gen.c:232: + printf(" }%s *%s;\n", is_percpu ? " __aligned(8)" : "", sec_ident); WARNING: line length of 90 exceeds 80 columns #114: FILE: tools/bpf/bpftool/gen.c:291: + /* only generate definitions for memory-mapped or .percpu internal maps */ WARNING: line length of 86 exceeds 80 columns #116: FILE: tools/bpf/bpftool/gen.c:293: + if (!is_mmapable_map(map, map_ident, sizeof(map_ident)) && !is_percpu) WARNING: line length of 99 exceeds 80 columns #118: FILE: tools/bpf/bpftool/gen.c:295: + if (is_percpu && (use_loader || !get_map_ident(map, map_ident, sizeof(map_ident)))) WARNING: line length of 89 exceeds 80 columns #127: FILE: tools/bpf/bpftool/gen.c:311: + err = codegen_datasec_def(obj, btf, d, sec, obj_name, is_percpu); ERROR: trailing statements should be on next line #151: FILE: tools/bpf/bpftool/gen.c:1446: + if (err) \n\ CHECK: spaces preferred around that '%' (ctx:OxV) #162: FILE: tools/bpf/bpftool/gen.c:1457: + printf("\tobj->%s = NULL;\n", ident); ^ WARNING: Avoid unnecessary line continuations #167: FILE: tools/bpf/bpftool/gen.c:1462: + codegen("\ WARNING: Avoid line continuations in quoted strings #167: FILE: tools/bpf/bpftool/gen.c:1462: + codegen("\ total: 1 errors, 11 warnings, 1 checks, 101 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 463d58f97749 ("bpf, bpftool: Generate skeleton for global percpu data") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.