WARNING: line length of 91 exceeds 80 columns #74: FILE: tools/testing/selftests/bpf/prog_tests/global_data_init.c:70: + struct test_global_percpu_data__percpu init_value, *init_data, *data, *percpu_data; WARNING: Missing a blank line after declarations #82: FILE: tools/testing/selftests/bpf/prog_tests/global_data_init.c:78: + bool *online; + LIBBPF_OPTS(bpf_test_run_opts, topts, WARNING: line length of 87 exceeds 80 columns #113: FILE: tools/testing/selftests/bpf/prog_tests/global_data_init.c:109: + if (!ASSERT_EQ(bpf_map__type(map), BPF_MAP_TYPE_PERCPU_ARRAY, "bpf_map__type")) WARNING: line length of 90 exceeds 80 columns #115: FILE: tools/testing/selftests/bpf/prog_tests/global_data_init.c:111: + if (!ASSERT_TRUE(bpf_map__is_internal_percpu(map), "bpf_map__is_internal_percpu")) WARNING: line length of 90 exceeds 80 columns #131: FILE: tools/testing/selftests/bpf/prog_tests/global_data_init.c:127: + ASSERT_EQ((void *) init_data, (void *) skel->percpu, "skel->percpu eq init_data"); CHECK: No space is necessary after a cast #131: FILE: tools/testing/selftests/bpf/prog_tests/global_data_init.c:127: + ASSERT_EQ((void *) init_data, (void *) skel->percpu, "skel->percpu eq init_data"); CHECK: spaces preferred around that '|' (ctx:VxV) #149: FILE: tools/testing/selftests/bpf/prog_tests/global_data_init.c:145: + comm_fd = open("/proc/self/comm", O_WRONLY|O_TRUNC); ^ WARNING: Missing a blank line after declarations #203: FILE: tools/testing/selftests/bpf/prog_tests/global_data_init.c:199: + bool *online; + LIBBPF_OPTS(bpf_test_run_opts, topts, CHECK: spaces preferred around that '|' (ctx:VxV) #238: FILE: tools/testing/selftests/bpf/prog_tests/global_data_init.c:234: + comm_fd = open("/proc/self/comm", O_WRONLY|O_TRUNC); ^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #284: new file mode 100644 WARNING: externs should be avoided in .c files #296: FILE: tools/testing/selftests/bpf/progs/test_global_percpu_data.c:8: +int data2 SEC(".percpu"); total: 0 errors, 8 warnings, 3 checks, 260 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit d0dac32568b0 ("selftests/bpf: Add cases to test global percpu data") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 8 warnings, 3 checks, 260 lines checked