ERROR: code indent should use tabs where possible
#236: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:446:
+                              netdev_features_t features, unsigned int l3len)$

CHECK: Alignment should match open parenthesis
#236: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:446:
+fbnic_features_check_encap_gso(struct sk_buff *skb, struct net_device *dev,
+                              netdev_features_t features, unsigned int l3len)

WARNING: please, no spaces at the start of a line
#236: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:446:
+                              netdev_features_t features, unsigned int l3len)$

WARNING: please, no spaces at the start of a line
#238: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:448:
+       netdev_features_t skb_gso_features;$

WARNING: please, no spaces at the start of a line
#239: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:449:
+       struct ipv6hdr *ip6_hdr;$

WARNING: please, no spaces at the start of a line
#240: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:450:
+       unsigned char l4_hdr;$

WARNING: please, no spaces at the start of a line
#241: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:451:
+       unsigned int start;$

WARNING: please, no spaces at the start of a line
#242: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:452:
+       __be16 frag_off;$

ERROR: code indent should use tabs where possible
#245: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:455:
+        * In theory we could support TSO with single, innermost v4 header$

ERROR: code indent should use tabs where possible
#246: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:456:
+        * by pretending everything before it is L2, but that needs to be$

ERROR: code indent should use tabs where possible
#247: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:457:
+        * parsed case by case.. so leaving it for when the need arises.$

ERROR: code indent should use tabs where possible
#248: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:458:
+        */$

WARNING: please, no spaces at the start of a line
#249: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:459:
+       if (!(features & NETIF_F_TSO_MANGLEID))$

WARNING: suspect code indent for conditional statements (7, 15)
#249: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:459:
+       if (!(features & NETIF_F_TSO_MANGLEID))
+               features &= ~NETIF_F_TSO;

ERROR: code indent should use tabs where possible
#250: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:460:
+               features &= ~NETIF_F_TSO;$

WARNING: please, no spaces at the start of a line
#250: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:460:
+               features &= ~NETIF_F_TSO;$

WARNING: please, no spaces at the start of a line
#252: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:462:
+       skb_gso_features = skb_shinfo(skb)->gso_type;$

WARNING: please, no spaces at the start of a line
#253: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:463:
+       skb_gso_features <<= NETIF_F_GSO_SHIFT;$

ERROR: code indent should use tabs where possible
#256: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:466:
+        * if the match can only be on those supported thru GSO_PARTIAL.$

ERROR: code indent should use tabs where possible
#257: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:467:
+        */$

WARNING: please, no spaces at the start of a line
#258: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:468:
+       if (!(skb_gso_features & FBNIC_TUN_GSO_FEATURES))$

WARNING: suspect code indent for conditional statements (7, 15)
#258: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:468:
+       if (!(skb_gso_features & FBNIC_TUN_GSO_FEATURES))
+               return features;

ERROR: code indent should use tabs where possible
#259: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:469:
+               return features;$

WARNING: please, no spaces at the start of a line
#259: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:469:
+               return features;$

ERROR: code indent should use tabs where possible
#262: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:472:
+        * to fall back to partial for this, or any failure below.$

ERROR: code indent should use tabs where possible
#263: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:473:
+        * This is just an optimization, UDPv4 will be caught later on.$

ERROR: code indent should use tabs where possible
#264: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:474:
+        */$

WARNING: please, no spaces at the start of a line
#265: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:475:
+       if (skb_gso_features & NETIF_F_TSO)$

WARNING: suspect code indent for conditional statements (7, 15)
#265: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:475:
+       if (skb_gso_features & NETIF_F_TSO)
+               return features & ~FBNIC_TUN_GSO_FEATURES;

ERROR: code indent should use tabs where possible
#266: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:476:
+               return features & ~FBNIC_TUN_GSO_FEATURES;$

WARNING: please, no spaces at the start of a line
#266: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:476:
+               return features & ~FBNIC_TUN_GSO_FEATURES;$

WARNING: please, no spaces at the start of a line
#269: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:479:
+       if ((skb_inner_network_header(skb) - skb_network_header(skb)) % 2)$

WARNING: suspect code indent for conditional statements (7, 15)
#269: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:479:
+       if ((skb_inner_network_header(skb) - skb_network_header(skb)) % 2)
+               return features & ~FBNIC_TUN_GSO_FEATURES;

ERROR: code indent should use tabs where possible
#270: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:480:
+               return features & ~FBNIC_TUN_GSO_FEATURES;$

WARNING: please, no spaces at the start of a line
#270: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:480:
+               return features & ~FBNIC_TUN_GSO_FEATURES;$

WARNING: please, no spaces at the start of a line
#273: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:483:
+       ip6_hdr = ipv6_hdr(skb);$

WARNING: please, no spaces at the start of a line
#274: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:484:
+       if (ip6_hdr->version != 6)$

WARNING: suspect code indent for conditional statements (7, 15)
#274: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:484:
+       if (ip6_hdr->version != 6)
+               return features & ~FBNIC_TUN_GSO_FEATURES;

ERROR: code indent should use tabs where possible
#275: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:485:
+               return features & ~FBNIC_TUN_GSO_FEATURES;$

WARNING: please, no spaces at the start of a line
#275: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:485:
+               return features & ~FBNIC_TUN_GSO_FEATURES;$

WARNING: please, no spaces at the start of a line
#277: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:487:
+       l4_hdr = ip6_hdr->nexthdr;$

WARNING: please, no spaces at the start of a line
#278: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:488:
+       start = (unsigned char *)ip6_hdr - skb->data + sizeof(struct ipv6hdr);$

WARNING: please, no spaces at the start of a line
#279: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:489:
+       start = ipv6_skip_exthdr(skb, start, &l4_hdr, &frag_off);$

WARNING: please, no spaces at the start of a line
#280: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:490:
+       if (frag_off || l4_hdr != IPPROTO_IPV6 ||$

WARNING: suspect code indent for conditional statements (7, 15)
#280: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:490:
+       if (frag_off || l4_hdr != IPPROTO_IPV6 ||
[...]
+               return features & ~FBNIC_TUN_GSO_FEATURES;

ERROR: code indent should use tabs where possible
#281: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:491:
+           skb->data + start != skb_inner_network_header(skb))$

WARNING: please, no spaces at the start of a line
#281: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:491:
+           skb->data + start != skb_inner_network_header(skb))$

ERROR: code indent should use tabs where possible
#282: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:492:
+               return features & ~FBNIC_TUN_GSO_FEATURES;$

WARNING: please, no spaces at the start of a line
#282: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:492:
+               return features & ~FBNIC_TUN_GSO_FEATURES;$

WARNING: please, no spaces at the start of a line
#284: FILE: drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:494:
+       return features;$

total: 17 errors, 32 warnings, 1 checks, 282 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

Commit 93b353b85473 ("eth: fbnic: support TCP segmentation offload") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.