========== checkpatch - FAILED WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #41: FILE: tools/testing/selftests/bpf/prog_tests/net_timestamping.c:1: +#include CHECK: multiple assignments should be avoided #99: FILE: tools/testing/selftests/bpf/prog_tests/net_timestamping.c:59: + SK_TS_TXSW = SK_TS_ACK = 0; CHECK: No space is necessary after a cast #125: FILE: tools/testing/selftests/bpf/prog_tests/net_timestamping.c:85: + tss = (void *) CMSG_DATA(cm); CHECK: No space is necessary after a cast #132: FILE: tools/testing/selftests/bpf/prog_tests/net_timestamping.c:92: + serr = (void *) CMSG_DATA(cm); CHECK: Alignment should match open parenthesis #134: FILE: tools/testing/selftests/bpf/prog_tests/net_timestamping.c:94: + ASSERT_EQ(serr->ee_origin, SO_EE_ORIGIN_TIMESTAMPING, + "cmsg type"); CHECK: Blank lines aren't necessary before a close brace '}' #173: FILE: tools/testing/selftests/bpf/prog_tests/net_timestamping.c:133: + +} ERROR: trailing statements should be on next line #177: FILE: tools/testing/selftests/bpf/prog_tests/net_timestamping.c:137: + while (!socket_recv_errmsg(fd)); CHECK: No space is necessary after a cast #209: FILE: tools/testing/selftests/bpf/prog_tests/net_timestamping.c:169: + (char *) &sock_opt, sizeof(sock_opt)); WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #278: FILE: tools/testing/selftests/bpf/progs/net_timestamping.c:1: +#include "vmlinux.h" WARNING: line length of 92 exceeds 80 columns #328: FILE: tools/testing/selftests/bpf/progs/net_timestamping.c:51: +extern int bpf_sock_ops_enable_tx_tstamp(struct bpf_sock_ops_kern *skops, u64 flags) __ksym; CHECK: Alignment should match open parenthesis #381: FILE: tools/testing/selftests/bpf/progs/net_timestamping.c:104: +static bool bpf_test_access_bpf_calls(struct bpf_sock_ops *skops, + const struct sock *sk) CHECK: multiple assignments should be avoided #441: FILE: tools/testing/selftests/bpf/progs/net_timestamping.c:164: + delay = val->sched_delay = timestamp - val->sendmsg_ns; CHECK: multiple assignments should be avoided #445: FILE: tools/testing/selftests/bpf/progs/net_timestamping.c:168: + delay = val->sw_snd_delay = timestamp - prior_ts; WARNING: line length of 82 exceeds 80 columns #448: FILE: tools/testing/selftests/bpf/progs/net_timestamping.c:171: + prior_ts = val->sw_snd_delay + val->sched_delay + val->sendmsg_ns; CHECK: multiple assignments should be avoided #449: FILE: tools/testing/selftests/bpf/progs/net_timestamping.c:172: + delay = val->ack_delay = timestamp - prior_ts; WARNING: line length of 88 exceeds 80 columns #464: FILE: tools/testing/selftests/bpf/progs/net_timestamping.c:187: +int BPF_PROG(trace_tcp_sendmsg_locked, struct sock *sk, struct msghdr *msg, size_t size) total: 1 errors, 6 warnings, 10 checks, 475 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 81cbc6dc5230 ("selftests/bpf: add simple bpf tests in the tx path for timestamping feature") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.