WARNING: line length of 126 exceeds 80 columns
#80: FILE: tools/testing/selftests/bpf/veristat.c:260:
+	{ "set-global-vars", 'G', "GLOBALS", 0, "Set global variables provided in the expression, for example \"var1 = 1\"" },

WARNING: line length of 96 exceeds 80 columns
#87: FILE: tools/testing/selftests/bpf/veristat.c:267:
+static int parse_var_presets(char *expr, struct var_preset **presets, int *capacity, int *size);

WARNING: line length of 89 exceeds 80 columns
#88: FILE: tools/testing/selftests/bpf/veristat.c:268:
+static int parse_var_presets_from_file(const char *filename, struct var_preset **presets,

WARNING: line length of 87 exceeds 80 columns
#103: FILE: tools/testing/selftests/bpf/veristat.c:387:
+							&presets_cap, &env.npresets)) {

WARNING: line length of 96 exceeds 80 columns
#104: FILE: tools/testing/selftests/bpf/veristat.c:388:
+				fprintf(stderr, "Could not parse global variables preset: %s\n",

WARNING: line length of 96 exceeds 80 columns
#108: FILE: tools/testing/selftests/bpf/veristat.c:392:
+		} else if (parse_var_presets(expr, &env.presets, &presets_cap, &env.npresets)) {

WARNING: line length of 94 exceeds 80 columns
#109: FILE: tools/testing/selftests/bpf/veristat.c:393:
+			fprintf(stderr, "Could not parse global variables preset: %s\n", arg);

WARNING: line length of 95 exceeds 80 columns
#122: FILE: tools/testing/selftests/bpf/veristat.c:1328:
+static int parse_var_presets(char *expr, struct var_preset **presets, int *capacity, int *size)

WARNING: line length of 87 exceeds 80 columns
#171: FILE: tools/testing/selftests/bpf/veristat.c:1377:
+			fprintf(stderr, "Could not parse integer value %s\n", val_ptr);

WARNING: line length of 89 exceeds 80 columns
#184: FILE: tools/testing/selftests/bpf/veristat.c:1390:
+static int parse_var_presets_from_file(const char *filename, struct var_preset **presets,

WARNING: line length of 87 exceeds 80 columns
#226: FILE: tools/testing/selftests/bpf/veristat.c:1432:
+			const char *cur_name = btf__name_by_offset(btf, e[i].name_off);

WARNING: line length of 87 exceeds 80 columns
#239: FILE: tools/testing/selftests/bpf/veristat.c:1445:
+			const char *cur_name = btf__name_by_offset(btf, cur->name_off);

WARNING: line length of 92 exceeds 80 columns
#256: FILE: tools/testing/selftests/bpf/veristat.c:1462:
+static int set_global_var(struct bpf_object *obj, struct btf *btf, const struct btf_type *t,

WARNING: line length of 93 exceeds 80 columns
#270: FILE: tools/testing/selftests/bpf/veristat.c:1476:
+		fprintf(stderr, "Setting global variable for btf kind %d is not supported\n",

WARNING: line length of 89 exceeds 80 columns
#279: FILE: tools/testing/selftests/bpf/veristat.c:1485:
+		if (enum_value_from_name(btf, base_type, preset->svalue, &ivalue) != 0) {

WARNING: line length of 93 exceeds 80 columns
#280: FILE: tools/testing/selftests/bpf/veristat.c:1486:
+			fprintf(stderr, "Could not find integer value for enum element %s\n",

WARNING: line length of 86 exceeds 80 columns
#298: FILE: tools/testing/selftests/bpf/veristat.c:1504:
+				btf__name_by_offset(btf, t->name_off), preset->ivalue,

WARNING: line length of 95 exceeds 80 columns
#313: FILE: tools/testing/selftests/bpf/veristat.c:1519:
+		memcpy(ptr + sinfo->offset, (void *)&preset->ivalue + src_offset, sinfo->size);

WARNING: line length of 92 exceeds 80 columns
#318: FILE: tools/testing/selftests/bpf/veristat.c:1524:
+static int set_global_vars(struct bpf_object *obj, struct var_preset *presets, int npresets)

WARNING: line length of 92 exceeds 80 columns
#354: FILE: tools/testing/selftests/bpf/veristat.c:1560:
+			const struct btf_type *var_type = btf__type_by_id(btf, sinfo->type);

WARNING: line length of 92 exceeds 80 columns
#355: FILE: tools/testing/selftests/bpf/veristat.c:1561:
+			const char *var_name = btf__name_by_offset(btf, var_type->name_off);

WARNING: line length of 92 exceeds 80 columns
#365: FILE: tools/testing/selftests/bpf/veristat.c:1571:
+					fprintf(stderr, "Variable %s is set more than once",

WARNING: line length of 98 exceeds 80 columns
#369: FILE: tools/testing/selftests/bpf/veristat.c:1575:
+				err = set_global_var(obj, btf, var_type, map, sinfo, presets + k);

WARNING: line length of 91 exceeds 80 columns
#380: FILE: tools/testing/selftests/bpf/veristat.c:1586:
+			fprintf(stderr, "Global variable preset %s has not been applied\n",

total: 0 errors, 24 warnings, 0 checks, 373 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 9f1c759a61ed ("selftests/bpf: implement setting global variables in veristat") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 24 warnings, 0 checks, 373 lines checked