WARNING: line length of 82 exceeds 80 columns #183: FILE: include/uapi/linux/bpf.h:64: +#define BPF_LOAD_ACQ (BPF_ATOMIC_LOAD | BPF_ACQUIRE) /* load-acquire */ WARNING: line length of 83 exceeds 80 columns #184: FILE: include/uapi/linux/bpf.h:65: +#define BPF_STORE_REL (BPF_ATOMIC_STORE | BPF_RELEASE) /* store-release */ WARNING: labels should not be indented #240: FILE: kernel/bpf/core.c:2179: + STX_ATOMIC_H: WARNING: labels should not be indented #241: FILE: kernel/bpf/core.c:2180: + STX_ATOMIC_B: WARNING: macros should not use a trailing semicolon #279: FILE: kernel/bpf/core.c:2220: +#define LOAD_ACQUIRE(SIZEOP, SIZE) \ + case BPF_##SIZEOP: \ + DST = (SIZE)smp_load_acquire( \ + (SIZE *)(unsigned long)(SRC + insn->off)); \ + break; WARNING: memory barrier without comment #281: FILE: kernel/bpf/core.c:2222: + DST = (SIZE)smp_load_acquire( \ WARNING: line length of 89 exceeds 80 columns #282: FILE: kernel/bpf/core.c:2223: + (SIZE *)(unsigned long)(SRC + insn->off)); \ ERROR: spaces required around that ':' (ctx:VxE) #289: FILE: kernel/bpf/core.c:2230: + default: ^ CHECK: Macro argument 'SIZE' may be better as '(SIZE)' to avoid precedence issues #295: FILE: kernel/bpf/core.c:2236: +#define STORE_RELEASE(SIZEOP, SIZE) \ + case BPF_##SIZEOP: \ + smp_store_release( \ + (SIZE *)(unsigned long)(DST + insn->off), (SIZE)SRC); \ + break; WARNING: macros should not use a trailing semicolon #295: FILE: kernel/bpf/core.c:2236: +#define STORE_RELEASE(SIZEOP, SIZE) \ + case BPF_##SIZEOP: \ + smp_store_release( \ + (SIZE *)(unsigned long)(DST + insn->off), (SIZE)SRC); \ + break; WARNING: memory barrier without comment #297: FILE: kernel/bpf/core.c:2238: + smp_store_release( \ WARNING: line length of 97 exceeds 80 columns #298: FILE: kernel/bpf/core.c:2239: + (SIZE *)(unsigned long)(DST + insn->off), (SIZE)SRC); \ ERROR: spaces required around that ':' (ctx:VxE) #305: FILE: kernel/bpf/core.c:2246: + default: ^ WARNING: line length of 98 exceeds 80 columns #321: FILE: kernel/bpf/disasm.c:272: + verbose(cbs->private_data, "(%02x) r%d = load_acquire((%s *)(r%d %+d))\n", WARNING: line length of 98 exceeds 80 columns #327: FILE: kernel/bpf/disasm.c:278: + verbose(cbs->private_data, "(%02x) store_release((%s *)(r%d %+d), r%d)\n", WARNING: line length of 82 exceeds 80 columns #443: FILE: tools/include/uapi/linux/bpf.h:64: +#define BPF_LOAD_ACQ (BPF_ATOMIC_LOAD | BPF_ACQUIRE) /* load-acquire */ WARNING: line length of 83 exceeds 80 columns #444: FILE: tools/include/uapi/linux/bpf.h:65: +#define BPF_STORE_REL (BPF_ATOMIC_STORE | BPF_RELEASE) /* store-release */ total: 2 errors, 14 warnings, 1 checks, 321 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 0af766be0cd2 ("bpf: Introduce load-acquire and store-release instructions") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.