CHECK: Macro argument 'ptr' may be better as '(ptr)' to avoid precedence issues #65: FILE: kernel/locking/rqspinlock.c:354: +#define res_smp_cond_load_acquire(ptr, cond_expr) ({ \ + __unqual_scalar_typeof(*ptr) _val; \ + _val = res_smp_cond_load_relaxed(ptr, cond_expr); \ + smp_acquire__after_ctrl_dep(); \ + (typeof(*ptr))_val; \ +}) WARNING: line length of 88 exceeds 80 columns #72: FILE: kernel/locking/rqspinlock.c:361: +#define res_atomic_cond_read_acquire(v, c) res_smp_cond_load_acquire(&(v)->counter, (c)) WARNING: line length of 109 exceeds 80 columns #82: FILE: kernel/locking/rqspinlock.c:457: + res_smp_cond_load_acquire(&lock->locked, !VAL || RES_CHECK_TIMEOUT(ts, ret, _Q_LOCKED_MASK)); WARNING: line length of 89 exceeds 80 columns #92: FILE: kernel/locking/rqspinlock.c:606: + val = res_atomic_cond_read_acquire(&lock->val, !(VAL & _Q_LOCKED_PENDING_MASK) || WARNING: line length of 95 exceeds 80 columns #93: FILE: kernel/locking/rqspinlock.c:607: + RES_CHECK_TIMEOUT(ts, ret, _Q_LOCKED_PENDING_MASK)); total: 0 errors, 4 warnings, 1 checks, 59 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 220c867ef9a3 ("rqspinlock: Hardcode cond_acquire loops to asm-generic implementation") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 4 warnings, 1 checks, 59 lines checked