WARNING: externs should be avoided in .c files #141: FILE: tools/testing/selftests/bpf/bench.c:286: +extern struct argp bench_dynptr_key_argp; WARNING: externs should be avoided in .c files #157: FILE: tools/testing/selftests/bpf/bench.c:554: +extern const struct bench bench_norm_htab_lookup; WARNING: externs should be avoided in .c files #158: FILE: tools/testing/selftests/bpf/bench.c:555: +extern const struct bench bench_dynkey_htab_lookup; WARNING: externs should be avoided in .c files #159: FILE: tools/testing/selftests/bpf/bench.c:556: +extern const struct bench bench_norm_htab_update; WARNING: externs should be avoided in .c files #160: FILE: tools/testing/selftests/bpf/bench.c:557: +extern const struct bench bench_dynkey_htab_update; WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #176: new file mode 100644 WARNING: line length of 81 exceeds 80 columns #241: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:61: +static error_t dynptr_key_parse_arg(int key, char *arg, struct argp_state *state) WARNING: line length of 90 exceeds 80 columns #269: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:89: +static int count_nr_item(const char *name, char *buf, size_t size, unsigned int *nr_items) WARNING: line length of 89 exceeds 80 columns #312: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:132: +static int parse_data_set(const char *name, struct var_size_str ***set, unsigned int *nr, WARNING: line length of 94 exceeds 80 columns #338: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:158: + items = (struct var_size_str **)calloc(nr_items, sizeof(*items) + FILE_DATA_MAX_SIZE); WARNING: line length of 96 exceeds 80 columns #383: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:203: + fprintf(stdout, "few lines in %s (exp %u got %u)\n", name, nr_items, i); WARNING: line length of 92 exceeds 80 columns #396: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:216: +static int gen_data_set(unsigned int max_size, struct var_size_str ***set, unsigned int *nr, WARNING: line length of 94 exceeds 80 columns #424: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:244: + fprintf(stderr, "getrandom error %s got %zd\n", strerror(errno), got); WARNING: line length of 84 exceeds 80 columns #466: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:286: + fprintf(stderr, "dynptr_key benchmark doesn't support consumer!\n"); WARNING: line length of 93 exceeds 80 columns #471: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:291: + fprintf(stderr, "must specify entries when use random generated data set\n"); WARNING: line length of 97 exceeds 80 columns #481: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:301: + fprintf(stderr, "invalid max size %u (should be power-of-two)\n", args.max_size); WARNING: line length of 91 exceeds 80 columns #486: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:306: +static void dynptr_key_init_map_opts(struct dynptr_key_bench *skel, unsigned int data_size, WARNING: line length of 94 exceeds 80 columns #494: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:314: + bpf_map__set_key_size(skel->maps.htab, offsetof(struct dynkey_key, desc) + data_size); WARNING: line length of 84 exceeds 80 columns #501: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:321: +static void dynptr_key_setup_key_map(struct bpf_map *map, struct var_size_str **set, WARNING: line length of 83 exceeds 80 columns #554: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:374: +static void dynptr_key_setup_lookup_map(struct bpf_map *map, unsigned int map_type, WARNING: line length of 83 exceeds 80 columns #555: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:375: + struct var_size_str **set, unsigned int nr) WARNING: line length of 86 exceeds 80 columns #569: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:389: + bpf_dynptr_user_init(set[i]->data, set[i]->len, &dynkey.desc); WARNING: line length of 91 exceeds 80 columns #596: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:416: + stddev += (mean - set[i]->len) * (mean - set[i]->len) / (nr - 1.0); WARNING: line length of 88 exceeds 80 columns #600: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:420: + fprintf(stdout, "str length: max %u mean %.0f stdev %.0f\n", max, mean, stddev); WARNING: line length of 81 exceeds 80 columns #666: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:486: + map = (map_type == NORM_HTAB) ? skel->maps.htab : skel->maps.dynkey_htab; WARNING: line length of 83 exceeds 80 columns #728: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:548: + struct run_stat *s = (void *)&ctx.skel->bss->percpu_stats[i & 255]; WARNING: line length of 83 exceeds 80 columns #746: FILE: tools/testing/selftests/bpf/benchs/bench_dynptr_key.c:566: + fprintf(stdout, "Slab: %.3f MiB\n", (float)ctx.map_slab_mem / 1024 / 1024); WARNING: Prefer __aligned(256) over __attribute__((__aligned__(256))) #904: FILE: tools/testing/selftests/bpf/progs/dynptr_key_bench.c:49: +} __attribute__((__aligned__(256))) percpu_stats[256]; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #911: FILE: tools/testing/selftests/bpf/progs/dynptr_key_bench.c:56: +volatile const unsigned int max_dynkey_size; WARNING: line length of 87 exceeds 80 columns #934: FILE: tools/testing/selftests/bpf/progs/dynptr_key_bench.c:79: +static int lookup_dynkey_htab(struct bpf_map *map, __u32 *key, void *value, void *data) total: 0 errors, 30 warnings, 0 checks, 961 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e8939922d54d ("selftests/bpf: Add benchmark for dynptr key support in hash map") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 30 warnings, 0 checks, 961 lines checked