WARNING: line length of 83 exceeds 80 columns #50: FILE: include/linux/local_lock.h:35: + * interrupts. Fails in PREEMPT_RT when in hard IRQ or NMI. WARNING: do not add new typedefs #68: FILE: include/linux/local_lock_internal.h:18: +typedef struct { CHECK: spaces preferred around that '*' (ctx:WxO) #117: FILE: include/linux/local_lock_internal.h:117: + local_trylock_t *: ({ \ ^ ERROR: spaces required around that ':' (ctx:OxW) #117: FILE: include/linux/local_lock_internal.h:117: + local_trylock_t *: ({ \ ^ CHECK: spaces required around that ':' (ctx:VxV) #121: FILE: include/linux/local_lock_internal.h:121: + default:(void)0); \ ^ ERROR: trailing statements should be on next line #121: FILE: include/linux/local_lock_internal.h:121: + default:(void)0); \ CHECK: Please don't use multiple blank lines #125: FILE: include/linux/local_lock_internal.h:125: + CHECK: spaces preferred around that '*' (ctx:WxO) #155: FILE: include/linux/local_lock_internal.h:161: + local_trylock_t *: ({ \ ^ ERROR: spaces required around that ':' (ctx:OxW) #155: FILE: include/linux/local_lock_internal.h:161: + local_trylock_t *: ({ \ ^ CHECK: spaces required around that ':' (ctx:VxV) #159: FILE: include/linux/local_lock_internal.h:165: + default:(void)0); \ ^ ERROR: trailing statements should be on next line #159: FILE: include/linux/local_lock_internal.h:165: + default:(void)0); \ WARNING: do not add new typedefs #168: FILE: include/linux/local_lock_internal.h:186: +typedef spinlock_t local_trylock_t; WARNING: Macros with flow control statements should be avoided #176: FILE: include/linux/local_lock_internal.h:210: +#define __local_trylock_irqsave(lock, flags) \ + ({ \ + __label__ out; \ + int ret = 0; \ + typecheck(unsigned long, flags); \ + flags = 0; \ + if (in_nmi() || in_hardirq()) \ + goto out; \ + migrate_disable(); \ + ret = spin_trylock(this_cpu_ptr((lock))); \ + if (!ret) \ + migrate_enable(); \ + out: \ + ret; \ + }) WARNING: labels should not be indented #188: FILE: include/linux/local_lock_internal.h:222: + out: \ total: 4 errors, 5 warnings, 5 checks, 139 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 13e493af8c9e ("locking/local_lock: Introduce local_trylock_t and local_trylock_irqsave()") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.