WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #46: new file mode 100644 CHECK: architecture specific defines should be avoided #82: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:32: +#if defined(__s390x__) CHECK: No space is necessary after a cast #131: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:81: + na = (struct nlattr *) GENLMSG_DATA(&msg); CHECK: No space is necessary after a cast #137: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:87: + buf = (char *) &msg; CHECK: No space is necessary after a cast #142: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:92: + while ((r = sendto(fd, buf, buflen, 0, (struct sockaddr *) &nladdr, CHECK: No space is necessary after a cast #172: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:122: + ret = bind(fd, (struct sockaddr *) &nl_src, sizeof(nl_src)); CHECK: Unnecessary parentheses around 'ret < 0' #184: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:134: + if (!ASSERT_FALSE(msg.n.nlmsg_type == NLMSG_ERROR || (ret < 0) || + !NLMSG_OK((&msg.n), ret), "nl_family response")) CHECK: Unnecessary parentheses around '&msg.n' #184: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:134: + if (!ASSERT_FALSE(msg.n.nlmsg_type == NLMSG_ERROR || (ret < 0) || + !NLMSG_OK((&msg.n), ret), "nl_family response")) CHECK: No space is necessary after a cast #188: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:138: + nl = (struct nlattr *) GENLMSG_DATA(&msg); CHECK: No space is necessary after a cast #189: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:139: + nl = (struct nlattr *) ((char *) nl + NLA_ALIGN(nl->nla_len)); CHECK: No space is necessary after a cast #193: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:143: + smc_nl_family_id = *(uint16_t *) NLA_DATA(nl); CHECK: No space is necessary after a cast #222: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:172: + ret = bind(fd, (struct sockaddr *) &nl_src, sizeof(nl_src)); CHECK: Unnecessary parentheses around 'ret < 0' #233: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:183: + if (!ASSERT_FALSE((ret < 0) || + !NLMSG_OK((&msg.n), ret), "ueid response")) CHECK: Unnecessary parentheses around '&msg.n' #233: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:183: + if (!ASSERT_FALSE((ret < 0) || + !NLMSG_OK((&msg.n), ret), "ueid response")) CHECK: Alignment should match open parenthesis #234: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:184: + if (!ASSERT_FALSE((ret < 0) || + !NLMSG_OK((&msg.n), ret), "ueid response")) WARNING: line length of 82 exceeds 80 columns #326: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:276: + return !ASSERT_OK(bind(fd, &localaddr, sizeof(localaddr)), "client bind"); CHECK: No space is necessary after a cast #567: FILE: tools/testing/selftests/bpf/progs/bpf_smc.c:115: + .set_option = (void *) bpf_smc_set_tcp_option, CHECK: No space is necessary after a cast #568: FILE: tools/testing/selftests/bpf/progs/bpf_smc.c:116: + .set_option_cond = (void *) bpf_smc_set_tcp_option_cond, total: 0 errors, 2 warnings, 16 checks, 520 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 470e63c41c8e ("bpf/selftests: add selftest for bpf_smc_ops") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 2 warnings, 16 checks, 520 lines checked