WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 WARNING: line length of 191 exceeds 80 columns #79: FILE: tools/testing/selftests/net/proc_net_pktgen.c:34: +static const char dev_cmd_imix_weights_1[] = "imix_weights 101,1 102,2 103,3 104,4 105,5 106,6 107,7 108,8 109,9 110,10 111,11 112,12 113,13 114,14 115,15 116,16 117,17 118,18 119,19 120,20"; WARNING: line length of 198 exceeds 80 columns #80: FILE: tools/testing/selftests/net/proc_net_pktgen.c:35: +static const char dev_cmd_imix_weights_2[] = "imix_weights 100,1 102,2 103,3 104,4 105,5 106,6 107,7 108,8 109,9 110,10 111,11 112,12 113,13 114,14 115,15 116,16 117,17 118,18 119,19 120,20 121,21"; WARNING: line length of 84 exceeds 80 columns #111: FILE: tools/testing/selftests/net/proc_net_pktgen.c:66: +static const char dev_cmd_dst6_0[] = "dst6 2001:db38:1234:0000:0000:0000:0000:0000"; WARNING: line length of 91 exceeds 80 columns #112: FILE: tools/testing/selftests/net/proc_net_pktgen.c:67: +static const char dev_cmd_dst6_min_0[] = "dst6_min 2001:db8:1234:0000:0000:0000:0000:0000"; WARNING: line length of 91 exceeds 80 columns #113: FILE: tools/testing/selftests/net/proc_net_pktgen.c:68: +static const char dev_cmd_dst6_max_0[] = "dst6_max 2001:db8:1234:0000:0000:0000:0000:0000"; WARNING: line length of 84 exceeds 80 columns #114: FILE: tools/testing/selftests/net/proc_net_pktgen.c:69: +static const char dev_cmd_src6_0[] = "src6 2001:db38:1234:0000:0000:0000:0000:0000"; WARNING: line length of 188 exceeds 80 columns #127: FILE: tools/testing/selftests/net/proc_net_pktgen.c:82: +static const char dev_cmd_mpls_2[] = "mpls 00000f00,00000f01,00000f02,00000f03,00000f04,00000f05,00000f06,00000f07,00000f08,00000f09,00000f0a,00000f0b,00000f0c,00000f0d,00000f0e,00000f0f"; WARNING: line length of 197 exceeds 80 columns #128: FILE: tools/testing/selftests/net/proc_net_pktgen.c:83: +static const char dev_cmd_mpls_3[] = "mpls 00000f00,00000f01,00000f02,00000f03,00000f04,00000f05,00000f06,00000f07,00000f08,00000f09,00000f0a,00000f0b,00000f0c,00000f0d,00000f0e,00000f0f,00000f10"; WARNING: line length of 91 exceeds 80 columns #153: FILE: tools/testing/selftests/net/proc_net_pktgen.c:108: + ASSERT_EQ(r, 0) TH_LOG("CONFIG_NET_PKTGEN not enabled, module pktgen not loaded?"); WARNING: line length of 103 exceeds 80 columns #156: FILE: tools/testing/selftests/net/proc_net_pktgen.c:111: + ASSERT_GE(self->ctrl_fd, 0) TH_LOG("CONFIG_NET_PKTGEN not enabled, module pktgen not loaded?"); WARNING: line length of 89 exceeds 80 columns #159: FILE: tools/testing/selftests/net/proc_net_pktgen.c:114: + ASSERT_EQ(len, sizeof(add_loopback_0)) TH_LOG("device lo@0 already registered?"); WARNING: line length of 90 exceeds 80 columns #219: FILE: tools/testing/selftests/net/proc_net_pktgen.c:174: + len = write(self->dev_fd, dev_cmd_min_pkt_size_0, sizeof(dev_cmd_min_pkt_size_0)); WARNING: line length of 94 exceeds 80 columns #224: FILE: tools/testing/selftests/net/proc_net_pktgen.c:179: + len = write(self->dev_fd, dev_cmd_min_pkt_size_0, sizeof(dev_cmd_min_pkt_size_0) - 1); WARNING: line length of 90 exceeds 80 columns #229: FILE: tools/testing/selftests/net/proc_net_pktgen.c:184: + len = write(self->dev_fd, dev_cmd_min_pkt_size_1, sizeof(dev_cmd_min_pkt_size_1)); WARNING: line length of 94 exceeds 80 columns #234: FILE: tools/testing/selftests/net/proc_net_pktgen.c:189: + len = write(self->dev_fd, dev_cmd_min_pkt_size_1, sizeof(dev_cmd_min_pkt_size_1) - 1); WARNING: line length of 90 exceeds 80 columns #239: FILE: tools/testing/selftests/net/proc_net_pktgen.c:194: + len = write(self->dev_fd, dev_cmd_min_pkt_size_2, sizeof(dev_cmd_min_pkt_size_2)); WARNING: line length of 94 exceeds 80 columns #243: FILE: tools/testing/selftests/net/proc_net_pktgen.c:198: + len = write(self->dev_fd, dev_cmd_min_pkt_size_2, sizeof(dev_cmd_min_pkt_size_2) - 1); WARNING: line length of 90 exceeds 80 columns #246: FILE: tools/testing/selftests/net/proc_net_pktgen.c:201: + len = write(self->dev_fd, dev_cmd_min_pkt_size_3, sizeof(dev_cmd_min_pkt_size_3)); WARNING: line length of 90 exceeds 80 columns #249: FILE: tools/testing/selftests/net/proc_net_pktgen.c:204: + len = write(self->dev_fd, dev_cmd_min_pkt_size_4, sizeof(dev_cmd_min_pkt_size_4)); WARNING: line length of 90 exceeds 80 columns #252: FILE: tools/testing/selftests/net/proc_net_pktgen.c:207: + len = write(self->dev_fd, dev_cmd_min_pkt_size_5, sizeof(dev_cmd_min_pkt_size_5)); WARNING: line length of 90 exceeds 80 columns #255: FILE: tools/testing/selftests/net/proc_net_pktgen.c:210: + len = write(self->dev_fd, dev_cmd_min_pkt_size_6, sizeof(dev_cmd_min_pkt_size_6)); WARNING: line length of 90 exceeds 80 columns #258: FILE: tools/testing/selftests/net/proc_net_pktgen.c:213: + len = write(self->dev_fd, dev_cmd_min_pkt_size_7, sizeof(dev_cmd_min_pkt_size_7)); WARNING: line length of 90 exceeds 80 columns #261: FILE: tools/testing/selftests/net/proc_net_pktgen.c:216: + len = write(self->dev_fd, dev_cmd_min_pkt_size_8, sizeof(dev_cmd_min_pkt_size_8)); WARNING: line length of 90 exceeds 80 columns #268: FILE: tools/testing/selftests/net/proc_net_pktgen.c:223: + len = write(self->dev_fd, dev_cmd_max_pkt_size_0, sizeof(dev_cmd_max_pkt_size_0)); WARNING: line length of 82 exceeds 80 columns #275: FILE: tools/testing/selftests/net/proc_net_pktgen.c:230: + len = write(self->dev_fd, dev_cmd_pkt_size_0, sizeof(dev_cmd_pkt_size_0)); WARNING: line length of 90 exceeds 80 columns #282: FILE: tools/testing/selftests/net/proc_net_pktgen.c:237: + len = write(self->dev_fd, dev_cmd_imix_weights_0, sizeof(dev_cmd_imix_weights_0)); WARNING: line length of 90 exceeds 80 columns #285: FILE: tools/testing/selftests/net/proc_net_pktgen.c:240: + len = write(self->dev_fd, dev_cmd_imix_weights_1, sizeof(dev_cmd_imix_weights_1)); WARNING: line length of 90 exceeds 80 columns #288: FILE: tools/testing/selftests/net/proc_net_pktgen.c:243: + len = write(self->dev_fd, dev_cmd_imix_weights_2, sizeof(dev_cmd_imix_weights_2)); WARNING: line length of 88 exceeds 80 columns #347: FILE: tools/testing/selftests/net/proc_net_pktgen.c:302: + len = write(self->dev_fd, dev_cmd_udp_src_min_0, sizeof(dev_cmd_udp_src_min_0)); WARNING: line length of 88 exceeds 80 columns #354: FILE: tools/testing/selftests/net/proc_net_pktgen.c:309: + len = write(self->dev_fd, dev_cmd_udp_dst_min_0, sizeof(dev_cmd_udp_dst_min_0)); WARNING: line length of 88 exceeds 80 columns #361: FILE: tools/testing/selftests/net/proc_net_pktgen.c:316: + len = write(self->dev_fd, dev_cmd_udp_src_max_0, sizeof(dev_cmd_udp_src_max_0)); WARNING: line length of 88 exceeds 80 columns #368: FILE: tools/testing/selftests/net/proc_net_pktgen.c:323: + len = write(self->dev_fd, dev_cmd_udp_dst_max_0, sizeof(dev_cmd_udp_dst_max_0)); WARNING: line length of 84 exceeds 80 columns #376: FILE: tools/testing/selftests/net/proc_net_pktgen.c:331: + len = write(self->dev_fd, dev_cmd_clone_skb_0, sizeof(dev_cmd_clone_skb_0)); WARNING: line length of 84 exceeds 80 columns #381: FILE: tools/testing/selftests/net/proc_net_pktgen.c:336: + len = write(self->dev_fd, dev_cmd_clone_skb_1, sizeof(dev_cmd_clone_skb_1)); WARNING: line length of 92 exceeds 80 columns #395: FILE: tools/testing/selftests/net/proc_net_pktgen.c:350: + len = write(self->dev_fd, dev_cmd_src_mac_count_0, sizeof(dev_cmd_src_mac_count_0)); WARNING: line length of 92 exceeds 80 columns #402: FILE: tools/testing/selftests/net/proc_net_pktgen.c:357: + len = write(self->dev_fd, dev_cmd_dst_mac_count_0, sizeof(dev_cmd_dst_mac_count_0)); WARNING: line length of 84 exceeds 80 columns #424: FILE: tools/testing/selftests/net/proc_net_pktgen.c:379: + len = write(self->dev_fd, dev_cmd_xmit_mode_0, sizeof(dev_cmd_xmit_mode_0)); WARNING: line length of 84 exceeds 80 columns #427: FILE: tools/testing/selftests/net/proc_net_pktgen.c:382: + len = write(self->dev_fd, dev_cmd_xmit_mode_1, sizeof(dev_cmd_xmit_mode_1)); WARNING: line length of 84 exceeds 80 columns #430: FILE: tools/testing/selftests/net/proc_net_pktgen.c:385: + len = write(self->dev_fd, dev_cmd_xmit_mode_2, sizeof(dev_cmd_xmit_mode_2)); WARNING: line length of 84 exceeds 80 columns #433: FILE: tools/testing/selftests/net/proc_net_pktgen.c:388: + len = write(self->dev_fd, dev_cmd_xmit_mode_3, sizeof(dev_cmd_xmit_mode_3)); WARNING: line length of 82 exceeds 80 columns #484: FILE: tools/testing/selftests/net/proc_net_pktgen.c:439: + len = write(self->dev_fd, dev_cmd_dst6_min_0, sizeof(dev_cmd_dst6_min_0)); WARNING: line length of 82 exceeds 80 columns #491: FILE: tools/testing/selftests/net/proc_net_pktgen.c:446: + len = write(self->dev_fd, dev_cmd_dst6_max_0, sizeof(dev_cmd_dst6_max_0)); WARNING: line length of 94 exceeds 80 columns #533: FILE: tools/testing/selftests/net/proc_net_pktgen.c:488: + len = write(self->dev_fd, dev_cmd_clear_counters_0, sizeof(dev_cmd_clear_counters_0)); WARNING: line length of 81 exceeds 80 columns #548: FILE: tools/testing/selftests/net/proc_net_pktgen.c:503: + EXPECT_EQ(len, sizeof(dev_cmd_spi_0)) TH_LOG("CONFIG_XFRM not enabled?"); WARNING: line length of 92 exceeds 80 columns #561: FILE: tools/testing/selftests/net/proc_net_pktgen.c:516: + len = write(self->dev_fd, dev_cmd_queue_map_min_0, sizeof(dev_cmd_queue_map_min_0)); WARNING: line length of 92 exceeds 80 columns #568: FILE: tools/testing/selftests/net/proc_net_pktgen.c:523: + len = write(self->dev_fd, dev_cmd_queue_map_max_0, sizeof(dev_cmd_queue_map_max_0)); WARNING: line length of 82 exceeds 80 columns #598: FILE: tools/testing/selftests/net/proc_net_pktgen.c:553: + len = write(self->dev_fd, dev_cmd_vlan_cfi_0, sizeof(dev_cmd_vlan_cfi_0)); WARNING: line length of 82 exceeds 80 columns #608: FILE: tools/testing/selftests/net/proc_net_pktgen.c:563: + len = write(self->dev_fd, dev_cmd_svlan_id_0, sizeof(dev_cmd_svlan_id_0)); WARNING: line length of 84 exceeds 80 columns #614: FILE: tools/testing/selftests/net/proc_net_pktgen.c:569: + len = write(self->dev_fd, dev_cmd_svlan_cfi_0, sizeof(dev_cmd_svlan_cfi_0)); WARNING: line length of 82 exceeds 80 columns #617: FILE: tools/testing/selftests/net/proc_net_pktgen.c:572: + len = write(self->dev_fd, dev_cmd_svlan_id_1, sizeof(dev_cmd_svlan_id_1)); CHECK: Please don't use multiple blank lines #621: FILE: tools/testing/selftests/net/proc_net_pktgen.c:576: + + CHECK: Please don't use multiple blank lines #635: FILE: tools/testing/selftests/net/proc_net_pktgen.c:590: + + WARNING: line length of 92 exceeds 80 columns #639: FILE: tools/testing/selftests/net/proc_net_pktgen.c:594: + len = write(self->dev_fd, dev_cmd_traffic_class_0, sizeof(dev_cmd_traffic_class_0)); WARNING: line length of 90 exceeds 80 columns #646: FILE: tools/testing/selftests/net/proc_net_pktgen.c:601: + len = write(self->dev_fd, dev_cmd_skb_priority_0, sizeof(dev_cmd_skb_priority_0)); total: 0 errors, 53 warnings, 2 checks, 616 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit b7ea1d37b8bc ("selftest: net: add proc_net_pktgen") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 53 warnings, 2 checks, 616 lines checked