WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #66: new file mode 100644 WARNING: line length of 84 exceeds 80 columns #149: FILE: crypto/krb5/rfc3961_simplified.c:79: + const struct krb5_buffer *in, struct krb5_buffer *out) WARNING: Missing a blank line after declarations #153: FILE: crypto/krb5/rfc3961_simplified.c:83: + u8 local_iv[KRB5_MAX_BLOCKSIZE] __aligned(KRB5_MAX_BLOCKSIZE) = {0}; + SYNC_SKCIPHER_REQUEST_ON_STACK(req, tfm); WARNING: line length of 87 exceeds 80 columns #231: FILE: crypto/krb5/rfc3961_simplified.c:161: +static void rfc3961_nfold(const struct krb5_buffer *source, struct krb5_buffer *result) WARNING: line length of 83 exceeds 80 columns #239: FILE: crypto/krb5/rfc3961_simplified.c:169: + /* the code below is more readable if I make these bytes instead of bits */ CHECK: spaces preferred around that '-' (ctx:VxV) #253: FILE: crypto/krb5/rfc3961_simplified.c:183: + for (i = ulcm-1; i >= 0; i--) { ^ CHECK: Lines should not end with a '(' #255: FILE: crypto/krb5/rfc3961_simplified.c:185: + msbit = ( CHECK: spaces preferred around that '/' (ctx:VxV) #263: FILE: crypto/krb5/rfc3961_simplified.c:193: + (((inbits << 3) + 13) * (i/inbits)) + ^ WARNING: line length of 83 exceeds 80 columns #461: FILE: crypto/krb5/rfc3961_simplified.c:391: + ret = rfc3961_calc_DK(krb5, protocol_key, &prfconstant, &derived_key, gfp); total: 0 errors, 6 warnings, 3 checks, 430 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 049e6ca04d13 ("crypto/krb5: Implement the Kerberos5 rfc3961 key derivation") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 6 warnings, 3 checks, 430 lines checked