WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 WARNING: line length of 84 exceeds 80 columns #65: FILE: tools/testing/selftests/net/proc_net_pktgen.c:32: +static const char device_command_imix_weights_0[] = "imix_weights 0,7 576,4 1500,1"; WARNING: line length of 198 exceeds 80 columns #66: FILE: tools/testing/selftests/net/proc_net_pktgen.c:33: +static const char device_command_imix_weights_1[] = "imix_weights 101,1 102,2 103,3 104,4 105,5 106,6 107,7 108,8 109,9 110,10 111,11 112,12 113,13 114,14 115,15 116,16 117,17 118,18 119,19 120,20"; WARNING: line length of 205 exceeds 80 columns #67: FILE: tools/testing/selftests/net/proc_net_pktgen.c:34: +static const char device_command_imix_weights_2[] = "imix_weights 100,1 102,2 103,3 104,4 105,5 106,6 107,7 108,8 109,9 110,10 111,11 112,12 113,13 114,14 115,15 116,16 117,17 118,18 119,19 120,20 121,21"; WARNING: line length of 91 exceeds 80 columns #96: FILE: tools/testing/selftests/net/proc_net_pktgen.c:63: +static const char device_command_dst6_0[] = "dst6 2001:db38:1234:0000:0000:0000:0000:0000"; WARNING: line length of 98 exceeds 80 columns #97: FILE: tools/testing/selftests/net/proc_net_pktgen.c:64: +static const char device_command_dst6_min_0[] = "dst6_min 2001:db8:1234:0000:0000:0000:0000:0000"; WARNING: line length of 98 exceeds 80 columns #98: FILE: tools/testing/selftests/net/proc_net_pktgen.c:65: +static const char device_command_dst6_max_0[] = "dst6_max 2001:db8:1234:0000:0000:0000:0000:0000"; WARNING: line length of 91 exceeds 80 columns #99: FILE: tools/testing/selftests/net/proc_net_pktgen.c:66: +static const char device_command_src6_0[] = "src6 2001:db38:1234:0000:0000:0000:0000:0000"; WARNING: Consider removing the code enclosed by this #if 0 and its #endif #106: FILE: tools/testing/selftests/net/proc_net_pktgen.c:73: +#if 0 // needs CONFIG_XFRM WARNING: line length of 123 exceeds 80 columns #112: FILE: tools/testing/selftests/net/proc_net_pktgen.c:79: +static const char device_command_mpls_0[] = "mpls 00000001,000000f2,00000ff3,0000fff4,000ffff5,00fffff6,0ffffff7,fffffff8"; WARNING: line length of 103 exceeds 80 columns #136: FILE: tools/testing/selftests/net/proc_net_pktgen.c:103: + ASSERT_GE(self->ctrl_fd, 0) TH_LOG("CONFIG_NET_PKTGEN not enabled, module pktgen nod loaded?"); WARNING: line length of 89 exceeds 80 columns #139: FILE: tools/testing/selftests/net/proc_net_pktgen.c:106: + ASSERT_EQ(len, sizeof(add_loopback_0)) TH_LOG("device lo@0 already registered?"); WARNING: Missing a blank line after declarations #162: FILE: tools/testing/selftests/net/proc_net_pktgen.c:129: + ssize_t len = write(self->ctrl_fd, wrong_ctrl_command, i); + EXPECT_EQ(len, -1); WARNING: Missing a blank line after declarations #170: FILE: tools/testing/selftests/net/proc_net_pktgen.c:137: + ssize_t len = write(self->ctrl_fd, legacy_ctrl_command, i); + if (i < (sizeof(legacy_ctrl_command) - 1)) { WARNING: suspect code indent for conditional statements (16, 25) #174: FILE: tools/testing/selftests/net/proc_net_pktgen.c:141: + } else { [...] + EXPECT_EQ(len, i); WARNING: Missing a blank line after declarations #184: FILE: tools/testing/selftests/net/proc_net_pktgen.c:151: + ssize_t len = write(self->device_fd, wrong_device_command, i); + EXPECT_EQ(len, -1); WARNING: line length of 107 exceeds 80 columns #193: FILE: tools/testing/selftests/net/proc_net_pktgen.c:160: + len = write(self->device_fd, device_command_min_pkt_size_0, sizeof(device_command_min_pkt_size_0)); WARNING: line length of 111 exceeds 80 columns #198: FILE: tools/testing/selftests/net/proc_net_pktgen.c:165: + len = write(self->device_fd, device_command_min_pkt_size_0, sizeof(device_command_min_pkt_size_0) - 1); WARNING: line length of 107 exceeds 80 columns #203: FILE: tools/testing/selftests/net/proc_net_pktgen.c:170: + len = write(self->device_fd, device_command_min_pkt_size_1, sizeof(device_command_min_pkt_size_1)); WARNING: line length of 111 exceeds 80 columns #208: FILE: tools/testing/selftests/net/proc_net_pktgen.c:175: + len = write(self->device_fd, device_command_min_pkt_size_1, sizeof(device_command_min_pkt_size_1) - 1); WARNING: line length of 107 exceeds 80 columns #213: FILE: tools/testing/selftests/net/proc_net_pktgen.c:180: + len = write(self->device_fd, device_command_min_pkt_size_2, sizeof(device_command_min_pkt_size_2)); WARNING: line length of 111 exceeds 80 columns #217: FILE: tools/testing/selftests/net/proc_net_pktgen.c:184: + len = write(self->device_fd, device_command_min_pkt_size_2, sizeof(device_command_min_pkt_size_2) - 1); WARNING: line length of 107 exceeds 80 columns #220: FILE: tools/testing/selftests/net/proc_net_pktgen.c:187: + len = write(self->device_fd, device_command_min_pkt_size_3, sizeof(device_command_min_pkt_size_3)); WARNING: line length of 107 exceeds 80 columns #223: FILE: tools/testing/selftests/net/proc_net_pktgen.c:190: + len = write(self->device_fd, device_command_min_pkt_size_4, sizeof(device_command_min_pkt_size_4)); WARNING: line length of 107 exceeds 80 columns #226: FILE: tools/testing/selftests/net/proc_net_pktgen.c:193: + len = write(self->device_fd, device_command_min_pkt_size_5, sizeof(device_command_min_pkt_size_5)); WARNING: line length of 107 exceeds 80 columns #229: FILE: tools/testing/selftests/net/proc_net_pktgen.c:196: + len = write(self->device_fd, device_command_min_pkt_size_6, sizeof(device_command_min_pkt_size_6)); WARNING: line length of 107 exceeds 80 columns #232: FILE: tools/testing/selftests/net/proc_net_pktgen.c:199: + len = write(self->device_fd, device_command_min_pkt_size_7, sizeof(device_command_min_pkt_size_7)); WARNING: line length of 107 exceeds 80 columns #235: FILE: tools/testing/selftests/net/proc_net_pktgen.c:202: + len = write(self->device_fd, device_command_min_pkt_size_8, sizeof(device_command_min_pkt_size_8)); WARNING: line length of 107 exceeds 80 columns #242: FILE: tools/testing/selftests/net/proc_net_pktgen.c:209: + len = write(self->device_fd, device_command_max_pkt_size_0, sizeof(device_command_max_pkt_size_0)); WARNING: line length of 99 exceeds 80 columns #249: FILE: tools/testing/selftests/net/proc_net_pktgen.c:216: + len = write(self->device_fd, device_command_pkt_size_0, sizeof(device_command_pkt_size_0)); WARNING: line length of 107 exceeds 80 columns #256: FILE: tools/testing/selftests/net/proc_net_pktgen.c:223: + len = write(self->device_fd, device_command_imix_weights_0, sizeof(device_command_imix_weights_0)); WARNING: line length of 107 exceeds 80 columns #259: FILE: tools/testing/selftests/net/proc_net_pktgen.c:226: + len = write(self->device_fd, device_command_imix_weights_1, sizeof(device_command_imix_weights_1)); WARNING: line length of 107 exceeds 80 columns #262: FILE: tools/testing/selftests/net/proc_net_pktgen.c:229: + len = write(self->device_fd, device_command_imix_weights_2, sizeof(device_command_imix_weights_2)); WARNING: line length of 93 exceeds 80 columns #271: FILE: tools/testing/selftests/net/proc_net_pktgen.c:238: + len = write(self->device_fd, device_command_debug_0, sizeof(device_command_debug_0)); WARNING: line length of 93 exceeds 80 columns #275: FILE: tools/testing/selftests/net/proc_net_pktgen.c:242: + len = write(self->device_fd, device_command_debug_1, sizeof(device_command_debug_1)); WARNING: line length of 93 exceeds 80 columns #282: FILE: tools/testing/selftests/net/proc_net_pktgen.c:249: + len = write(self->device_fd, device_command_frags_0, sizeof(device_command_frags_0)); WARNING: line length of 93 exceeds 80 columns #289: FILE: tools/testing/selftests/net/proc_net_pktgen.c:256: + len = write(self->device_fd, device_command_delay_0, sizeof(device_command_delay_0)); WARNING: line length of 93 exceeds 80 columns #292: FILE: tools/testing/selftests/net/proc_net_pktgen.c:259: + len = write(self->device_fd, device_command_delay_1, sizeof(device_command_delay_1)); WARNING: line length of 91 exceeds 80 columns #299: FILE: tools/testing/selftests/net/proc_net_pktgen.c:266: + len = write(self->device_fd, device_command_rate_0, sizeof(device_command_rate_0)); WARNING: line length of 93 exceeds 80 columns #306: FILE: tools/testing/selftests/net/proc_net_pktgen.c:273: + len = write(self->device_fd, device_command_ratep_0, sizeof(device_command_ratep_0)); WARNING: line length of 105 exceeds 80 columns #313: FILE: tools/testing/selftests/net/proc_net_pktgen.c:280: + len = write(self->device_fd, device_command_udp_src_min_0, sizeof(device_command_udp_src_min_0)); WARNING: line length of 105 exceeds 80 columns #320: FILE: tools/testing/selftests/net/proc_net_pktgen.c:287: + len = write(self->device_fd, device_command_udp_dst_min_0, sizeof(device_command_udp_dst_min_0)); WARNING: line length of 105 exceeds 80 columns #327: FILE: tools/testing/selftests/net/proc_net_pktgen.c:294: + len = write(self->device_fd, device_command_udp_src_max_0, sizeof(device_command_udp_src_max_0)); WARNING: line length of 105 exceeds 80 columns #334: FILE: tools/testing/selftests/net/proc_net_pktgen.c:301: + len = write(self->device_fd, device_command_udp_dst_max_0, sizeof(device_command_udp_dst_max_0)); WARNING: line length of 101 exceeds 80 columns #342: FILE: tools/testing/selftests/net/proc_net_pktgen.c:309: + len = write(self->device_fd, device_command_clone_skb_0, sizeof(device_command_clone_skb_0)); WARNING: line length of 101 exceeds 80 columns #347: FILE: tools/testing/selftests/net/proc_net_pktgen.c:314: + len = write(self->device_fd, device_command_clone_skb_1, sizeof(device_command_clone_skb_1)); WARNING: line length of 93 exceeds 80 columns #354: FILE: tools/testing/selftests/net/proc_net_pktgen.c:321: + len = write(self->device_fd, device_command_count_0, sizeof(device_command_count_0)); WARNING: line length of 109 exceeds 80 columns #361: FILE: tools/testing/selftests/net/proc_net_pktgen.c:328: + len = write(self->device_fd, device_command_src_mac_count_0, sizeof(device_command_src_mac_count_0)); WARNING: line length of 109 exceeds 80 columns #368: FILE: tools/testing/selftests/net/proc_net_pktgen.c:335: + len = write(self->device_fd, device_command_dst_mac_count_0, sizeof(device_command_dst_mac_count_0)); WARNING: line length of 93 exceeds 80 columns #376: FILE: tools/testing/selftests/net/proc_net_pktgen.c:343: + len = write(self->device_fd, device_command_burst_0, sizeof(device_command_burst_0)); WARNING: line length of 91 exceeds 80 columns #383: FILE: tools/testing/selftests/net/proc_net_pktgen.c:350: + len = write(self->device_fd, device_command_node_0, sizeof(device_command_node_0)); WARNING: line length of 101 exceeds 80 columns #390: FILE: tools/testing/selftests/net/proc_net_pktgen.c:357: + len = write(self->device_fd, device_command_xmit_mode_0, sizeof(device_command_xmit_mode_0)); WARNING: line length of 101 exceeds 80 columns #393: FILE: tools/testing/selftests/net/proc_net_pktgen.c:360: + len = write(self->device_fd, device_command_xmit_mode_1, sizeof(device_command_xmit_mode_1)); WARNING: line length of 101 exceeds 80 columns #396: FILE: tools/testing/selftests/net/proc_net_pktgen.c:363: + len = write(self->device_fd, device_command_xmit_mode_2, sizeof(device_command_xmit_mode_2)); WARNING: line length of 101 exceeds 80 columns #399: FILE: tools/testing/selftests/net/proc_net_pktgen.c:366: + len = write(self->device_fd, device_command_xmit_mode_3, sizeof(device_command_xmit_mode_3)); WARNING: line length of 91 exceeds 80 columns #407: FILE: tools/testing/selftests/net/proc_net_pktgen.c:374: + len = write(self->device_fd, device_command_flag_0, sizeof(device_command_flag_0)); WARNING: line length of 91 exceeds 80 columns #411: FILE: tools/testing/selftests/net/proc_net_pktgen.c:378: + len = write(self->device_fd, device_command_flag_1, sizeof(device_command_flag_1)); WARNING: line length of 91 exceeds 80 columns #415: FILE: tools/testing/selftests/net/proc_net_pktgen.c:382: + len = write(self->device_fd, device_command_flag_2, sizeof(device_command_flag_2)); WARNING: line length of 97 exceeds 80 columns #422: FILE: tools/testing/selftests/net/proc_net_pktgen.c:389: + len = write(self->device_fd, device_command_dst_min_0, sizeof(device_command_dst_min_0)); WARNING: line length of 89 exceeds 80 columns #429: FILE: tools/testing/selftests/net/proc_net_pktgen.c:396: + len = write(self->device_fd, device_command_dst_0, sizeof(device_command_dst_0)); WARNING: line length of 97 exceeds 80 columns #436: FILE: tools/testing/selftests/net/proc_net_pktgen.c:403: + len = write(self->device_fd, device_command_dst_max_0, sizeof(device_command_dst_max_0)); WARNING: line length of 91 exceeds 80 columns #443: FILE: tools/testing/selftests/net/proc_net_pktgen.c:410: + len = write(self->device_fd, device_command_dst6_0, sizeof(device_command_dst6_0)); WARNING: line length of 99 exceeds 80 columns #450: FILE: tools/testing/selftests/net/proc_net_pktgen.c:417: + len = write(self->device_fd, device_command_dst6_min_0, sizeof(device_command_dst6_min_0)); WARNING: line length of 99 exceeds 80 columns #457: FILE: tools/testing/selftests/net/proc_net_pktgen.c:424: + len = write(self->device_fd, device_command_dst6_max_0, sizeof(device_command_dst6_max_0)); WARNING: line length of 91 exceeds 80 columns #464: FILE: tools/testing/selftests/net/proc_net_pktgen.c:431: + len = write(self->device_fd, device_command_src6_0, sizeof(device_command_src6_0)); WARNING: line length of 97 exceeds 80 columns #471: FILE: tools/testing/selftests/net/proc_net_pktgen.c:438: + len = write(self->device_fd, device_command_src_min_0, sizeof(device_command_src_min_0)); WARNING: line length of 97 exceeds 80 columns #478: FILE: tools/testing/selftests/net/proc_net_pktgen.c:445: + len = write(self->device_fd, device_command_src_max_0, sizeof(device_command_src_max_0)); WARNING: line length of 97 exceeds 80 columns #485: FILE: tools/testing/selftests/net/proc_net_pktgen.c:452: + len = write(self->device_fd, device_command_dst_mac_0, sizeof(device_command_dst_mac_0)); WARNING: line length of 97 exceeds 80 columns #492: FILE: tools/testing/selftests/net/proc_net_pktgen.c:459: + len = write(self->device_fd, device_command_src_mac_0, sizeof(device_command_src_mac_0)); WARNING: line length of 111 exceeds 80 columns #499: FILE: tools/testing/selftests/net/proc_net_pktgen.c:466: + len = write(self->device_fd, device_command_clear_counters_0, sizeof(device_command_clear_counters_0)); WARNING: line length of 93 exceeds 80 columns #506: FILE: tools/testing/selftests/net/proc_net_pktgen.c:473: + len = write(self->device_fd, device_command_flows_0, sizeof(device_command_flows_0)); WARNING: Consider removing the code enclosed by this #if 0 and its #endif #510: FILE: tools/testing/selftests/net/proc_net_pktgen.c:477: +#if 0 // needs CONFIG_XFRM WARNING: line length of 89 exceeds 80 columns #514: FILE: tools/testing/selftests/net/proc_net_pktgen.c:481: + len = write(self->device_fd, device_command_spi_0, sizeof(device_command_spi_0)); WARNING: line length of 97 exceeds 80 columns #522: FILE: tools/testing/selftests/net/proc_net_pktgen.c:489: + len = write(self->device_fd, device_command_flowlen_0, sizeof(device_command_flowlen_0)); WARNING: line length of 109 exceeds 80 columns #529: FILE: tools/testing/selftests/net/proc_net_pktgen.c:496: + len = write(self->device_fd, device_command_queue_map_min_0, sizeof(device_command_queue_map_min_0)); WARNING: line length of 109 exceeds 80 columns #536: FILE: tools/testing/selftests/net/proc_net_pktgen.c:503: + len = write(self->device_fd, device_command_queue_map_max_0, sizeof(device_command_queue_map_max_0)); WARNING: line length of 91 exceeds 80 columns #543: FILE: tools/testing/selftests/net/proc_net_pktgen.c:510: + len = write(self->device_fd, device_command_mpls_0, sizeof(device_command_mpls_0)); WARNING: line length of 97 exceeds 80 columns #550: FILE: tools/testing/selftests/net/proc_net_pktgen.c:517: + len = write(self->device_fd, device_command_vlan_id_0, sizeof(device_command_vlan_id_0)); WARNING: line length of 95 exceeds 80 columns #553: FILE: tools/testing/selftests/net/proc_net_pktgen.c:520: + len = write(self->device_fd, device_command_vlan_p_0, sizeof(device_command_vlan_p_0)); WARNING: line length of 99 exceeds 80 columns #556: FILE: tools/testing/selftests/net/proc_net_pktgen.c:523: + len = write(self->device_fd, device_command_vlan_cfi_0, sizeof(device_command_vlan_cfi_0)); WARNING: line length of 97 exceeds 80 columns #559: FILE: tools/testing/selftests/net/proc_net_pktgen.c:526: + len = write(self->device_fd, device_command_vlan_id_1, sizeof(device_command_vlan_id_1)); WARNING: line length of 99 exceeds 80 columns #566: FILE: tools/testing/selftests/net/proc_net_pktgen.c:533: + len = write(self->device_fd, device_command_svlan_id_0, sizeof(device_command_svlan_id_0)); WARNING: line length of 97 exceeds 80 columns #569: FILE: tools/testing/selftests/net/proc_net_pktgen.c:536: + len = write(self->device_fd, device_command_svlan_p_0, sizeof(device_command_svlan_p_0)); WARNING: line length of 101 exceeds 80 columns #572: FILE: tools/testing/selftests/net/proc_net_pktgen.c:539: + len = write(self->device_fd, device_command_svlan_cfi_0, sizeof(device_command_svlan_cfi_0)); WARNING: line length of 99 exceeds 80 columns #575: FILE: tools/testing/selftests/net/proc_net_pktgen.c:542: + len = write(self->device_fd, device_command_svlan_id_1, sizeof(device_command_svlan_id_1)); CHECK: Please don't use multiple blank lines #579: FILE: tools/testing/selftests/net/proc_net_pktgen.c:546: + + WARNING: line length of 89 exceeds 80 columns #583: FILE: tools/testing/selftests/net/proc_net_pktgen.c:550: + len = write(self->device_fd, device_command_tos_0, sizeof(device_command_tos_0)); WARNING: line length of 89 exceeds 80 columns #586: FILE: tools/testing/selftests/net/proc_net_pktgen.c:553: + len = write(self->device_fd, device_command_tos_1, sizeof(device_command_tos_1)); WARNING: line length of 89 exceeds 80 columns #589: FILE: tools/testing/selftests/net/proc_net_pktgen.c:556: + len = write(self->device_fd, device_command_tos_2, sizeof(device_command_tos_2)); CHECK: Please don't use multiple blank lines #593: FILE: tools/testing/selftests/net/proc_net_pktgen.c:560: + + WARNING: line length of 109 exceeds 80 columns #597: FILE: tools/testing/selftests/net/proc_net_pktgen.c:564: + len = write(self->device_fd, device_command_traffic_class_0, sizeof(device_command_traffic_class_0)); WARNING: line length of 107 exceeds 80 columns #604: FILE: tools/testing/selftests/net/proc_net_pktgen.c:571: + len = write(self->device_fd, device_command_skb_priority_0, sizeof(device_command_skb_priority_0)); total: 0 errors, 90 warnings, 2 checks, 582 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 4206d7871bb4 ("selftest: net: add proc_net_pktgen") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 90 warnings, 2 checks, 582 lines checked