========== checkpatch - FAILED ERROR: Macros with complex values should be enclosed in parentheses #69: FILE: include/trace/events/rxrpc.h:482: +#define rxrpc_pmtud_reduce_traces \ + EM(rxrpc_pmtud_reduce_ack, "Ack ") \ + EM(rxrpc_pmtud_reduce_icmp, "Icmp ") \ + E_(rxrpc_pmtud_reduce_route, "Route") CHECK: Lines should not end with a '(' #102: FILE: include/trace/events/rxrpc.h:2056: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #111: FILE: include/trace/events/rxrpc.h:2065: + TP_fast_assign( CHECK: Lines should not end with a '(' #134: FILE: include/trace/events/rxrpc.h:2088: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #143: FILE: include/trace/events/rxrpc.h:2097: + TP_fast_assign( CHECK: Lines should not end with a '(' #166: FILE: include/trace/events/rxrpc.h:2120: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #173: FILE: include/trace/events/rxrpc.h:2127: + TP_fast_assign( WARNING: line length of 82 exceeds 80 columns #189: FILE: include/trace/events/rxrpc.h:2143: + unsigned int max_data, enum rxrpc_pmtud_reduce_trace reason), CHECK: Lines should not end with a '(' #193: FILE: include/trace/events/rxrpc.h:2147: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #200: FILE: include/trace/events/rxrpc.h:2154: + TP_fast_assign( WARNING: line length of 83 exceeds 80 columns #209: FILE: include/trace/events/rxrpc.h:2163: + __print_symbolic(__entry->reason, rxrpc_pmtud_reduce_traces), WARNING: line length of 91 exceeds 80 columns #233: FILE: net/rxrpc/ar-internal.h:352: + unsigned int pmtud_good; /* Largest working MTU probe we've tried */ WARNING: line length of 96 exceeds 80 columns #234: FILE: net/rxrpc/ar-internal.h:353: + unsigned int pmtud_bad; /* Smallest non-working MTU probe we've tried */ WARNING: line length of 94 exceeds 80 columns #236: FILE: net/rxrpc/ar-internal.h:355: + bool pmtud_probing; /* T if we have an active probe outstanding */ WARNING: line length of 98 exceeds 80 columns #237: FILE: net/rxrpc/ar-internal.h:356: + bool pmtud_pending; /* T if a call to this peer should send a probe */ WARNING: line length of 83 exceeds 80 columns #238: FILE: net/rxrpc/ar-internal.h:357: + u8 pmtud_jumbo; /* Max jumbo packets for the MTU */ WARNING: line length of 87 exceeds 80 columns #239: FILE: net/rxrpc/ar-internal.h:358: + bool ackr_adv_pmtud; /* T if the peer advertises path-MTU */ WARNING: line length of 85 exceeds 80 columns #240: FILE: net/rxrpc/ar-internal.h:359: + unsigned int ackr_max_data; /* Maximum data advertised by peer */ WARNING: line length of 84 exceeds 80 columns #241: FILE: net/rxrpc/ar-internal.h:360: + seqcount_t mtu_lock; /* Lockless MTU access management */ WARNING: line length of 99 exceeds 80 columns #242: FILE: net/rxrpc/ar-internal.h:361: + unsigned int if_mtu; /* Local interface MTU (- hdrsize) for this peer */ WARNING: line length of 96 exceeds 80 columns #243: FILE: net/rxrpc/ar-internal.h:362: + unsigned int max_data; /* Maximum packet data capacity for this peer */ WARNING: line length of 84 exceeds 80 columns #244: FILE: net/rxrpc/ar-internal.h:363: + unsigned short hdrsize; /* header size (IP + UDP + RxRPC) */ WARNING: line length of 94 exceeds 80 columns #245: FILE: net/rxrpc/ar-internal.h:364: + unsigned short tx_seg_max; /* Maximum number of transmissable segments */ WARNING: line length of 92 exceeds 80 columns #271: FILE: net/rxrpc/ar-internal.h:1184: +void rxrpc_input_probe_for_pmtud(struct rxrpc_connection *conn, rxrpc_serial_t acked_serial, CHECK: multiple assignments should be avoided #315: FILE: net/rxrpc/conn_event.c:157: + max_mtu = if_mtu = umin(1444, if_mtu); WARNING: braces {} are not necessary for any arm of this statement #462: FILE: net/rxrpc/output.c:139: + if (call->peer->ackr_adv_pmtud) { [...] + } else { [...] CHECK: multiple assignments should be avoided #465: FILE: net/rxrpc/output.c:142: + max_mtu = if_mtu = umin(if_mtu, 1444); WARNING: line length of 92 exceeds 80 columns #490: FILE: net/rxrpc/output.c:216: + rxrpc_local_dont_fragment(conn->local, why == rxrpc_propose_ack_ping_for_mtu_probe); WARNING: line length of 94 exceeds 80 columns #528: FILE: net/rxrpc/output.c:277: + size_t probe_mtu = call->peer->pmtud_trial + sizeof(struct rxrpc_wire_header); WARNING: line length of 85 exceeds 80 columns #612: FILE: net/rxrpc/peer_event.c:132: + trace_rxrpc_pmtud_reduce(peer, 0, max_data, rxrpc_pmtud_reduce_icmp); WARNING: line length of 92 exceeds 80 columns #627: FILE: net/rxrpc/peer_event.c:362: +void rxrpc_input_probe_for_pmtud(struct rxrpc_connection *conn, rxrpc_serial_t acked_serial, CHECK: multiple assignments should be avoided #656: FILE: net/rxrpc/peer_event.c:391: + peer->pmtud_bad = bad = trial; CHECK: multiple assignments should be avoided #661: FILE: net/rxrpc/peer_event.c:396: + peer->pmtud_good = good = trial; WARNING: line length of 85 exceeds 80 columns #731: FILE: net/rxrpc/peer_object.c:211: + peer->max_data = umin(RXRPC_JUMBO(1), peer->if_mtu - peer->hdrsize); WARNING: quoted string split across lines #781: FILE: net/rxrpc/proc.c:288: " Remote " + " Use SST Maxd LastUse RTT RTO\n" WARNING: quoted string split across lines #790: FILE: net/rxrpc/proc.c:302: "UDP %-47.47s %-47.47s %3u" + " %4u %5u %6llus %8u %8u\n", ERROR: trailing whitespace #812: FILE: net/rxrpc/protocol.h:96: + *^I= ((65535 - 28 + 4) / 1416) $ WARNING: line length of 83 exceeds 80 columns #866: FILE: net/rxrpc/txbuf.c:183: + !is_zero_pfn(page_to_pfn(virt_to_page(txb->kvec[i].iov_base)))) total: 2 errors, 24 warnings, 12 checks, 716 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit ae16e9310825 ("rxrpc: Implement path-MTU probing using padded PING ACKs (RFC8899)") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.