WARNING: line length of 93 exceeds 80 columns #51: FILE: tools/testing/selftests/net/ovpn/common.sh:74: + ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 ${dev} ${laddr} \ ERROR: spaces required around that ':' (ctx:VxW) #193: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:540: + (socktype == SOCK_STREAM ? 0: AI_V4MAPPED) | ^ WARNING: line length of 133 exceeds 80 columns #199: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:546: + fprintf(stderr, "laddr %s, lport %s, getaddrinfo on local address: %s\n", ctx->laddr, ctx->lport, gai_strerror(ret)); CHECK: Comparison to NULL could be written "curr_ai" #206: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:550: + for (curr_ai = list_ai; curr_ai != NULL; curr_ai = curr_ai->ai_next) { WARNING: Missing a blank line after declarations #235: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:575: + int socket = ovpn_setup_socket(ctx, family, SOCK_DGRAM); + if (socket < 0) WARNING: Missing a blank line after declarations #247: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:586: + int ret, socket = ovpn_setup_socket(ctx, family, SOCK_STREAM); + if (socket < 0) WARNING: line length of 83 exceeds 80 columns #397: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:2263: + ret = ovpn_parse_new_peer(ovpn, argv[4], argv[5], argv[8], argv[9], WARNING: line length of 102 exceeds 80 columns #462: FILE: tools/testing/selftests/net/ovpn/test-bind.sh:66: + ip netns exec peer1 ${OVPN_CLI} new_peer tun1 ${dev1} 1 10 ${raddr4_peer2} 1 ${raddr4_peer1} 1 WARNING: line length of 102 exceeds 80 columns #465: FILE: tools/testing/selftests/net/ovpn/test-bind.sh:68: + ip netns exec peer2 ${OVPN_CLI} new_peer tun2 ${dev2} 10 1 ${raddr4_peer1} 1 ${raddr4_peer2} 1 WARNING: line length of 94 exceeds 80 columns #472: FILE: tools/testing/selftests/net/ovpn/test-bind.sh:74: + timeout 2 ip netns exec peer1 tcpdump -i veth1 "${PROTO,,}" and host ${raddr4_peer2} \ WARNING: line length of 94 exceeds 80 columns #476: FILE: tools/testing/selftests/net/ovpn/test-bind.sh:77: + timeout 2 ip netns exec peer1 tcpdump -i veth2 "${PROTO,,}" and host ${raddr4_peer2} \ WARNING: Possible repeated word: 'any' #517: FILE: tools/testing/selftests/net/ovpn/test-bind.sh:105: + run_bind_test any any 10.10.10.2 10.10.10.1 WARNING: Possible repeated word: 'any' #521: FILE: tools/testing/selftests/net/ovpn/test-bind.sh:109: + run_bind_test any any 20.20.20.2 20.20.20.1 WARNING: Possible repeated word: 'any' #537: FILE: tools/testing/selftests/net/ovpn/test-mark.sh:29: +ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 any any 1 ${UDP_PEERS_FILE} ${MARK} WARNING: line length of 87 exceeds 80 columns #537: FILE: tools/testing/selftests/net/ovpn/test-mark.sh:29: +ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 any any 1 ${UDP_PEERS_FILE} ${MARK} total: 1 errors, 13 warnings, 1 checks, 471 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 704c289e4d24 ("selftests: ovpn: add test for bound address") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.