====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/ovpn/test-bind.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.NmC6PkcTOc 2025-11-21 01:07:23.842116742 -0800 +++ /tmp/tmp.KLEnFpZafw 2025-11-21 01:07:24.486110325 -0800 @@ -175 +175 @@ -In common.sh line 70: +In common.sh line 72: @@ -183,2 +183,2 @@ -In common.sh line 71: - ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 1 ${UDP_PEERS_FILE} +In common.sh line 73: + ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 ${dev} 1 ${UDP_PEERS_FILE} @@ -186 +186,2 @@ - ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -189 +190 @@ - ip netns exec peer0 "${OVPN_CLI}" new_multi_peer tun0 1 "${UDP_PEERS_FILE}" + ip netns exec peer0 "${OVPN_CLI}" new_multi_peer tun0 "${dev}" 1 "${UDP_PEERS_FILE}" @@ -192 +193 @@ -In common.sh line 73: +In common.sh line 75: @@ -200 +201 @@ -In common.sh line 74: +In common.sh line 76: @@ -210 +211 @@ -In common.sh line 78: +In common.sh line 80: @@ -218 +219 @@ -In common.sh line 79: +In common.sh line 81: @@ -226 +227 @@ -In common.sh line 80: +In common.sh line 82: @@ -234 +235 @@ -In common.sh line 81: +In common.sh line 83: @@ -242,2 +243,2 @@ -In common.sh line 82: - ip netns exec peer${1} ${OVPN_CLI} new_peer tun${1} ${TX_ID} ${1} \ +In common.sh line 84: + ip netns exec peer${1} ${OVPN_CLI} new_peer tun${1} ${dev} ${TX_ID} ${1} \ @@ -247,2 +248,3 @@ - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -251 +253 @@ - ip netns exec peer"${1}" "${OVPN_CLI}" new_peer tun"${1}" "${TX_ID}" "${1}" \ + ip netns exec peer"${1}" "${OVPN_CLI}" new_peer tun"${1}" "${dev}" "${TX_ID}" "${1}" \ @@ -254 +256 @@ -In common.sh line 83: +In common.sh line 85: @@ -264 +266 @@ -In common.sh line 84: +In common.sh line 86: @@ -275 +277 @@ -In common.sh line 85: +In common.sh line 87: @@ -283 +285 @@ -In common.sh line 88: +In common.sh line 90: @@ -291 +293 @@ -In common.sh line 89: +In common.sh line 91: @@ -300 +302 @@ -In common.sh line 90: +In common.sh line 92: @@ -308 +310 @@ -In common.sh line 91: +In common.sh line 93: @@ -317 +319 @@ -In common.sh line 92: +In common.sh line 94: @@ -325 +327 @@ -In common.sh line 97: +In common.sh line 99: @@ -333 +335 @@ -In common.sh line 98: +In common.sh line 100: @@ -345 +347 @@ -In common.sh line 99: +In common.sh line 101: @@ -353 +355 @@ -In common.sh line 110: +In common.sh line 112: @@ -361 +363 @@ -In common.sh line 111: +In common.sh line 113: @@ -369 +371 @@ -In common.sh line 112: +In common.sh line 114: @@ -374 +376 @@ -In common.sh line 113: +In common.sh line 115: @@ -382 +384 @@ -In common.sh line 114: +In common.sh line 116: @@ -390 +392 @@ -In common.sh line 117: +In common.sh line 119: @@ -398 +400 @@ -In common.sh line 123: +In common.sh line 125: @@ -407 +409 @@ -In common.sh line 127: +In common.sh line 129: @@ -416 +418 @@ -In common.sh line 128: +In common.sh line 130: @@ -426 +428 @@ -In common.sh line 131: +In common.sh line 133: @@ -434 +436 @@ -In common.sh line 134: +In common.sh line 136: @@ -442 +444 @@ -In common.sh line 139: +In common.sh line 141: @@ -450 +452 @@ -In common.sh line 141: +In common.sh line 143: @@ -461,0 +464,98 @@ +In test-bind.sh line 38: +ip netns exec peer1 ${OVPN_CLI} new_iface tun1 P2P + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +ip netns exec peer1 "${OVPN_CLI}" new_iface tun1 P2P + + +In test-bind.sh line 39: +ip netns exec peer2 ${OVPN_CLI} new_iface tun2 P2P + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +ip netns exec peer2 "${OVPN_CLI}" new_iface tun2 P2P + + +In test-bind.sh line 58: + ip netns exec peer1 ${OVPN_CLI} del_peer tun1 1 2>/dev/null || true + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec peer1 "${OVPN_CLI}" del_peer tun1 1 2>/dev/null || true + + +In test-bind.sh line 59: + ip netns exec peer2 ${OVPN_CLI} del_peer tun2 10 2>/dev/null || true + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec peer2 "${OVPN_CLI}" del_peer tun2 10 2>/dev/null || true + + +In test-bind.sh line 62: + killall $(basename ${OVPN_CLI}) 2>/dev/null || true + ^---------------------^ SC2046 (warning): Quote this to prevent word splitting. + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + killall $(basename "${OVPN_CLI}") 2>/dev/null || true + + +In test-bind.sh line 64: + ip netns exec peer1 ${OVPN_CLI} new_peer tun1 ${dev1} 1 10 1 ${raddr4_peer1} 1 + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec peer1 "${OVPN_CLI}" new_peer tun1 "${dev1}" 1 10 1 "${raddr4_peer1}" 1 + + +In test-bind.sh line 65: + ip netns exec peer1 ${OVPN_CLI} new_key tun1 1 1 0 ${ALG} 0 data64.key + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec peer1 "${OVPN_CLI}" new_key tun1 1 1 0 "${ALG}" 0 data64.key + + +In test-bind.sh line 66: + ip netns exec peer2 ${OVPN_CLI} new_peer tun2 ${dev2} 10 1 1 ${raddr4_peer2} 1 + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec peer2 "${OVPN_CLI}" new_peer tun2 "${dev2}" 10 1 1 "${raddr4_peer2}" 1 + + +In test-bind.sh line 67: + ip netns exec peer2 ${OVPN_CLI} new_key tun2 10 1 0 ${ALG} 1 data64.key + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec peer2 "${OVPN_CLI}" new_key tun2 10 1 0 "${ALG}" 1 data64.key + + +In test-bind.sh line 69: + ip netns exec peer1 ${OVPN_CLI} set_peer tun1 1 60 120 + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec peer1 "${OVPN_CLI}" set_peer tun1 1 60 120 + + +In test-bind.sh line 70: + ip netns exec peer2 ${OVPN_CLI} set_peer tun2 10 60 120 + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec peer2 "${OVPN_CLI}" set_peer tun2 10 60 120 + +For more information: + https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... + @@ -488 +588 @@ -ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 1 ${UDP_PEERS_FILE} ${MARK} +ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 any 1 ${UDP_PEERS_FILE} ${MARK} @@ -490 +590 @@ - ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -493 +593 @@ -ip netns exec peer0 "${OVPN_CLI}" new_multi_peer tun0 1 "${UDP_PEERS_FILE}" ${MARK} +ip netns exec peer0 "${OVPN_CLI}" new_multi_peer tun0 any 1 "${UDP_PEERS_FILE}" ${MARK}