========== shellcheck - FAILED ====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/ovpn/test-mark.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.LOeyCxdQYb 2025-11-21 01:07:22.125133850 -0800 +++ /tmp/tmp.bVFVuMCLim 2025-11-21 01:07:22.652128599 -0800 @@ -0,0 +1,100 @@ + +In test-mark.sh line 20: +for p in $(seq 0 ${NUM_PEERS}); do + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +for p in $(seq 0 "${NUM_PEERS}"); do + + +In test-mark.sh line 21: + create_ns ${p} + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + create_ns "${p}" + + +In test-mark.sh line 25: + setup_ns ${p} 5.5.5.$((${p} + 1))/24 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. + +Did you mean: + setup_ns "${p}" 5.5.5.$((${p} + 1))/24 + + +In test-mark.sh line 29: +ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 1 ${UDP_PEERS_FILE} ${MARK} + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +ip netns exec peer0 "${OVPN_CLI}" new_multi_peer tun0 1 "${UDP_PEERS_FILE}" ${MARK} + + +In test-mark.sh line 31: + ip netns exec peer0 ${OVPN_CLI} new_key tun0 ${p} 1 0 ${ALG} 0 data64.key + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec peer0 "${OVPN_CLI}" new_key tun0 "${p}" 1 0 "${ALG}" 0 data64.key + + +In test-mark.sh line 35: + add_peer ${p} + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + add_peer "${p}" + + +In test-mark.sh line 39: + ip netns exec peer0 ${OVPN_CLI} set_peer tun0 ${p} 60 120 + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec peer0 "${OVPN_CLI}" set_peer tun0 "${p}" 60 120 + + +In test-mark.sh line 40: + ip netns exec peer${p} ${OVPN_CLI} set_peer tun${p} $((${p} + 9)) 60 120 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. + +Did you mean: + ip netns exec peer"${p}" "${OVPN_CLI}" set_peer tun"${p}" $((${p} + 9)) 60 120 + + +In test-mark.sh line 46: + ip netns exec peer0 ping -qfc 500 -s 3000 -w 3 5.5.5.$((${p} + 1)) + ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. + + +In test-mark.sh line 64: + DROP_COUNTER=$(($DROP_COUNTER+$LOST_PACKETS)) + ^-----------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. + ^-----------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. + + +In test-mark.sh line 69: +[ ${DROP_COUNTER} -eq ${TOTAL_COUNT} ] || exit 1 + ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +[ "${DROP_COUNTER}" -eq "${TOTAL_COUNT}" ] || exit 1 + + +In test-mark.sh line 76: + ip netns exec peer0 ping -qfc 500 -s 3000 -w 3 5.5.5.$((${p} + 1)) + ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. + +For more information: + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... + https://www.shellcheck.net/wiki/SC2004 -- $/${} is unnecessary on arithmeti...