====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.fWR0XeBbMj 2025-11-17 17:16:46.599605960 -0800 +++ /tmp/tmp.V9wIJswn5b 2025-11-17 17:16:47.232599219 -0800 @@ -11 +11 @@ -ALL_TESTS="fw_flash_test params_test regions_test reload_test \ +ALL_TESTS="fw_flash_test params_test \ @@ -15 +15 @@ -In devlink.sh line 9: +In devlink.sh line 10: @@ -20 +20 @@ -In devlink.sh line 10: +In devlink.sh line 11: @@ -29 +29 @@ -In devlink.sh line 22: +In devlink.sh line 23: @@ -37 +37 @@ -In devlink.sh line 43: +In devlink.sh line 44: @@ -45 +45 @@ -In devlink.sh line 45: +In devlink.sh line 46: @@ -54 +54 @@ -In devlink.sh line 48: +In devlink.sh line 49: @@ -63 +63 @@ -In devlink.sh line 51: +In devlink.sh line 52: @@ -72 +72 @@ -In devlink.sh line 54: +In devlink.sh line 55: @@ -80 +80 @@ -In devlink.sh line 57: +In devlink.sh line 58: @@ -89 +89 @@ -In devlink.sh line 60: +In devlink.sh line 61: @@ -98 +98 @@ -In devlink.sh line 63: +In devlink.sh line 64: @@ -106 +106 @@ -In devlink.sh line 66: +In devlink.sh line 67: @@ -115 +115 @@ -In devlink.sh line 69: +In devlink.sh line 70: @@ -123 +123 @@ -In devlink.sh line 72: +In devlink.sh line 73: @@ -132,2 +132,2 @@ -In devlink.sh line 91: - devlink dev param set $DL_HANDLE name $name cmode driverinit value $value +In devlink.sh line 95: + devlink dev param set $DL_HANDLE name $name cmode $cmode value $value @@ -136 +136,2 @@ - ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -139 +140 @@ - devlink dev param set "$DL_HANDLE" name "$name" cmode driverinit value "$value" + devlink dev param set "$DL_HANDLE" name "$name" cmode "$cmode" value "$value" @@ -142,2 +143,12 @@ -In devlink.sh line 102: - value=$(param_get $name) +In devlink.sh line 103: + devlink dev param set $DL_HANDLE name $name default cmode $cmode + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + devlink dev param set "$DL_HANDLE" name "$name" default cmode "$cmode" + + +In devlink.sh line 120: + value=$(param_get $name $attr $cmode) @@ -144,0 +156,2 @@ + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -147 +160 @@ - value=$(param_get "$name") + value=$(param_get "$name" "$attr" "$cmode") @@ -150 +163 @@ -In devlink.sh line 106: +In devlink.sh line 124: @@ -159 +172 @@ -In devlink.sh line 116: +In devlink.sh line 134: @@ -164 +177 @@ -In devlink.sh line 117: +In devlink.sh line 135: @@ -169 +182,59 @@ -In devlink.sh line 130: +In devlink.sh line 148: + devlink dev reload $DL_HANDLE + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + devlink dev reload "$DL_HANDLE" + + +In devlink.sh line 179: + local default_debugfs=$(value_to_debugfs $expected_default) + ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local default_debugfs=$(value_to_debugfs "$expected_default") + + +In devlink.sh line 180: + local new_debugfs=$(value_to_debugfs $new_value) + ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local new_debugfs=$(value_to_debugfs "$new_value") + + +In devlink.sh line 184: + check_value $param_name initial-default $expected_default $expected_debugfs $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_value "$param_name" initial-default "$expected_default" "$expected_debugfs" "$cmode" + + +In devlink.sh line 186: + param_set $param_name $new_value $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + param_set "$param_name" "$new_value" "$cmode" + + +In devlink.sh line 190: + check_value $param_name post-set $new_value $expected_debugfs $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_value "$param_name" post-set "$new_value" "$expected_debugfs" "$cmode" + + +In devlink.sh line 192: @@ -177 +248,59 @@ -In devlink.sh line 143: +In devlink.sh line 196: + check_value $param_name post-reload-new-value $new_value $expected_debugfs $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_value "$param_name" post-reload-new-value "$new_value" "$expected_debugfs" "$cmode" + + +In devlink.sh line 198: + param_set_default $param_name $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + param_set_default "$param_name" "$cmode" + + +In devlink.sh line 202: + check_value $param_name post-set-default $expected_default $expected_debugfs $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_value "$param_name" post-set-default "$expected_default" "$expected_debugfs" "$cmode" + + +In devlink.sh line 204: + devlink dev reload $DL_HANDLE + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + devlink dev reload "$DL_HANDLE" + + +In devlink.sh line 208: + check_value $param_name post-reload-default $expected_default $expected_debugfs $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_value "$param_name" post-reload-default "$expected_default" "$expected_debugfs" "$cmode" + + +In devlink.sh line 229: + devlink dev reload $DL_HANDLE + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + devlink dev reload "$DL_HANDLE" + + +In devlink.sh line 244: @@ -186 +315 @@ -In devlink.sh line 145: +In devlink.sh line 246: @@ -194 +323 @@ -In devlink.sh line 156: +In devlink.sh line 257: @@ -203 +332 @@ -In devlink.sh line 157: +In devlink.sh line 258: @@ -212 +341 @@ -In devlink.sh line 170: +In devlink.sh line 271: @@ -220 +349 @@ -In devlink.sh line 174: +In devlink.sh line 275: @@ -228 +357 @@ -In devlink.sh line 178: +In devlink.sh line 279: @@ -236 +365 @@ -In devlink.sh line 182: +In devlink.sh line 283: @@ -244 +373 @@ -In devlink.sh line 187: +In devlink.sh line 288: @@ -252 +381 @@ -In devlink.sh line 192: +In devlink.sh line 293: @@ -260 +389 @@ -In devlink.sh line 195: +In devlink.sh line 296: @@ -268 +397 @@ -In devlink.sh line 198: +In devlink.sh line 299: @@ -276 +405 @@ -In devlink.sh line 201: +In devlink.sh line 302: @@ -284 +413 @@ -In devlink.sh line 204: +In devlink.sh line 305: @@ -292 +421 @@ -In devlink.sh line 207: +In devlink.sh line 308: @@ -300 +429 @@ -In devlink.sh line 212: +In devlink.sh line 313: @@ -308 +437 @@ -In devlink.sh line 217: +In devlink.sh line 318: @@ -317 +446 @@ -In devlink.sh line 220: +In devlink.sh line 321: @@ -326 +455 @@ -In devlink.sh line 232: +In devlink.sh line 333: @@ -334 +463 @@ -In devlink.sh line 235: +In devlink.sh line 336: @@ -342 +471 @@ -In devlink.sh line 238: +In devlink.sh line 339: @@ -350 +479 @@ -In devlink.sh line 241: +In devlink.sh line 342: @@ -358 +487 @@ -In devlink.sh line 244: +In devlink.sh line 345: @@ -366 +495 @@ -In devlink.sh line 247: +In devlink.sh line 348: @@ -374 +503 @@ -In devlink.sh line 250: +In devlink.sh line 351: @@ -382 +511 @@ -In devlink.sh line 253: +In devlink.sh line 354: @@ -390 +519 @@ -In devlink.sh line 256: +In devlink.sh line 357: @@ -398 +527 @@ -In devlink.sh line 271: +In devlink.sh line 372: @@ -406 +535 @@ -In devlink.sh line 274: +In devlink.sh line 375: @@ -414 +543 @@ -In devlink.sh line 309: +In devlink.sh line 410: @@ -422 +551 @@ -In devlink.sh line 314: +In devlink.sh line 415: @@ -430 +559 @@ -In devlink.sh line 316: +In devlink.sh line 417: @@ -438 +567 @@ -In devlink.sh line 318: +In devlink.sh line 419: @@ -446 +575 @@ -In devlink.sh line 321: +In devlink.sh line 422: @@ -451 +580 @@ -In devlink.sh line 326: +In devlink.sh line 427: @@ -460 +589 @@ -In devlink.sh line 328: +In devlink.sh line 429: @@ -465 +594 @@ -In devlink.sh line 332: +In devlink.sh line 433: @@ -473 +602 @@ -In devlink.sh line 334: +In devlink.sh line 435: @@ -478 +607 @@ -In devlink.sh line 352: +In devlink.sh line 453: @@ -486 +615 @@ -In devlink.sh line 354: +In devlink.sh line 455: @@ -494 +623 @@ -In devlink.sh line 356: +In devlink.sh line 457: @@ -502 +631 @@ -In devlink.sh line 363: +In devlink.sh line 464: @@ -510 +639 @@ -In devlink.sh line 366: +In devlink.sh line 467: @@ -518 +647 @@ -In devlink.sh line 369: +In devlink.sh line 470: @@ -526 +655 @@ -In devlink.sh line 404: +In devlink.sh line 505: @@ -534 +663 @@ -In devlink.sh line 407: +In devlink.sh line 508: @@ -542 +671 @@ -In devlink.sh line 410: +In devlink.sh line 511: @@ -550 +679 @@ -In devlink.sh line 413: +In devlink.sh line 514: @@ -558 +687 @@ -In devlink.sh line 428: +In devlink.sh line 529: @@ -568 +697 @@ -In devlink.sh line 431: +In devlink.sh line 532: @@ -577 +706 @@ -In devlink.sh line 435: +In devlink.sh line 536: @@ -586 +715 @@ -In devlink.sh line 439: +In devlink.sh line 540: @@ -596 +725 @@ -In devlink.sh line 443: +In devlink.sh line 544: @@ -605 +734 @@ -In devlink.sh line 448: +In devlink.sh line 549: @@ -614 +743 @@ -In devlink.sh line 459: +In devlink.sh line 560: @@ -622 +751 @@ -In devlink.sh line 465: +In devlink.sh line 566: @@ -630 +759 @@ -In devlink.sh line 470: +In devlink.sh line 571: @@ -639 +768 @@ -In devlink.sh line 473: +In devlink.sh line 574: @@ -648 +777 @@ -In devlink.sh line 477: +In devlink.sh line 578: @@ -656 +785 @@ -In devlink.sh line 480: +In devlink.sh line 581: @@ -664 +793 @@ -In devlink.sh line 485: +In devlink.sh line 586: @@ -672 +801 @@ -In devlink.sh line 490: +In devlink.sh line 591: @@ -680 +809 @@ -In devlink.sh line 495: +In devlink.sh line 596: @@ -689 +818 @@ -In devlink.sh line 498: +In devlink.sh line 599: @@ -698 +827 @@ -In devlink.sh line 502: +In devlink.sh line 603: @@ -706 +835 @@ -In devlink.sh line 507: +In devlink.sh line 608: @@ -714 +843 @@ -In devlink.sh line 510: +In devlink.sh line 611: @@ -722 +851 @@ -In devlink.sh line 515: +In devlink.sh line 616: @@ -730 +859 @@ -In devlink.sh line 518: +In devlink.sh line 619: @@ -738 +867 @@ -In devlink.sh line 521: +In devlink.sh line 622: @@ -746 +875 @@ -In devlink.sh line 526: +In devlink.sh line 627: @@ -754 +883 @@ -In devlink.sh line 529: +In devlink.sh line 630: @@ -763 +892 @@ -In devlink.sh line 532: +In devlink.sh line 633: @@ -771 +900 @@ -In devlink.sh line 543: +In devlink.sh line 644: @@ -779 +908 @@ -In devlink.sh line 551: +In devlink.sh line 652: @@ -787 +916 @@ -In devlink.sh line 561: +In devlink.sh line 662: @@ -798 +927 @@ -In devlink.sh line 569: +In devlink.sh line 670: @@ -806 +935 @@ -In devlink.sh line 579: +In devlink.sh line 680: @@ -816 +945 @@ -In devlink.sh line 582: +In devlink.sh line 683: @@ -825 +954 @@ -In devlink.sh line 587: +In devlink.sh line 688: @@ -834 +963 @@ -In devlink.sh line 599: +In devlink.sh line 700: @@ -843 +972 @@ -In devlink.sh line 602: +In devlink.sh line 703: @@ -851 +980 @@ -In devlink.sh line 607: +In devlink.sh line 708: @@ -859 +988 @@ -In devlink.sh line 657: +In devlink.sh line 758: @@ -867 +996 @@ -In devlink.sh line 664: +In devlink.sh line 765: @@ -875 +1004 @@ -In devlink.sh line 669: +In devlink.sh line 770: @@ -880 +1009 @@ -In devlink.sh line 671: +In devlink.sh line 772: @@ -889 +1018 @@ -In devlink.sh line 672: +In devlink.sh line 773: @@ -897 +1026 @@ -In devlink.sh line 673: +In devlink.sh line 774: @@ -907 +1036 @@ -In devlink.sh line 674: +In devlink.sh line 775: @@ -917 +1046 @@ -In devlink.sh line 681: +In devlink.sh line 782: @@ -926 +1055 @@ -In devlink.sh line 682: +In devlink.sh line 783: @@ -935 +1064 @@ -In devlink.sh line 683: +In devlink.sh line 784: @@ -940 +1069 @@ -In devlink.sh line 689: +In devlink.sh line 790: @@ -949 +1078 @@ -In devlink.sh line 690: +In devlink.sh line 791: @@ -958 +1087 @@ -In devlink.sh line 691: +In devlink.sh line 792: @@ -963 +1092 @@ -In devlink.sh line 706: +In devlink.sh line 807: @@ -973 +1102 @@ -In devlink.sh line 707: +In devlink.sh line 808: @@ -981 +1110 @@ -In devlink.sh line 711: +In devlink.sh line 812: @@ -990 +1119 @@ -In devlink.sh line 712: +In devlink.sh line 813: @@ -999 +1128 @@ -In devlink.sh line 715: +In devlink.sh line 816: @@ -1008 +1137 @@ -In devlink.sh line 716: +In devlink.sh line 817: @@ -1017 +1146 @@ -In devlink.sh line 720: +In devlink.sh line 821: @@ -1025 +1154 @@ -In devlink.sh line 726: +In devlink.sh line 827: @@ -1035 +1164 @@ -In devlink.sh line 727: +In devlink.sh line 828: @@ -1043 +1172 @@ -In devlink.sh line 735: +In devlink.sh line 836: @@ -1052 +1181 @@ -In devlink.sh line 736: +In devlink.sh line 837: @@ -1061 +1190 @@ -In devlink.sh line 743: +In devlink.sh line 844: @@ -1070 +1199 @@ -In devlink.sh line 744: +In devlink.sh line 845: @@ -1079 +1208 @@ -In devlink.sh line 775: +In devlink.sh line 876: