WARNING: line length of 95 exceeds 80 columns #76: FILE: tools/testing/selftests/bpf/usdt.h:316: +#define USDT_NOP .byte 0x90, 0x0f, 0x1f, 0x44, 0x00, 0x0 /* nop, nop5 */ ERROR: Macros with complex values should be enclosed in parentheses #76: FILE: tools/testing/selftests/bpf/usdt.h:316: +#define USDT_NOP .byte 0x90, 0x0f, 0x1f, 0x44, 0x00, 0x0 /* nop, nop5 */ BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. WARNING: line length of 97 exceeds 80 columns #94: FILE: tools/testing/selftests/bpf/usdt.h:415: +#define __usdt_asm_extra \ ERROR: space prohibited after that open parenthesis '(' #95: FILE: tools/testing/selftests/bpf/usdt.h:416: + __usdt_asm1( .ascii "\0") WARNING: line length of 97 exceeds 80 columns #108: FILE: tools/testing/selftests/bpf/usdt.h:439: + __usdt_asm_extra \ total: 2 errors, 3 warnings, 0 checks, 38 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit a5c6348240c6 ("selftests/bpf: Emit nop,nop5 instructions for x86_64 usdt probe") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.