WARNING: line length of 107 exceeds 80 columns
#117: FILE: tools/net/ynl/tests/test_ynl_cli.sh:6:
+KSELFTEST_KTAP_HELPERS="$(dirname "$(realpath "$0")")/../../../testing/selftests/kselftest/ktap_helpers.sh"

WARNING: line length of 98 exceeds 80 columns
#149: FILE: tools/net/ynl/tests/test_ynl_cli.sh:38:
+	ifindex=$(ip netns exec "$testns" cat /sys/class/net/"$NSIM_DEV_NAME"/ifindex 2>/dev/null)

WARNING: line length of 98 exceeds 80 columns
#155: FILE: tools/net/ynl/tests/test_ynl_cli.sh:44:
+		ktap_test_fail "YNL CLI netdev operations (netdev dev-get output missing ifindex)"

WARNING: line length of 83 exceeds 80 columns
#160: FILE: tools/net/ynl/tests/test_ynl_cli.sh:49:
+		--dump queue-get --json "{\"ifindex\": $ifindex}" &>/dev/null; then

WARNING: line length of 92 exceeds 80 columns
#161: FILE: tools/net/ynl/tests/test_ynl_cli.sh:50:
+		ktap_test_fail "YNL CLI netdev operations (failed to get netdev queue info)"

WARNING: line length of 101 exceeds 80 columns
#176: FILE: tools/net/ynl/tests/test_ynl_cli.sh:65:
+		--do rings-get --json "{\"header\": {\"dev-name\": \"$NSIM_DEV_NAME\"}}" 2>/dev/null)

WARNING: line length of 101 exceeds 80 columns
#179: FILE: tools/net/ynl/tests/test_ynl_cli.sh:68:
+		ktap_test_fail "YNL CLI ethtool operations (ethtool rings-get output missing header)"

WARNING: line length of 97 exceeds 80 columns
#184: FILE: tools/net/ynl/tests/test_ynl_cli.sh:73:
+		--do linkinfo-get --json "{\"header\": {\"dev-name\": \"$VETH_A\"}}" 2>/dev/null)

WARNING: line length of 104 exceeds 80 columns
#187: FILE: tools/net/ynl/tests/test_ynl_cli.sh:76:
+		ktap_test_fail "YNL CLI ethtool operations (ethtool linkinfo-get output missing header)"

WARNING: line length of 92 exceeds 80 columns
#201: FILE: tools/net/ynl/tests/test_ynl_cli.sh:90:
+		ktap_test_skip "YNL CLI rt-route operations (rt-route family not available)"

WARNING: line length of 98 exceeds 80 columns
#205: FILE: tools/net/ynl/tests/test_ynl_cli.sh:94:
+	ifindex=$(ip netns exec "$testns" cat /sys/class/net/"$NSIM_DEV_NAME"/ifindex 2>/dev/null)

WARNING: line length of 84 exceeds 80 columns
#208: FILE: tools/net/ynl/tests/test_ynl_cli.sh:97:
+	if ! ip netns exec "$testns" $ynl --family rt-route --do newroute --create \

WARNING: line length of 204 exceeds 80 columns
#209: FILE: tools/net/ynl/tests/test_ynl_cli.sh:98:
+		--json "{\"dst\": \"192.0.2.0\", \"oif\": $ifindex, \"rtm-dst-len\": 24, \"rtm-family\": 2, \"rtm-scope\": 253, \"rtm-type\": 1, \"rtm-protocol\": 3, \"rtm-table\": 254}" &>/dev/null; then

WARNING: line length of 82 exceeds 80 columns
#210: FILE: tools/net/ynl/tests/test_ynl_cli.sh:99:
+		ktap_test_fail "YNL CLI rt-route operations (failed to add route)"

WARNING: line length of 98 exceeds 80 columns
#215: FILE: tools/net/ynl/tests/test_ynl_cli.sh:104:
+	route_output=$(ip netns exec "$testns" $ynl --family rt-route --dump getroute 2>/dev/null)

WARNING: line length of 85 exceeds 80 columns
#219: FILE: tools/net/ynl/tests/test_ynl_cli.sh:108:
+		ktap_test_fail "YNL CLI rt-route operations (failed to verify route)"

WARNING: line length of 198 exceeds 80 columns
#223: FILE: tools/net/ynl/tests/test_ynl_cli.sh:112:
+		--json "{\"dst\": \"192.0.2.0\", \"oif\": $ifindex, \"rtm-dst-len\": 24, \"rtm-family\": 2, \"rtm-scope\": 253, \"rtm-type\": 1, \"rtm-protocol\": 3, \"rtm-table\": 254}" &>/dev/null

WARNING: line length of 90 exceeds 80 columns
#233: FILE: tools/net/ynl/tests/test_ynl_cli.sh:122:
+		ktap_test_skip "YNL CLI rt-addr operations (rt-addr family not available)"

WARNING: line length of 98 exceeds 80 columns
#237: FILE: tools/net/ynl/tests/test_ynl_cli.sh:126:
+	ifindex=$(ip netns exec "$testns" cat /sys/class/net/"$NSIM_DEV_NAME"/ifindex 2>/dev/null)

WARNING: line length of 138 exceeds 80 columns
#240: FILE: tools/net/ynl/tests/test_ynl_cli.sh:129:
+		--json "{\"ifa-index\": $ifindex, \"local\": \"192.0.2.100\", \"ifa-prefixlen\": 24, \"ifa-family\": 2}" &>/dev/null; then

WARNING: line length of 83 exceeds 80 columns
#241: FILE: tools/net/ynl/tests/test_ynl_cli.sh:130:
+		ktap_test_fail "YNL CLI rt-addr operations (failed to add address)"

WARNING: line length of 95 exceeds 80 columns
#246: FILE: tools/net/ynl/tests/test_ynl_cli.sh:135:
+	addr_output=$(ip netns exec "$testns" $ynl --family rt-addr --dump getaddr 2>/dev/null)

WARNING: line length of 86 exceeds 80 columns
#250: FILE: tools/net/ynl/tests/test_ynl_cli.sh:139:
+		ktap_test_fail "YNL CLI rt-addr operations (failed to verify address)"

WARNING: line length of 132 exceeds 80 columns
#254: FILE: tools/net/ynl/tests/test_ynl_cli.sh:143:
+		--json "{\"ifa-index\": $ifindex, \"local\": \"192.0.2.100\", \"ifa-prefixlen\": 24, \"ifa-family\": 2}" &>/dev/null

WARNING: line length of 90 exceeds 80 columns
#262: FILE: tools/net/ynl/tests/test_ynl_cli.sh:151:
+		ktap_test_skip "YNL CLI rt-link operations (rt-link family not available)"

WARNING: line length of 82 exceeds 80 columns
#266: FILE: tools/net/ynl/tests/test_ynl_cli.sh:155:
+	if ! ip netns exec "$testns" $ynl --family rt-link --do newlink --create \

WARNING: line length of 104 exceeds 80 columns
#267: FILE: tools/net/ynl/tests/test_ynl_cli.sh:156:
+		--json "{\"ifname\": \"dummy0\", \"linkinfo\": {\"kind\": \"dummy\"}}" &>/dev/null; then

WARNING: line length of 95 exceeds 80 columns
#273: FILE: tools/net/ynl/tests/test_ynl_cli.sh:162:
+	link_output=$(ip netns exec "$testns" $ynl --family rt-link --dump getlink 2>/dev/null)

WARNING: line length of 105 exceeds 80 columns
#274: FILE: tools/net/ynl/tests/test_ynl_cli.sh:163:
+	if echo "$link_output" | grep -q "$NSIM_DEV_NAME" && echo "$link_output" | grep -q "dummy0"; then

WARNING: line length of 83 exceeds 80 columns
#277: FILE: tools/net/ynl/tests/test_ynl_cli.sh:166:
+		ktap_test_fail "YNL CLI rt-link operations (failed to verify link)"

WARNING: line length of 92 exceeds 80 columns
#291: FILE: tools/net/ynl/tests/test_ynl_cli.sh:180:
+		ktap_test_skip "YNL CLI rt-neigh operations (rt-neigh family not available)"

WARNING: line length of 98 exceeds 80 columns
#295: FILE: tools/net/ynl/tests/test_ynl_cli.sh:184:
+	ifindex=$(ip netns exec "$testns" cat /sys/class/net/"$NSIM_DEV_NAME"/ifindex 2>/dev/null)

WARNING: line length of 81 exceeds 80 columns
#297: FILE: tools/net/ynl/tests/test_ynl_cli.sh:186:
+	# Add neighbor: 192.0.2.1 dev nsim1338 lladdr 11:22:33:44:55:66 PERMANENT

WARNING: line length of 84 exceeds 80 columns
#298: FILE: tools/net/ynl/tests/test_ynl_cli.sh:187:
+	if ! ip netns exec "$testns" $ynl --family rt-neigh --do newneigh --create \

WARNING: line length of 168 exceeds 80 columns
#299: FILE: tools/net/ynl/tests/test_ynl_cli.sh:188:
+		--json "{\"ndm-ifindex\": $ifindex, \"dst\": \"192.0.2.1\", \"lladdr\": \"11:22:33:44:55:66\", \"ndm-family\": 2, \"ndm-state\": 128}" &>/dev/null; then

WARNING: line length of 85 exceeds 80 columns
#300: FILE: tools/net/ynl/tests/test_ynl_cli.sh:189:
+		ktap_test_fail "YNL CLI rt-neigh operations (failed to add neighbor)"

WARNING: line length of 98 exceeds 80 columns
#304: FILE: tools/net/ynl/tests/test_ynl_cli.sh:193:
+	neigh_output=$(ip netns exec "$testns" $ynl --family rt-neigh --dump getneigh 2>/dev/null)

WARNING: line length of 88 exceeds 80 columns
#308: FILE: tools/net/ynl/tests/test_ynl_cli.sh:197:
+		ktap_test_fail "YNL CLI rt-neigh operations (failed to verify neighbor)"

WARNING: line length of 142 exceeds 80 columns
#312: FILE: tools/net/ynl/tests/test_ynl_cli.sh:201:
+		--json "{\"ndm-ifindex\": $ifindex, \"dst\": \"192.0.2.1\", \"lladdr\": \"11:22:33:44:55:66\", \"ndm-family\": 2}" &>/dev/null

WARNING: line length of 90 exceeds 80 columns
#320: FILE: tools/net/ynl/tests/test_ynl_cli.sh:209:
+		ktap_test_skip "YNL CLI rt-rule operations (rt-rule family not available)"

WARNING: line length of 115 exceeds 80 columns
#326: FILE: tools/net/ynl/tests/test_ynl_cli.sh:215:
+		--json "{\"family\": 2, \"src-len\": 24, \"src\": \"192.0.2.0\", \"table\": 100}" &>/dev/null; then

WARNING: line length of 95 exceeds 80 columns
#332: FILE: tools/net/ynl/tests/test_ynl_cli.sh:221:
+	rule_output=$(ip netns exec "$testns" $ynl --family rt-rule --dump getrule 2>/dev/null)

WARNING: line length of 83 exceeds 80 columns
#336: FILE: tools/net/ynl/tests/test_ynl_cli.sh:225:
+		ktap_test_fail "YNL CLI rt-rule operations (failed to verify rule)"

WARNING: line length of 109 exceeds 80 columns
#340: FILE: tools/net/ynl/tests/test_ynl_cli.sh:229:
+		--json "{\"family\": 2, \"src-len\": 24, \"src\": \"192.0.2.0\", \"table\": 100}" &>/dev/null

WARNING: line length of 88 exceeds 80 columns
#350: FILE: tools/net/ynl/tests/test_ynl_cli.sh:239:
+		--do getfamily --json "{\"family-name\": \"netdev\"}" 2>/dev/null); then

WARNING: line length of 92 exceeds 80 columns
#351: FILE: tools/net/ynl/tests/test_ynl_cli.sh:240:
+		ktap_test_fail "YNL CLI nlctrl getfamily (failed to get nlctrl family info)"

WARNING: line length of 103 exceeds 80 columns
#356: FILE: tools/net/ynl/tests/test_ynl_cli.sh:245:
+		ktap_test_fail "YNL CLI nlctrl getfamily (nlctrl getfamily output missing family-name)"

WARNING: line length of 101 exceeds 80 columns
#361: FILE: tools/net/ynl/tests/test_ynl_cli.sh:250:
+		ktap_test_fail "YNL CLI nlctrl getfamily (nlctrl getfamily output missing family-id)"

WARNING: line length of 106 exceeds 80 columns
#382: FILE: tools/net/ynl/tests/test_ynl_cli.sh:271:
+	echo "$NSIM_ID 1" | ip netns exec "$testns" tee /sys/bus/netdevsim/new_device >/dev/null 2>&1 || {

WARNING: line length of 112 exceeds 80 columns
#388: FILE: tools/net/ynl/tests/test_ynl_cli.sh:277:
+	dev=$(ip netns exec "$testns" ls /sys/bus/netdevsim/devices/netdevsim$NSIM_ID/net 2>/dev/null | head -1)

WARNING: line length of 86 exceeds 80 columns
#394: FILE: tools/net/ynl/tests/test_ynl_cli.sh:283:
+	ip -netns "$testns" link set dev "$dev" name "$NSIM_DEV_NAME" 2>/dev/null || {

WARNING: line length of 95 exceeds 80 columns
#401: FILE: tools/net/ynl/tests/test_ynl_cli.sh:290:
+	if ! ip -n "$testns" link add "$VETH_A" type veth peer name "$VETH_B" 2>/dev/null; then

WARNING: line length of 107 exceeds 80 columns
#412: FILE: tools/net/ynl/tests/test_ynl_cli.sh:301:
+	ip netns exec "$testns" bash -c "echo $NSIM_ID > /sys/bus/netdevsim/del_device" 2>/dev/null || true

WARNING: line length of 107 exceeds 80 columns
#450: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:6:
+KSELFTEST_KTAP_HELPERS="$(dirname "$(realpath "$0")")/../../../testing/selftests/kselftest/ktap_helpers.sh"

WARNING: line length of 82 exceeds 80 columns
#454: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:10:
+# Default ynl-ethtool path for direct execution, can be overridden by make install

WARNING: line length of 81 exceeds 80 columns
#470: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:26:
+	info_output=$(ip netns exec "$testns" $ynl_ethtool "$VETH_A" 2>/dev/null)

WARNING: line length of 102 exceeds 80 columns
#473: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:29:
+		ktap_test_fail "YNL ethtool device info (device info output missing expected content)"

WARNING: line length of 102 exceeds 80 columns
#485: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:41:
+	stats_output=$(ip netns exec "$testns" $ynl_ethtool --statistics "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 85 exceeds 80 columns
#487: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:43:
+	if ! echo "$stats_output" | grep -q -E "(NIC statistics|packets|bytes)"; then

WARNING: line length of 100 exceeds 80 columns
#488: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:44:
+		ktap_test_fail "YNL ethtool statistics (statistics output missing expected content)"

WARNING: line length of 100 exceeds 80 columns
#500: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:56:
+	ring_output=$(ip netns exec "$testns" $ynl_ethtool --show-ring "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 110 exceeds 80 columns
#503: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:59:
+		ktap_test_fail "YNL ethtool ring parameters (ring parameters output missing expected content)"

WARNING: line length of 101 exceeds 80 columns
#507: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:63:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-ring "$NSIM_DEV_NAME" rx 64 2>/dev/null; then

WARNING: line length of 99 exceeds 80 columns
#508: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:64:
+		ktap_test_fail "YNL ethtool ring parameters (set-ring command failed unexpectedly)"

WARNING: line length of 100 exceeds 80 columns
#518: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:74:
+	if ! ip netns exec "$testns" $ynl_ethtool --show-coalesce "$NSIM_DEV_NAME" &>/dev/null; then

WARNING: line length of 100 exceeds 80 columns
#519: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:75:
+		ktap_test_fail "YNL ethtool coalesce parameters (failed to get coalesce parameters)"

WARNING: line length of 111 exceeds 80 columns
#523: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:79:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-coalesce "$NSIM_DEV_NAME" rx-usecs 50 2>/dev/null; then

WARNING: line length of 107 exceeds 80 columns
#524: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:80:
+		ktap_test_fail "YNL ethtool coalesce parameters (set-coalesce command failed unexpectedly)"

WARNING: line length of 97 exceeds 80 columns
#534: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:90:
+	if ! ip netns exec "$testns" $ynl_ethtool --show-pause "$NSIM_DEV_NAME" &>/dev/null; then

WARNING: line length of 94 exceeds 80 columns
#535: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:91:
+		ktap_test_fail "YNL ethtool pause parameters (failed to get pause parameters)"

WARNING: line length of 106 exceeds 80 columns
#539: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:95:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-pause "$NSIM_DEV_NAME" tx 1 rx 1 2>/dev/null; then

WARNING: line length of 101 exceeds 80 columns
#540: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:96:
+		ktap_test_fail "YNL ethtool pause parameters (set-pause command failed unexpectedly)"

WARNING: line length of 108 exceeds 80 columns
#552: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:108:
+	features_output=$(ip netns exec "$testns" $ynl_ethtool --show-features "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 101 exceeds 80 columns
#555: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:111:
+		ktap_test_fail "YNL ethtool features info (features output missing expected content)"

WARNING: line length of 108 exceeds 80 columns
#567: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:123:
+	channels_output=$(ip netns exec "$testns" $ynl_ethtool --show-channels "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 82 exceeds 80 columns
#569: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:125:
+	if ! echo "$channels_output" | grep -q -E "(Channel|Combined|RX|TX)"; then

WARNING: line length of 101 exceeds 80 columns
#570: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:126:
+		ktap_test_fail "YNL ethtool channels info (channels output missing expected content)"

WARNING: line length of 116 exceeds 80 columns
#574: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:130:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-channels "$NSIM_DEV_NAME" combined-count 1 2>/dev/null; then

WARNING: line length of 101 exceeds 80 columns
#575: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:131:
+		ktap_test_fail "YNL ethtool channels info (set-channels command failed unexpectedly)"

WARNING: line length of 107 exceeds 80 columns
#587: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:143:
+	ts_output=$(ip netns exec "$testns" $ynl_ethtool --show-time-stamping "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 97 exceeds 80 columns
#589: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:145:
+	if ! echo "$ts_output" | grep -q -E "(Time stamping|timestamping|SOF_TIMESTAMPING)"; then

WARNING: line length of 106 exceeds 80 columns
#590: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:146:
+		ktap_test_fail "YNL ethtool time stamping (time stamping output missing expected content)"

WARNING: line length of 106 exceeds 80 columns
#611: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:167:
+	echo "$NSIM_ID 1" | ip netns exec "$testns" tee /sys/bus/netdevsim/new_device >/dev/null 2>&1 || {

WARNING: line length of 112 exceeds 80 columns
#617: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:173:
+	dev=$(ip netns exec "$testns" ls /sys/bus/netdevsim/devices/netdevsim$NSIM_ID/net 2>/dev/null | head -1)

WARNING: line length of 86 exceeds 80 columns
#623: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:179:
+	ip -netns "$testns" link set dev "$dev" name "$NSIM_DEV_NAME" 2>/dev/null || {

WARNING: line length of 95 exceeds 80 columns
#630: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:186:
+	if ! ip -n "$testns" link add "$VETH_A" type veth peer name "$VETH_B" 2>/dev/null; then

WARNING: line length of 107 exceeds 80 columns
#641: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:197:
+	ip netns exec "$testns" bash -c "echo $NSIM_ID > /sys/bus/netdevsim/del_device" 2>/dev/null || true

total: 0 errors, 87 warnings, 0 checks, 605 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 49f92c3cfe87 ("tools: ynl: add YNL test framework") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 87 warnings, 0 checks, 605 lines checked