========== checkpatch - FAILED WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #81: FILE: tools/testing/selftests/bpf/progs/arena_list.c:33: +const volatile bool nonsleepable = false; CHECK: No space is necessary after a cast #89: FILE: tools/testing/selftests/bpf/progs/arena_list.c:46: +void bpf_rcu_read_lock(void) __ksym; CHECK: No space is necessary after a cast #90: FILE: tools/testing/selftests/bpf/progs/arena_list.c:47: +void bpf_rcu_read_unlock(void) __ksym; CHECK: spaces preferred around that '*' (ctx:WxV) #129: FILE: tools/testing/selftests/bpf/progs/verifier_arena.c:29: + volatile int __arena *page1, *page2, *no_page; ^ WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #129: FILE: tools/testing/selftests/bpf/progs/verifier_arena.c:29: + volatile int __arena *page1, *page2, *no_page; WARNING: line length of 96 exceeds 80 columns #149: FILE: tools/testing/selftests/bpf/progs/verifier_arena.c:49: + if (*page2 != 0 && *page2 != 2) /* use-after-free should return 0 or the stored value */ CHECK: spaces preferred around that '*' (ctx:WxV) #167: FILE: tools/testing/selftests/bpf/progs/verifier_arena.c:99: + volatile char __arena *page1, *page2, *page3, *page4; ^ WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #167: FILE: tools/testing/selftests/bpf/progs/verifier_arena.c:99: + volatile char __arena *page1, *page2, *page3, *page4; WARNING: Missing a blank line after declarations #212: FILE: tools/testing/selftests/bpf/progs/verifier_arena.c:179: + struct bpf_arena___l *ar = (struct bpf_arena___l *)&arena; + volatile char __arena *pages; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #212: FILE: tools/testing/selftests/bpf/progs/verifier_arena.c:179: + volatile char __arena *pages; WARNING: line length of 92 exceeds 80 columns #214: FILE: tools/testing/selftests/bpf/progs/verifier_arena.c:181: + pages = bpf_arena_alloc_pages(&ar->map, NULL, ar->map.max_entries, NUMA_NO_NODE, 0); WARNING: line length of 81 exceeds 80 columns #251: FILE: tools/testing/selftests/bpf/progs/verifier_arena.c:224: + /* Try to implicitly allocate the page (since there's only 2 of them). */ WARNING: line length of 96 exceeds 80 columns #371: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:282: + /* Allocate 2051 pages (more than 1024) at once to test the limit of kmalloc_nolock() */ ERROR: code indent should use tabs where possible #377: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:288: +^I^I pages[i * PAGE_SIZE] = 123;$ ERROR: code indent should use tabs where possible #379: FILE: tools/testing/selftests/bpf/progs/verifier_arena_large.c:290: +^I^I if (pages[i * PAGE_SIZE] != 123)$ total: 2 errors, 9 warnings, 4 checks, 330 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit a2549ed1d779 ("selftests: bpf: test non-sleepable arena allocations") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.