WARNING: line length of 107 exceeds 80 columns
#117: FILE: tools/net/ynl/tests/test_ynl_cli.sh:6:
+KSELFTEST_KTAP_HELPERS="$(dirname "$(realpath "$0")")/../../../testing/selftests/kselftest/ktap_helpers.sh"

WARNING: line length of 98 exceeds 80 columns
#145: FILE: tools/net/ynl/tests/test_ynl_cli.sh:34:
+	ifindex=$(ip netns exec "$testns" cat /sys/class/net/"$NSIM_DEV_NAME"/ifindex 2>/dev/null)

WARNING: line length of 98 exceeds 80 columns
#151: FILE: tools/net/ynl/tests/test_ynl_cli.sh:40:
+		ktap_test_fail "YNL CLI netdev operations (netdev dev-get output missing ifindex)"

WARNING: line length of 83 exceeds 80 columns
#156: FILE: tools/net/ynl/tests/test_ynl_cli.sh:45:
+		--dump queue-get --json "{\"ifindex\": $ifindex}" &>/dev/null; then

WARNING: line length of 92 exceeds 80 columns
#157: FILE: tools/net/ynl/tests/test_ynl_cli.sh:46:
+		ktap_test_fail "YNL CLI netdev operations (failed to get netdev queue info)"

WARNING: line length of 101 exceeds 80 columns
#170: FILE: tools/net/ynl/tests/test_ynl_cli.sh:59:
+		--do rings-get --json "{\"header\": {\"dev-name\": \"$NSIM_DEV_NAME\"}}" 2>/dev/null)

WARNING: line length of 101 exceeds 80 columns
#173: FILE: tools/net/ynl/tests/test_ynl_cli.sh:62:
+		ktap_test_fail "YNL CLI ethtool operations (ethtool rings-get output missing header)"

WARNING: line length of 97 exceeds 80 columns
#178: FILE: tools/net/ynl/tests/test_ynl_cli.sh:67:
+		--do linkinfo-get --json "{\"header\": {\"dev-name\": \"$VETH_A\"}}" 2>/dev/null)

WARNING: line length of 104 exceeds 80 columns
#181: FILE: tools/net/ynl/tests/test_ynl_cli.sh:70:
+		ktap_test_fail "YNL CLI ethtool operations (ethtool linkinfo-get output missing header)"

WARNING: line length of 92 exceeds 80 columns
#193: FILE: tools/net/ynl/tests/test_ynl_cli.sh:82:
+		ktap_test_skip "YNL CLI rt-route operations (rt-route family not available)"

WARNING: line length of 98 exceeds 80 columns
#197: FILE: tools/net/ynl/tests/test_ynl_cli.sh:86:
+	ifindex=$(ip netns exec "$testns" cat /sys/class/net/"$NSIM_DEV_NAME"/ifindex 2>/dev/null)

WARNING: line length of 84 exceeds 80 columns
#200: FILE: tools/net/ynl/tests/test_ynl_cli.sh:89:
+	if ! ip netns exec "$testns" $ynl --family rt-route --do newroute --create \

WARNING: line length of 204 exceeds 80 columns
#201: FILE: tools/net/ynl/tests/test_ynl_cli.sh:90:
+		--json "{\"dst\": \"192.0.2.0\", \"oif\": $ifindex, \"rtm-dst-len\": 24, \"rtm-family\": 2, \"rtm-scope\": 253, \"rtm-type\": 1, \"rtm-protocol\": 3, \"rtm-table\": 254}" &>/dev/null; then

WARNING: line length of 82 exceeds 80 columns
#202: FILE: tools/net/ynl/tests/test_ynl_cli.sh:91:
+		ktap_test_fail "YNL CLI rt-route operations (failed to add route)"

WARNING: line length of 98 exceeds 80 columns
#207: FILE: tools/net/ynl/tests/test_ynl_cli.sh:96:
+	route_output=$(ip netns exec "$testns" $ynl --family rt-route --dump getroute 2>/dev/null)

WARNING: line length of 85 exceeds 80 columns
#211: FILE: tools/net/ynl/tests/test_ynl_cli.sh:100:
+		ktap_test_fail "YNL CLI rt-route operations (failed to verify route)"

WARNING: line length of 198 exceeds 80 columns
#215: FILE: tools/net/ynl/tests/test_ynl_cli.sh:104:
+		--json "{\"dst\": \"192.0.2.0\", \"oif\": $ifindex, \"rtm-dst-len\": 24, \"rtm-family\": 2, \"rtm-scope\": 253, \"rtm-type\": 1, \"rtm-protocol\": 3, \"rtm-table\": 254}" &>/dev/null

WARNING: line length of 90 exceeds 80 columns
#223: FILE: tools/net/ynl/tests/test_ynl_cli.sh:112:
+		ktap_test_skip "YNL CLI rt-addr operations (rt-addr family not available)"

WARNING: line length of 98 exceeds 80 columns
#227: FILE: tools/net/ynl/tests/test_ynl_cli.sh:116:
+	ifindex=$(ip netns exec "$testns" cat /sys/class/net/"$NSIM_DEV_NAME"/ifindex 2>/dev/null)

WARNING: line length of 138 exceeds 80 columns
#230: FILE: tools/net/ynl/tests/test_ynl_cli.sh:119:
+		--json "{\"ifa-index\": $ifindex, \"local\": \"192.0.2.100\", \"ifa-prefixlen\": 24, \"ifa-family\": 2}" &>/dev/null; then

WARNING: line length of 83 exceeds 80 columns
#231: FILE: tools/net/ynl/tests/test_ynl_cli.sh:120:
+		ktap_test_fail "YNL CLI rt-addr operations (failed to add address)"

WARNING: line length of 95 exceeds 80 columns
#236: FILE: tools/net/ynl/tests/test_ynl_cli.sh:125:
+	addr_output=$(ip netns exec "$testns" $ynl --family rt-addr --dump getaddr 2>/dev/null)

WARNING: line length of 86 exceeds 80 columns
#240: FILE: tools/net/ynl/tests/test_ynl_cli.sh:129:
+		ktap_test_fail "YNL CLI rt-addr operations (failed to verify address)"

WARNING: line length of 132 exceeds 80 columns
#244: FILE: tools/net/ynl/tests/test_ynl_cli.sh:133:
+		--json "{\"ifa-index\": $ifindex, \"local\": \"192.0.2.100\", \"ifa-prefixlen\": 24, \"ifa-family\": 2}" &>/dev/null

WARNING: line length of 90 exceeds 80 columns
#250: FILE: tools/net/ynl/tests/test_ynl_cli.sh:139:
+		ktap_test_skip "YNL CLI rt-link operations (rt-link family not available)"

WARNING: line length of 82 exceeds 80 columns
#254: FILE: tools/net/ynl/tests/test_ynl_cli.sh:143:
+	if ! ip netns exec "$testns" $ynl --family rt-link --do newlink --create \

WARNING: line length of 104 exceeds 80 columns
#255: FILE: tools/net/ynl/tests/test_ynl_cli.sh:144:
+		--json "{\"ifname\": \"dummy0\", \"linkinfo\": {\"kind\": \"dummy\"}}" &>/dev/null; then

WARNING: line length of 95 exceeds 80 columns
#261: FILE: tools/net/ynl/tests/test_ynl_cli.sh:150:
+	link_output=$(ip netns exec "$testns" $ynl --family rt-link --dump getlink 2>/dev/null)

WARNING: line length of 105 exceeds 80 columns
#262: FILE: tools/net/ynl/tests/test_ynl_cli.sh:151:
+	if echo "$link_output" | grep -q "$NSIM_DEV_NAME" && echo "$link_output" | grep -q "dummy0"; then

WARNING: line length of 83 exceeds 80 columns
#265: FILE: tools/net/ynl/tests/test_ynl_cli.sh:154:
+		ktap_test_fail "YNL CLI rt-link operations (failed to verify link)"

WARNING: line length of 92 exceeds 80 columns
#277: FILE: tools/net/ynl/tests/test_ynl_cli.sh:166:
+		ktap_test_skip "YNL CLI rt-neigh operations (rt-neigh family not available)"

WARNING: line length of 98 exceeds 80 columns
#281: FILE: tools/net/ynl/tests/test_ynl_cli.sh:170:
+	ifindex=$(ip netns exec "$testns" cat /sys/class/net/"$NSIM_DEV_NAME"/ifindex 2>/dev/null)

WARNING: line length of 81 exceeds 80 columns
#283: FILE: tools/net/ynl/tests/test_ynl_cli.sh:172:
+	# Add neighbor: 192.0.2.1 dev nsim1338 lladdr 11:22:33:44:55:66 PERMANENT

WARNING: line length of 84 exceeds 80 columns
#284: FILE: tools/net/ynl/tests/test_ynl_cli.sh:173:
+	if ! ip netns exec "$testns" $ynl --family rt-neigh --do newneigh --create \

WARNING: line length of 168 exceeds 80 columns
#285: FILE: tools/net/ynl/tests/test_ynl_cli.sh:174:
+		--json "{\"ndm-ifindex\": $ifindex, \"dst\": \"192.0.2.1\", \"lladdr\": \"11:22:33:44:55:66\", \"ndm-family\": 2, \"ndm-state\": 128}" &>/dev/null; then

WARNING: line length of 85 exceeds 80 columns
#286: FILE: tools/net/ynl/tests/test_ynl_cli.sh:175:
+		ktap_test_fail "YNL CLI rt-neigh operations (failed to add neighbor)"

WARNING: line length of 98 exceeds 80 columns
#290: FILE: tools/net/ynl/tests/test_ynl_cli.sh:179:
+	neigh_output=$(ip netns exec "$testns" $ynl --family rt-neigh --dump getneigh 2>/dev/null)

WARNING: line length of 88 exceeds 80 columns
#294: FILE: tools/net/ynl/tests/test_ynl_cli.sh:183:
+		ktap_test_fail "YNL CLI rt-neigh operations (failed to verify neighbor)"

WARNING: line length of 142 exceeds 80 columns
#298: FILE: tools/net/ynl/tests/test_ynl_cli.sh:187:
+		--json "{\"ndm-ifindex\": $ifindex, \"dst\": \"192.0.2.1\", \"lladdr\": \"11:22:33:44:55:66\", \"ndm-family\": 2}" &>/dev/null

WARNING: line length of 90 exceeds 80 columns
#304: FILE: tools/net/ynl/tests/test_ynl_cli.sh:193:
+		ktap_test_skip "YNL CLI rt-rule operations (rt-rule family not available)"

WARNING: line length of 115 exceeds 80 columns
#310: FILE: tools/net/ynl/tests/test_ynl_cli.sh:199:
+		--json "{\"family\": 2, \"src-len\": 24, \"src\": \"192.0.2.0\", \"table\": 100}" &>/dev/null; then

WARNING: line length of 95 exceeds 80 columns
#316: FILE: tools/net/ynl/tests/test_ynl_cli.sh:205:
+	rule_output=$(ip netns exec "$testns" $ynl --family rt-rule --dump getrule 2>/dev/null)

WARNING: line length of 83 exceeds 80 columns
#320: FILE: tools/net/ynl/tests/test_ynl_cli.sh:209:
+		ktap_test_fail "YNL CLI rt-rule operations (failed to verify rule)"

WARNING: line length of 109 exceeds 80 columns
#324: FILE: tools/net/ynl/tests/test_ynl_cli.sh:213:
+		--json "{\"family\": 2, \"src-len\": 24, \"src\": \"192.0.2.0\", \"table\": 100}" &>/dev/null

WARNING: line length of 88 exceeds 80 columns
#332: FILE: tools/net/ynl/tests/test_ynl_cli.sh:221:
+		--do getfamily --json "{\"family-name\": \"netdev\"}" 2>/dev/null); then

WARNING: line length of 92 exceeds 80 columns
#333: FILE: tools/net/ynl/tests/test_ynl_cli.sh:222:
+		ktap_test_fail "YNL CLI nlctrl getfamily (failed to get nlctrl family info)"

WARNING: line length of 103 exceeds 80 columns
#338: FILE: tools/net/ynl/tests/test_ynl_cli.sh:227:
+		ktap_test_fail "YNL CLI nlctrl getfamily (nlctrl getfamily output missing family-name)"

WARNING: line length of 101 exceeds 80 columns
#343: FILE: tools/net/ynl/tests/test_ynl_cli.sh:232:
+		ktap_test_fail "YNL CLI nlctrl getfamily (nlctrl getfamily output missing family-id)"

WARNING: line length of 106 exceeds 80 columns
#362: FILE: tools/net/ynl/tests/test_ynl_cli.sh:251:
+	echo "$NSIM_ID 1" | ip netns exec "$testns" tee /sys/bus/netdevsim/new_device >/dev/null 2>&1 || {

WARNING: line length of 112 exceeds 80 columns
#368: FILE: tools/net/ynl/tests/test_ynl_cli.sh:257:
+	dev=$(ip netns exec "$testns" ls /sys/bus/netdevsim/devices/netdevsim$NSIM_ID/net 2>/dev/null | head -1)

WARNING: line length of 86 exceeds 80 columns
#374: FILE: tools/net/ynl/tests/test_ynl_cli.sh:263:
+	ip -netns "$testns" link set dev "$dev" name "$NSIM_DEV_NAME" 2>/dev/null || {

WARNING: line length of 95 exceeds 80 columns
#381: FILE: tools/net/ynl/tests/test_ynl_cli.sh:270:
+	if ! ip -n "$testns" link add "$VETH_A" type veth peer name "$VETH_B" 2>/dev/null; then

WARNING: line length of 115 exceeds 80 columns
#392: FILE: tools/net/ynl/tests/test_ynl_cli.sh:281:
+		ip netns exec "$testns" bash -c "echo $NSIM_ID > /sys/bus/netdevsim/del_device" 2>/dev/null || true

WARNING: line length of 107 exceeds 80 columns
#432: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:6:
+KSELFTEST_KTAP_HELPERS="$(dirname "$(realpath "$0")")/../../../testing/selftests/kselftest/ktap_helpers.sh"

WARNING: line length of 82 exceeds 80 columns
#436: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:10:
+# Default ynl-ethtool path for direct execution, can be overridden by make install

WARNING: line length of 81 exceeds 80 columns
#450: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:24:
+	info_output=$(ip netns exec "$testns" $ynl_ethtool "$VETH_A" 2>/dev/null)

WARNING: line length of 102 exceeds 80 columns
#453: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:27:
+		ktap_test_fail "YNL ethtool device info (device info output missing expected content)"

WARNING: line length of 102 exceeds 80 columns
#463: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:37:
+	stats_output=$(ip netns exec "$testns" $ynl_ethtool --statistics "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 85 exceeds 80 columns
#465: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:39:
+	if ! echo "$stats_output" | grep -q -E "(NIC statistics|packets|bytes)"; then

WARNING: line length of 100 exceeds 80 columns
#466: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:40:
+		ktap_test_fail "YNL ethtool statistics (statistics output missing expected content)"

WARNING: line length of 100 exceeds 80 columns
#476: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:50:
+	ring_output=$(ip netns exec "$testns" $ynl_ethtool --show-ring "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 110 exceeds 80 columns
#479: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:53:
+		ktap_test_fail "YNL ethtool ring parameters (ring parameters output missing expected content)"

WARNING: line length of 101 exceeds 80 columns
#483: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:57:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-ring "$NSIM_DEV_NAME" rx 64 2>/dev/null; then

WARNING: line length of 99 exceeds 80 columns
#484: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:58:
+		ktap_test_fail "YNL ethtool ring parameters (set-ring command failed unexpectedly)"

WARNING: line length of 100 exceeds 80 columns
#492: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:66:
+	if ! ip netns exec "$testns" $ynl_ethtool --show-coalesce "$NSIM_DEV_NAME" &>/dev/null; then

WARNING: line length of 100 exceeds 80 columns
#493: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:67:
+		ktap_test_fail "YNL ethtool coalesce parameters (failed to get coalesce parameters)"

WARNING: line length of 111 exceeds 80 columns
#497: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:71:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-coalesce "$NSIM_DEV_NAME" rx-usecs 50 2>/dev/null; then

WARNING: line length of 107 exceeds 80 columns
#498: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:72:
+		ktap_test_fail "YNL ethtool coalesce parameters (set-coalesce command failed unexpectedly)"

WARNING: line length of 97 exceeds 80 columns
#506: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:80:
+	if ! ip netns exec "$testns" $ynl_ethtool --show-pause "$NSIM_DEV_NAME" &>/dev/null; then

WARNING: line length of 94 exceeds 80 columns
#507: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:81:
+		ktap_test_fail "YNL ethtool pause parameters (failed to get pause parameters)"

WARNING: line length of 106 exceeds 80 columns
#511: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:85:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-pause "$NSIM_DEV_NAME" tx 1 rx 1 2>/dev/null; then

WARNING: line length of 101 exceeds 80 columns
#512: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:86:
+		ktap_test_fail "YNL ethtool pause parameters (set-pause command failed unexpectedly)"

WARNING: line length of 108 exceeds 80 columns
#522: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:96:
+	features_output=$(ip netns exec "$testns" $ynl_ethtool --show-features "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 101 exceeds 80 columns
#525: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:99:
+		ktap_test_fail "YNL ethtool features info (features output missing expected content)"

WARNING: line length of 108 exceeds 80 columns
#535: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:109:
+	channels_output=$(ip netns exec "$testns" $ynl_ethtool --show-channels "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 82 exceeds 80 columns
#537: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:111:
+	if ! echo "$channels_output" | grep -q -E "(Channel|Combined|RX|TX)"; then

WARNING: line length of 101 exceeds 80 columns
#538: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:112:
+		ktap_test_fail "YNL ethtool channels info (channels output missing expected content)"

WARNING: line length of 116 exceeds 80 columns
#542: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:116:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-channels "$NSIM_DEV_NAME" combined-count 1 2>/dev/null; then

WARNING: line length of 101 exceeds 80 columns
#543: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:117:
+		ktap_test_fail "YNL ethtool channels info (set-channels command failed unexpectedly)"

WARNING: line length of 107 exceeds 80 columns
#553: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:127:
+	ts_output=$(ip netns exec "$testns" $ynl_ethtool --show-time-stamping "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 97 exceeds 80 columns
#555: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:129:
+	if ! echo "$ts_output" | grep -q -E "(Time stamping|timestamping|SOF_TIMESTAMPING)"; then

WARNING: line length of 106 exceeds 80 columns
#556: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:130:
+		ktap_test_fail "YNL ethtool time stamping (time stamping output missing expected content)"

WARNING: line length of 106 exceeds 80 columns
#575: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:149:
+	echo "$NSIM_ID 1" | ip netns exec "$testns" tee /sys/bus/netdevsim/new_device >/dev/null 2>&1 || {

WARNING: line length of 112 exceeds 80 columns
#581: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:155:
+	dev=$(ip netns exec "$testns" ls /sys/bus/netdevsim/devices/netdevsim$NSIM_ID/net 2>/dev/null | head -1)

WARNING: line length of 86 exceeds 80 columns
#587: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:161:
+	ip -netns "$testns" link set dev "$dev" name "$NSIM_DEV_NAME" 2>/dev/null || {

WARNING: line length of 95 exceeds 80 columns
#594: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:168:
+	if ! ip -n "$testns" link add "$VETH_A" type veth peer name "$VETH_B" 2>/dev/null; then

WARNING: line length of 115 exceeds 80 columns
#605: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:179:
+		ip netns exec "$testns" bash -c "echo $NSIM_ID > /sys/bus/netdevsim/del_device" 2>/dev/null || true

total: 0 errors, 87 warnings, 0 checks, 571 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 1a62510a33ae ("tools: ynl: add YNL test framework") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 87 warnings, 0 checks, 571 lines checked