CHECK: spaces preferred around that '+' (ctx:VxV) #33: FILE: drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:155: +#define GRF_BIT(nr) (BIT(nr) | BIT(nr+16)) ^ CHECK: spaces preferred around that '+' (ctx:VxV) #34: FILE: drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:156: +#define GRF_CLR_BIT(nr) (BIT(nr+16)) ^ CHECK: Macro argument 'nr' may be better as '(nr)' to avoid precedence issues #34: FILE: drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:156: +#define GRF_CLR_BIT(nr) (BIT(nr+16)) total: 0 errors, 0 warnings, 3 checks, 150 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 2cae97557798 ("net: stmmac: rk: replace HIWORD_UPDATE() with GRF_FIELD()") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 3 checks, 150 lines checked