ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.IwdQIkiFjC and /tmp/tmp.9UiEwnYgUR Tree base: ff3ab0b05266 ("netconsole: Dynamic allocation of userdata buffer") Now at: 941dbd8c0433 ("netconsole: Increase MAX_USERDATA_ITEMS") ====== Checking before the patch ====== Checking tools/testing/selftests/drivers/net/netcons_overflow.sh - f029ced7d119490d40e61e7006a0e5293f123edac3b46f393c3236ffe6b66592 In netcons_overflow.sh line 60: set_network ^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1. In netcons_overflow.sh line 62: create_dynamic_target ^-------------------^ SC2119 (info): Use create_dynamic_target "$@" if function's $1 should mean script's $1. In netcons_overflow.sh line 67: exit "${ksft_pass}" ^----------^ SC2154 (warning): ksft_pass is referenced but not assigned. For more information: https://www.shellcheck.net/wiki/SC2154 -- ksft_pass is referenced but not a... https://www.shellcheck.net/wiki/SC2119 -- Use create_dynamic_target "$@" if... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/drivers/net/netcons_overflow.sh - f029ced7d119490d40e61e7006a0e5293f123edac3b46f393c3236ffe6b66592 In netcons_overflow.sh line 60: set_network ^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1. In netcons_overflow.sh line 62: create_dynamic_target ^-------------------^ SC2119 (info): Use create_dynamic_target "$@" if function's $1 should mean script's $1. In netcons_overflow.sh line 67: exit "${ksft_pass}" ^----------^ SC2154 (warning): ksft_pass is referenced but not assigned. For more information: https://www.shellcheck.net/wiki/SC2154 -- ksft_pass is referenced but not a... https://www.shellcheck.net/wiki/SC2119 -- Use create_dynamic_target "$@" if...