CHECK: spaces preferred around that '*' (ctx:WxV) #42: FILE: tools/testing/selftests/bpf/bpf_arena_strsearch.h:6: +__noinline int bpf_arena_strlen(const char __arena *s __arg_arena) ^ WARNING: line length of 100 exceeds 80 columns #79: FILE: tools/testing/selftests/bpf/bpf_arena_strsearch.h:43: +__noinline bool glob_match(char const __arena *pat __arg_arena, char const __arena *str __arg_arena) WARNING: line length of 90 exceeds 80 columns #186: FILE: tools/testing/selftests/bpf/prog_tests/arena_strsearch.c:16: + ret = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.arena_strsearch), &opts); WARNING: line length of 82 exceeds 80 columns #190: FILE: tools/testing/selftests/bpf/prog_tests/arena_strsearch.c:20: + printf("%s:SKIP:compiler doesn't support arena_cast\n", __func__); WARNING: line length of 81 exceeds 80 columns #225: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:19: +static bool test(char const __arena *pat, char const __arena *str, bool expected) WARNING: Consecutive strings are generally better as a single string #250: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:44: + "1" "a\0" "a\0" WARNING: Consecutive strings are generally better as a single string #251: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:45: + "0" "a\0" "b\0" WARNING: Consecutive strings are generally better as a single string #252: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:46: + "0" "a\0" "aa\0" WARNING: Consecutive strings are generally better as a single string #253: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:47: + "0" "a\0" "\0" WARNING: Consecutive strings are generally better as a single string #254: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:48: + "1" "\0" "\0" WARNING: Consecutive strings are generally better as a single string #255: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:49: + "0" "\0" "a\0" WARNING: Consecutive strings are generally better as a single string #257: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:51: + "1" "[a]\0" "a\0" WARNING: Consecutive strings are generally better as a single string #258: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:52: + "0" "[a]\0" "b\0" WARNING: Consecutive strings are generally better as a single string #259: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:53: + "0" "[!a]\0" "a\0" WARNING: Consecutive strings are generally better as a single string #260: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:54: + "1" "[!a]\0" "b\0" WARNING: Consecutive strings are generally better as a single string #261: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:55: + "1" "[ab]\0" "a\0" WARNING: Consecutive strings are generally better as a single string #262: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:56: + "1" "[ab]\0" "b\0" WARNING: Consecutive strings are generally better as a single string #263: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:57: + "0" "[ab]\0" "c\0" WARNING: Consecutive strings are generally better as a single string #264: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:58: + "1" "[!ab]\0" "c\0" WARNING: Consecutive strings are generally better as a single string #265: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:59: + "1" "[a-c]\0" "b\0" WARNING: Consecutive strings are generally better as a single string #266: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:60: + "0" "[a-c]\0" "d\0" WARNING: Consecutive strings are generally better as a single string #268: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:62: + "1" "[a-c-e-g]\0" "-\0" WARNING: Consecutive strings are generally better as a single string #269: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:63: + "0" "[a-c-e-g]\0" "d\0" WARNING: Consecutive strings are generally better as a single string #270: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:64: + "1" "[a-c-e-g]\0" "f\0" WARNING: Consecutive strings are generally better as a single string #271: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:65: + "1" "[]a-ceg-ik[]\0" "a\0" WARNING: Consecutive strings are generally better as a single string #272: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:66: + "1" "[]a-ceg-ik[]\0" "]\0" WARNING: Consecutive strings are generally better as a single string #273: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:67: + "1" "[]a-ceg-ik[]\0" "[\0" WARNING: Consecutive strings are generally better as a single string #274: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:68: + "1" "[]a-ceg-ik[]\0" "h\0" WARNING: Consecutive strings are generally better as a single string #275: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:69: + "0" "[]a-ceg-ik[]\0" "f\0" WARNING: Consecutive strings are generally better as a single string #276: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:70: + "0" "[!]a-ceg-ik[]\0" "h\0" WARNING: Consecutive strings are generally better as a single string #277: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:71: + "0" "[!]a-ceg-ik[]\0" "]\0" WARNING: Consecutive strings are generally better as a single string #278: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:72: + "1" "[!]a-ceg-ik[]\0" "f\0" WARNING: Consecutive strings are generally better as a single string #280: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:74: + "1" "?\0" "a\0" WARNING: Consecutive strings are generally better as a single string #281: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:75: + "0" "?\0" "aa\0" WARNING: Consecutive strings are generally better as a single string #282: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:76: + "0" "??\0" "a\0" WARNING: Consecutive strings are generally better as a single string #283: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:77: + "1" "?x?\0" "axb\0" WARNING: Consecutive strings are generally better as a single string #284: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:78: + "0" "?x?\0" "abx\0" WARNING: Consecutive strings are generally better as a single string #285: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:79: + "0" "?x?\0" "xab\0" WARNING: Consecutive strings are generally better as a single string #287: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:81: + "0" "*??\0" "a\0" WARNING: Consecutive strings are generally better as a single string #288: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:82: + "1" "*??\0" "ab\0" WARNING: Consecutive strings are generally better as a single string #289: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:83: + "1" "*??\0" "abc\0" WARNING: Consecutive strings are generally better as a single string #290: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:84: + "1" "*??\0" "abcd\0" WARNING: Consecutive strings are generally better as a single string #291: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:85: + "0" "??*\0" "a\0" WARNING: Consecutive strings are generally better as a single string #292: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:86: + "1" "??*\0" "ab\0" WARNING: Consecutive strings are generally better as a single string #293: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:87: + "1" "??*\0" "abc\0" WARNING: Consecutive strings are generally better as a single string #294: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:88: + "1" "??*\0" "abcd\0" WARNING: Consecutive strings are generally better as a single string #295: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:89: + "0" "?*?\0" "a\0" WARNING: Consecutive strings are generally better as a single string #296: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:90: + "1" "?*?\0" "ab\0" WARNING: Consecutive strings are generally better as a single string #297: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:91: + "1" "?*?\0" "abc\0" WARNING: Consecutive strings are generally better as a single string #298: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:92: + "1" "?*?\0" "abcd\0" WARNING: Consecutive strings are generally better as a single string #299: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:93: + "1" "*b\0" "b\0" WARNING: Consecutive strings are generally better as a single string #300: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:94: + "1" "*b\0" "ab\0" WARNING: Consecutive strings are generally better as a single string #301: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:95: + "0" "*b\0" "ba\0" WARNING: Consecutive strings are generally better as a single string #302: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:96: + "1" "*b\0" "bb\0" WARNING: Consecutive strings are generally better as a single string #303: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:97: + "1" "*b\0" "abb\0" WARNING: Consecutive strings are generally better as a single string #304: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:98: + "1" "*b\0" "bab\0" WARNING: Consecutive strings are generally better as a single string #305: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:99: + "1" "*bc\0" "abbc\0" WARNING: Consecutive strings are generally better as a single string #306: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:100: + "1" "*bc\0" "bc\0" WARNING: Consecutive strings are generally better as a single string #307: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:101: + "1" "*bc\0" "bbc\0" WARNING: Consecutive strings are generally better as a single string #308: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:102: + "1" "*bc\0" "bcbc\0" WARNING: Consecutive strings are generally better as a single string #310: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:104: + "1" "*ac*\0" "abacadaeafag\0" WARNING: Consecutive strings are generally better as a single string #311: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:105: + "1" "*ac*ae*ag*\0" "abacadaeafag\0" WARNING: Consecutive strings are generally better as a single string #312: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:106: + "1" "*a*b*[bc]*[ef]*g*\0" "abacadaeafag\0" WARNING: Consecutive strings are generally better as a single string #313: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:107: + "0" "*a*b*[ef]*[cd]*g*\0" "abacadaeafag\0" WARNING: Consecutive strings are generally better as a single string #314: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:108: + "1" "*abcd*\0" "abcabcabcabcdefg\0" WARNING: Consecutive strings are generally better as a single string #315: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:109: + "1" "*ab*cd*\0" "abcabcabcabcdefg\0" WARNING: Consecutive strings are generally better as a single string #316: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:110: + "1" "*abcd*abcdef*\0" "abcabcdabcdeabcdefg\0" WARNING: Consecutive strings are generally better as a single string #317: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:111: + "0" "*abcd*\0" "abcabcabcabcefg\0" WARNING: Consecutive strings are generally better as a single string #318: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:112: + "0" "*ab*cd*\0" "abcabcabcabcefg\0"; WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #325: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:119: + unsigned successes = 0; WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #326: FILE: tools/testing/selftests/bpf/progs/arena_strsearch.c:120: + unsigned n = 0; total: 0 errors, 70 warnings, 1 checks, 304 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 1c3c8b3fb4e3 ("selftests/bpf: Convert glob_match() to bpf arena") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 70 warnings, 1 checks, 304 lines checked