====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/drivers/net/netcons_resume.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.ENlaWAKAsz 2025-11-09 03:57:34.517740398 -0800 +++ /tmp/tmp.4FOm6DTJe7 2025-11-09 03:57:35.476730741 -0800 @@ -10,0 +11,10 @@ + +In lib_netcons.sh line 71: + cleanup + ^-----^ SC2119 (info): Use cleanup "$@" if function's $1 should mean script's $1. + + +In lib_netcons.sh line 188: +function cleanup() { +^-- SC2120 (warning): cleanup references arguments, but none are ever passed. + @@ -11,0 +22 @@ + https://www.shellcheck.net/wiki/SC2120 -- cleanup references arguments, but... @@ -12,0 +24,19 @@ + https://www.shellcheck.net/wiki/SC2119 -- Use cleanup "$@" if function's $1... + +In netcons_resume.sh line 38: + set_network + ^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1. + + +In netcons_resume.sh line 65: + set_network + ^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1. + + +In netcons_resume.sh line 92: +exit "${ksft_pass}" + ^----------^ SC2154 (warning): ksft_pass is referenced but not assigned. + +For more information: + https://www.shellcheck.net/wiki/SC2154 -- ksft_pass is referenced but not a... + https://www.shellcheck.net/wiki/SC2119 -- Use set_network "$@" if function'...