ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.Nk7k0pwbuI and /tmp/tmp.jiVE0gRI8m Tree base: 3534e03e0ec2 ("selftests/vsock: avoid false-positives when checking dmesg") Now at: 28b1ffa2f4fb ("selftests: net: local_termination: Wait for interfaces to come up") ====== Checking before the patch ====== Checking tools/testing/selftests/net/forwarding/local_termination.sh - 9a30f8fe4ebaa65fc1269e6079d935de7fdce6d9f74162cd28279bcdd4813559 In local_termination.sh line 114: local smac=$(mac_get $if_name) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local smac=$(mac_get "$if_name") In local_termination.sh line 118: $MZ -q $if_name "$pkt" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ -q "$if_name" "$pkt" In local_termination.sh line 126: ip neigh add $H2_IPV4 lladdr $dmac dev $if_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh add "$H2_IPV4" lladdr "$dmac" dev "$if_name" In local_termination.sh line 127: ping_do $if_name $H2_IPV4 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_do "$if_name" "$H2_IPV4" In local_termination.sh line 128: ip neigh del $H2_IPV4 dev $if_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh del "$H2_IPV4" dev "$if_name" In local_termination.sh line 140: [ $should_receive = true ] && should_fail=0 || should_fail=1 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$should_receive" = true ] && should_fail=0 || should_fail=1 In local_termination.sh line 143: tcpdump_show $if_name | grep -q "$pattern" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_show "$if_name" | grep -q "$pattern" In local_termination.sh line 153: local vrf_name=$(master_name_get $if_name) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vrf_name=$(master_name_get "$if_name") In local_termination.sh line 155: ip route add 225.100.1.0/24 dev $if_name vrf $vrf_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route add 225.100.1.0/24 dev "$if_name" vrf "$vrf_name" In local_termination.sh line 156: ip -6 route add ff2e::/64 dev $if_name vrf $vrf_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -6 route add ff2e::/64 dev "$if_name" vrf "$vrf_name" In local_termination.sh line 162: local vrf_name=$(master_name_get $if_name) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vrf_name=$(master_name_get "$if_name") In local_termination.sh line 164: ip route del 225.100.1.0/24 dev $if_name vrf $vrf_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route del 225.100.1.0/24 dev "$if_name" vrf "$vrf_name" In local_termination.sh line 165: ip -6 route del ff2e::/64 dev $if_name vrf $vrf_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -6 route del ff2e::/64 dev "$if_name" vrf "$vrf_name" In local_termination.sh line 175: local smac=$(mac_get $send_if_name) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local smac=$(mac_get "$send_if_name") In local_termination.sh line 176: local rcv_dmac=$(mac_get $rcv_if_name) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local rcv_dmac=$(mac_get "$rcv_if_name") In local_termination.sh line 179: tcpdump_start $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_start "$rcv_if_name" In local_termination.sh line 181: mc_route_prepare $send_if_name ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_route_prepare "$send_if_name" In local_termination.sh line 182: mc_route_prepare $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_route_prepare "$rcv_if_name" In local_termination.sh line 184: send_uc_ipv4 $send_if_name $rcv_dmac ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_uc_ipv4 "$send_if_name" "$rcv_dmac" In local_termination.sh line 185: send_uc_ipv4 $send_if_name $MACVLAN_ADDR ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_uc_ipv4 "$send_if_name" "$MACVLAN_ADDR" In local_termination.sh line 186: send_uc_ipv4 $send_if_name $UNKNOWN_UC_ADDR1 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_uc_ipv4 "$send_if_name" "$UNKNOWN_UC_ADDR1" In local_termination.sh line 188: ip link set dev $rcv_if_name promisc on ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rcv_if_name" promisc on In local_termination.sh line 189: send_uc_ipv4 $send_if_name $UNKNOWN_UC_ADDR2 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_uc_ipv4 "$send_if_name" "$UNKNOWN_UC_ADDR2" In local_termination.sh line 190: mc_send $send_if_name $UNKNOWN_IPV4_MC_ADDR2 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV4_MC_ADDR2" In local_termination.sh line 191: mc_send $send_if_name $UNKNOWN_IPV6_MC_ADDR2 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV6_MC_ADDR2" In local_termination.sh line 192: ip link set dev $rcv_if_name promisc off ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rcv_if_name" promisc off In local_termination.sh line 194: mc_join $rcv_if_name $JOINED_IPV4_MC_ADDR ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" "$JOINED_IPV4_MC_ADDR" In local_termination.sh line 195: mc_send $send_if_name $JOINED_IPV4_MC_ADDR ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$JOINED_IPV4_MC_ADDR" In local_termination.sh line 198: mc_join $rcv_if_name $JOINED_IPV6_MC_ADDR ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" "$JOINED_IPV6_MC_ADDR" In local_termination.sh line 199: mc_send $send_if_name $JOINED_IPV6_MC_ADDR ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$JOINED_IPV6_MC_ADDR" In local_termination.sh line 202: mc_send $send_if_name $UNKNOWN_IPV4_MC_ADDR1 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV4_MC_ADDR1" In local_termination.sh line 203: mc_send $send_if_name $UNKNOWN_IPV6_MC_ADDR1 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV6_MC_ADDR1" In local_termination.sh line 205: ip link set dev $rcv_if_name allmulticast on ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rcv_if_name" allmulticast on In local_termination.sh line 206: send_uc_ipv4 $send_if_name $UNKNOWN_UC_ADDR3 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_uc_ipv4 "$send_if_name" "$UNKNOWN_UC_ADDR3" In local_termination.sh line 207: mc_send $send_if_name $UNKNOWN_IPV4_MC_ADDR3 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV4_MC_ADDR3" In local_termination.sh line 208: mc_send $send_if_name $UNKNOWN_IPV6_MC_ADDR3 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV6_MC_ADDR3" In local_termination.sh line 209: ip link set dev $rcv_if_name allmulticast off ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rcv_if_name" allmulticast off In local_termination.sh line 211: mc_route_destroy $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_route_destroy "$rcv_if_name" In local_termination.sh line 212: mc_route_destroy $send_if_name ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_route_destroy "$send_if_name" In local_termination.sh line 214: if [ $skip_ptp = false ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$skip_ptp" = false ]; then In local_termination.sh line 215: ip maddress add 01:1b:19:00:00:00 dev $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip maddress add 01:1b:19:00:00:00 dev "$rcv_if_name" In local_termination.sh line 216: send_raw $send_if_name "$PTP_1588_L2_SYNC" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_L2_SYNC" In local_termination.sh line 217: send_raw $send_if_name "$PTP_1588_L2_FOLLOW_UP" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_L2_FOLLOW_UP" In local_termination.sh line 218: ip maddress del 01:1b:19:00:00:00 dev $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip maddress del 01:1b:19:00:00:00 dev "$rcv_if_name" In local_termination.sh line 220: ip maddress add 01:80:c2:00:00:0e dev $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip maddress add 01:80:c2:00:00:0e dev "$rcv_if_name" In local_termination.sh line 221: send_raw $send_if_name "$PTP_1588_L2_PDELAY_REQ" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_L2_PDELAY_REQ" In local_termination.sh line 222: ip maddress del 01:80:c2:00:00:0e dev $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip maddress del 01:80:c2:00:00:0e dev "$rcv_if_name" In local_termination.sh line 224: mc_join $rcv_if_name 224.0.1.129 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" 224.0.1.129 In local_termination.sh line 225: send_raw $send_if_name "$PTP_1588_IPV4_SYNC" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV4_SYNC" In local_termination.sh line 226: send_raw $send_if_name "$PTP_1588_IPV4_FOLLOW_UP" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV4_FOLLOW_UP" In local_termination.sh line 229: mc_join $rcv_if_name 224.0.0.107 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" 224.0.0.107 In local_termination.sh line 230: send_raw $send_if_name "$PTP_1588_IPV4_PDELAY_REQ" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV4_PDELAY_REQ" In local_termination.sh line 233: mc_join $rcv_if_name ff0e::181 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" ff0e::181 In local_termination.sh line 234: send_raw $send_if_name "$PTP_1588_IPV6_SYNC" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV6_SYNC" In local_termination.sh line 235: send_raw $send_if_name "$PTP_1588_IPV6_FOLLOW_UP" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV6_FOLLOW_UP" In local_termination.sh line 238: mc_join $rcv_if_name ff02::6b ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" ff02::6b In local_termination.sh line 239: send_raw $send_if_name "$PTP_1588_IPV6_PDELAY_REQ" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV6_PDELAY_REQ" In local_termination.sh line 245: tcpdump_stop $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_stop "$rcv_if_name" In local_termination.sh line 247: check_rcv $rcv_if_name "Unicast IPv4 to primary MAC address" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Unicast IPv4 to primary MAC address" \ In local_termination.sh line 251: check_rcv $rcv_if_name "Unicast IPv4 to macvlan MAC address" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Unicast IPv4 to macvlan MAC address" \ In local_termination.sh line 255: [ $no_unicast_flt = true ] && should_receive=true || should_receive=false ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$no_unicast_flt" = true ] && should_receive=true || should_receive=false In local_termination.sh line 256: check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Unicast IPv4 to unknown MAC address" \ In local_termination.sh line 258: $should_receive "$test_name" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$should_receive" "$test_name" In local_termination.sh line 260: check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address, promisc" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Unicast IPv4 to unknown MAC address, promisc" \ In local_termination.sh line 264: [ $no_unicast_flt = true ] && should_receive=true || should_receive=false ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$no_unicast_flt" = true ] && should_receive=true || should_receive=false In local_termination.sh line 265: check_rcv $rcv_if_name \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" \ In local_termination.sh line 268: $should_receive "$test_name" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$should_receive" "$test_name" In local_termination.sh line 270: check_rcv $rcv_if_name "Multicast IPv4 to joined group" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv4 to joined group" \ In local_termination.sh line 275: check_rcv $rcv_if_name \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" \ In local_termination.sh line 280: check_rcv $rcv_if_name "Multicast IPv4 to unknown group, promisc" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv4 to unknown group, promisc" \ In local_termination.sh line 284: check_rcv $rcv_if_name "Multicast IPv4 to unknown group, allmulti" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv4 to unknown group, allmulti" \ In local_termination.sh line 288: check_rcv $rcv_if_name "Multicast IPv6 to joined group" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv6 to joined group" \ In local_termination.sh line 293: check_rcv $rcv_if_name "Multicast IPv6 to unknown group" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv6 to unknown group" \ In local_termination.sh line 297: check_rcv $rcv_if_name "Multicast IPv6 to unknown group, promisc" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv6 to unknown group, promisc" \ In local_termination.sh line 301: check_rcv $rcv_if_name "Multicast IPv6 to unknown group, allmulti" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv6 to unknown group, allmulti" \ In local_termination.sh line 305: if [ $skip_ptp = false ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$skip_ptp" = false ]; then In local_termination.sh line 306: check_rcv $rcv_if_name "1588v2 over L2 transport, Sync" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over L2 transport, Sync" \ In local_termination.sh line 310: check_rcv $rcv_if_name "1588v2 over L2 transport, Follow-Up" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over L2 transport, Follow-Up" \ In local_termination.sh line 314: check_rcv $rcv_if_name "1588v2 over L2 transport, Peer Delay Request" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over L2 transport, Peer Delay Request" \ In local_termination.sh line 318: check_rcv $rcv_if_name "1588v2 over IPv4, Sync" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv4, Sync" \ In local_termination.sh line 322: check_rcv $rcv_if_name "1588v2 over IPv4, Follow-Up" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv4, Follow-Up" \ In local_termination.sh line 326: check_rcv $rcv_if_name "1588v2 over IPv4, Peer Delay Request" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv4, Peer Delay Request" \ In local_termination.sh line 330: check_rcv $rcv_if_name "1588v2 over IPv6, Sync" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv6, Sync" \ In local_termination.sh line 334: check_rcv $rcv_if_name "1588v2 over IPv6, Follow-Up" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv6, Follow-Up" \ In local_termination.sh line 338: check_rcv $rcv_if_name "1588v2 over IPv6, Peer Delay Request" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv6, Peer Delay Request" \ In local_termination.sh line 343: tcpdump_cleanup $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_cleanup "$rcv_if_name" In local_termination.sh line 348: simple_if_init $h1 $H1_IPV4/24 $H1_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" "$H1_IPV4"/24 "$H1_IPV6"/64 In local_termination.sh line 353: simple_if_fini $h1 $H1_IPV4/24 $H1_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" "$H1_IPV4"/24 "$H1_IPV6"/64 In local_termination.sh line 358: simple_if_init $h2 $H2_IPV4/24 $H2_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 363: simple_if_fini $h2 $H2_IPV4/24 $H2_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 368: simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" In local_termination.sh line 369: vlan_create $h1 100 v$h1 $H1_IPV4/24 $H1_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h1" 100 v"$h1" "$H1_IPV4"/24 "$H1_IPV6"/64 In local_termination.sh line 374: vlan_destroy $h1 100 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_destroy "$h1" 100 In local_termination.sh line 375: simple_if_fini $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" In local_termination.sh line 380: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In local_termination.sh line 381: vlan_create $h2 100 v$h2 $H2_IPV4/24 $H2_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 100 v"$h2" "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 386: vlan_destroy $h2 100 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_destroy "$h2" 100 In local_termination.sh line 387: simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" In local_termination.sh line 394: ip link add br0 type bridge vlan_filtering $vlan_filtering ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add br0 type bridge vlan_filtering "$vlan_filtering" In local_termination.sh line 395: ip link set br0 address $BRIDGE_ADDR ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set br0 address "$BRIDGE_ADDR" In local_termination.sh line 398: ip link set $h2 master br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h2" master br0 In local_termination.sh line 399: ip link set $h2 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h2" up In local_termination.sh line 411: ip link add link $lower name macvlan0 type macvlan mode private ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add link "$lower" name macvlan0 type macvlan mode private In local_termination.sh line 412: ip link set macvlan0 address $MACVLAN_ADDR ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set macvlan0 address "$MACVLAN_ADDR" In local_termination.sh line 426: if [ $(has_unicast_flt $h2) = yes ]; then ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ $(has_unicast_flt "$h2") = yes ]; then In local_termination.sh line 432: macvlan_create $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: macvlan_create "$h2" In local_termination.sh line 434: run_test $h1 $h2 $skip_ptp $no_unicast_flt "$h2" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_test "$h1" "$h2" "$skip_ptp" "$no_unicast_flt" "$h2" In local_termination.sh line 448: bridge_create $vlan_filtering ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge_create "$vlan_filtering" In local_termination.sh line 449: simple_if_init br0 $H2_IPV4/24 $H2_IPV6/64 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init br0 "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 452: run_test $h1 br0 $skip_ptp $no_unicast_flt \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_test "$h1" br0 "$skip_ptp" "$no_unicast_flt" \ In local_termination.sh line 456: simple_if_fini br0 $H2_IPV4/24 $H2_IPV6/64 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini br0 "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 476: if [ $(has_unicast_flt $h2) = yes ]; then ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ $(has_unicast_flt "$h2") = yes ]; then In local_termination.sh line 482: macvlan_create $h2.100 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: macvlan_create "$h2".100 In local_termination.sh line 484: run_test $h1.100 $h2.100 $skip_ptp $no_unicast_flt "VLAN upper" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_test "$h1".100 "$h2".100 "$skip_ptp" "$no_unicast_flt" "VLAN upper" In local_termination.sh line 500: if [ $(has_unicast_flt $h2) = yes ] && [ $vlan_filtering = 1 ]; then ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ $(has_unicast_flt "$h2") = yes ] && [ "$vlan_filtering" = 1 ]; then In local_termination.sh line 506: bridge_create $vlan_filtering ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge_create "$vlan_filtering" In local_termination.sh line 507: macvlan_create $h2.100 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: macvlan_create "$h2".100 In local_termination.sh line 509: run_test $h1.100 $h2.100 $skip_ptp $no_unicast_flt \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_test "$h1".100 "$h2".100 "$skip_ptp" "$no_unicast_flt" \ In local_termination.sh line 535: bridge_create $vlan_filtering ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge_create "$vlan_filtering" In local_termination.sh line 537: vlan_create br0 100 vbr0 $H2_IPV4/24 $H2_IPV6/64 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create br0 100 vbr0 "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 540: if [ $vlan_filtering = 1 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$vlan_filtering" = 1 ]; then In local_termination.sh line 541: bridge vlan add dev $h2 vid 100 master ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge vlan add dev "$h2" vid 100 master In local_termination.sh line 545: run_test $h1.100 br0.100 $skip_ptp $no_unicast_flt \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_test "$h1".100 br0.100 "$skip_ptp" "$no_unicast_flt" \ In local_termination.sh line 548: if [ $vlan_filtering = 1 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$vlan_filtering" = 1 ]; then In local_termination.sh line 550: bridge vlan del dev $h2 vid 100 master ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge vlan del dev "$h2" vid 100 master In local_termination.sh line 574: ip link set $h2 down ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h2" down In local_termination.sh line 575: ip link set $h1 down ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h1" down In local_termination.sh line 584: ip link set $h1 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h1" up In local_termination.sh line 585: ip link set $h2 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h2" up In local_termination.sh line 595: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/forwarding/local_termination.sh - 9a30f8fe4ebaa65fc1269e6079d935de7fdce6d9f74162cd28279bcdd4813559 In local_termination.sh line 114: local smac=$(mac_get $if_name) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local smac=$(mac_get "$if_name") In local_termination.sh line 118: $MZ -q $if_name "$pkt" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ -q "$if_name" "$pkt" In local_termination.sh line 126: ip neigh add $H2_IPV4 lladdr $dmac dev $if_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh add "$H2_IPV4" lladdr "$dmac" dev "$if_name" In local_termination.sh line 127: ping_do $if_name $H2_IPV4 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_do "$if_name" "$H2_IPV4" In local_termination.sh line 128: ip neigh del $H2_IPV4 dev $if_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh del "$H2_IPV4" dev "$if_name" In local_termination.sh line 140: [ $should_receive = true ] && should_fail=0 || should_fail=1 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$should_receive" = true ] && should_fail=0 || should_fail=1 In local_termination.sh line 143: tcpdump_show $if_name | grep -q "$pattern" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_show "$if_name" | grep -q "$pattern" In local_termination.sh line 153: local vrf_name=$(master_name_get $if_name) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vrf_name=$(master_name_get "$if_name") In local_termination.sh line 155: ip route add 225.100.1.0/24 dev $if_name vrf $vrf_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route add 225.100.1.0/24 dev "$if_name" vrf "$vrf_name" In local_termination.sh line 156: ip -6 route add ff2e::/64 dev $if_name vrf $vrf_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -6 route add ff2e::/64 dev "$if_name" vrf "$vrf_name" In local_termination.sh line 162: local vrf_name=$(master_name_get $if_name) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vrf_name=$(master_name_get "$if_name") In local_termination.sh line 164: ip route del 225.100.1.0/24 dev $if_name vrf $vrf_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route del 225.100.1.0/24 dev "$if_name" vrf "$vrf_name" In local_termination.sh line 165: ip -6 route del ff2e::/64 dev $if_name vrf $vrf_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -6 route del ff2e::/64 dev "$if_name" vrf "$vrf_name" In local_termination.sh line 175: local smac=$(mac_get $send_if_name) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local smac=$(mac_get "$send_if_name") In local_termination.sh line 176: local rcv_dmac=$(mac_get $rcv_if_name) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local rcv_dmac=$(mac_get "$rcv_if_name") In local_termination.sh line 181: tcpdump_start $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_start "$rcv_if_name" In local_termination.sh line 183: mc_route_prepare $send_if_name ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_route_prepare "$send_if_name" In local_termination.sh line 184: mc_route_prepare $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_route_prepare "$rcv_if_name" In local_termination.sh line 186: send_uc_ipv4 $send_if_name $rcv_dmac ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_uc_ipv4 "$send_if_name" "$rcv_dmac" In local_termination.sh line 187: send_uc_ipv4 $send_if_name $MACVLAN_ADDR ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_uc_ipv4 "$send_if_name" "$MACVLAN_ADDR" In local_termination.sh line 188: send_uc_ipv4 $send_if_name $UNKNOWN_UC_ADDR1 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_uc_ipv4 "$send_if_name" "$UNKNOWN_UC_ADDR1" In local_termination.sh line 190: ip link set dev $rcv_if_name promisc on ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rcv_if_name" promisc on In local_termination.sh line 191: send_uc_ipv4 $send_if_name $UNKNOWN_UC_ADDR2 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_uc_ipv4 "$send_if_name" "$UNKNOWN_UC_ADDR2" In local_termination.sh line 192: mc_send $send_if_name $UNKNOWN_IPV4_MC_ADDR2 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV4_MC_ADDR2" In local_termination.sh line 193: mc_send $send_if_name $UNKNOWN_IPV6_MC_ADDR2 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV6_MC_ADDR2" In local_termination.sh line 194: ip link set dev $rcv_if_name promisc off ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rcv_if_name" promisc off In local_termination.sh line 196: mc_join $rcv_if_name $JOINED_IPV4_MC_ADDR ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" "$JOINED_IPV4_MC_ADDR" In local_termination.sh line 197: mc_send $send_if_name $JOINED_IPV4_MC_ADDR ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$JOINED_IPV4_MC_ADDR" In local_termination.sh line 200: mc_join $rcv_if_name $JOINED_IPV6_MC_ADDR ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" "$JOINED_IPV6_MC_ADDR" In local_termination.sh line 201: mc_send $send_if_name $JOINED_IPV6_MC_ADDR ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$JOINED_IPV6_MC_ADDR" In local_termination.sh line 204: mc_send $send_if_name $UNKNOWN_IPV4_MC_ADDR1 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV4_MC_ADDR1" In local_termination.sh line 205: mc_send $send_if_name $UNKNOWN_IPV6_MC_ADDR1 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV6_MC_ADDR1" In local_termination.sh line 207: ip link set dev $rcv_if_name allmulticast on ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rcv_if_name" allmulticast on In local_termination.sh line 208: send_uc_ipv4 $send_if_name $UNKNOWN_UC_ADDR3 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_uc_ipv4 "$send_if_name" "$UNKNOWN_UC_ADDR3" In local_termination.sh line 209: mc_send $send_if_name $UNKNOWN_IPV4_MC_ADDR3 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV4_MC_ADDR3" In local_termination.sh line 210: mc_send $send_if_name $UNKNOWN_IPV6_MC_ADDR3 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_send "$send_if_name" "$UNKNOWN_IPV6_MC_ADDR3" In local_termination.sh line 211: ip link set dev $rcv_if_name allmulticast off ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rcv_if_name" allmulticast off In local_termination.sh line 213: mc_route_destroy $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_route_destroy "$rcv_if_name" In local_termination.sh line 214: mc_route_destroy $send_if_name ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_route_destroy "$send_if_name" In local_termination.sh line 216: if [ $skip_ptp = false ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$skip_ptp" = false ]; then In local_termination.sh line 217: ip maddress add 01:1b:19:00:00:00 dev $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip maddress add 01:1b:19:00:00:00 dev "$rcv_if_name" In local_termination.sh line 218: send_raw $send_if_name "$PTP_1588_L2_SYNC" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_L2_SYNC" In local_termination.sh line 219: send_raw $send_if_name "$PTP_1588_L2_FOLLOW_UP" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_L2_FOLLOW_UP" In local_termination.sh line 220: ip maddress del 01:1b:19:00:00:00 dev $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip maddress del 01:1b:19:00:00:00 dev "$rcv_if_name" In local_termination.sh line 222: ip maddress add 01:80:c2:00:00:0e dev $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip maddress add 01:80:c2:00:00:0e dev "$rcv_if_name" In local_termination.sh line 223: send_raw $send_if_name "$PTP_1588_L2_PDELAY_REQ" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_L2_PDELAY_REQ" In local_termination.sh line 224: ip maddress del 01:80:c2:00:00:0e dev $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip maddress del 01:80:c2:00:00:0e dev "$rcv_if_name" In local_termination.sh line 226: mc_join $rcv_if_name 224.0.1.129 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" 224.0.1.129 In local_termination.sh line 227: send_raw $send_if_name "$PTP_1588_IPV4_SYNC" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV4_SYNC" In local_termination.sh line 228: send_raw $send_if_name "$PTP_1588_IPV4_FOLLOW_UP" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV4_FOLLOW_UP" In local_termination.sh line 231: mc_join $rcv_if_name 224.0.0.107 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" 224.0.0.107 In local_termination.sh line 232: send_raw $send_if_name "$PTP_1588_IPV4_PDELAY_REQ" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV4_PDELAY_REQ" In local_termination.sh line 235: mc_join $rcv_if_name ff0e::181 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" ff0e::181 In local_termination.sh line 236: send_raw $send_if_name "$PTP_1588_IPV6_SYNC" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV6_SYNC" In local_termination.sh line 237: send_raw $send_if_name "$PTP_1588_IPV6_FOLLOW_UP" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV6_FOLLOW_UP" In local_termination.sh line 240: mc_join $rcv_if_name ff02::6b ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mc_join "$rcv_if_name" ff02::6b In local_termination.sh line 241: send_raw $send_if_name "$PTP_1588_IPV6_PDELAY_REQ" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_raw "$send_if_name" "$PTP_1588_IPV6_PDELAY_REQ" In local_termination.sh line 247: tcpdump_stop $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_stop "$rcv_if_name" In local_termination.sh line 249: check_rcv $rcv_if_name "Unicast IPv4 to primary MAC address" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Unicast IPv4 to primary MAC address" \ In local_termination.sh line 253: check_rcv $rcv_if_name "Unicast IPv4 to macvlan MAC address" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Unicast IPv4 to macvlan MAC address" \ In local_termination.sh line 257: [ $no_unicast_flt = true ] && should_receive=true || should_receive=false ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$no_unicast_flt" = true ] && should_receive=true || should_receive=false In local_termination.sh line 258: check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Unicast IPv4 to unknown MAC address" \ In local_termination.sh line 260: $should_receive "$test_name" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$should_receive" "$test_name" In local_termination.sh line 262: check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address, promisc" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Unicast IPv4 to unknown MAC address, promisc" \ In local_termination.sh line 266: [ $no_unicast_flt = true ] && should_receive=true || should_receive=false ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$no_unicast_flt" = true ] && should_receive=true || should_receive=false In local_termination.sh line 267: check_rcv $rcv_if_name \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" \ In local_termination.sh line 270: $should_receive "$test_name" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$should_receive" "$test_name" In local_termination.sh line 272: check_rcv $rcv_if_name "Multicast IPv4 to joined group" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv4 to joined group" \ In local_termination.sh line 277: check_rcv $rcv_if_name \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" \ In local_termination.sh line 282: check_rcv $rcv_if_name "Multicast IPv4 to unknown group, promisc" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv4 to unknown group, promisc" \ In local_termination.sh line 286: check_rcv $rcv_if_name "Multicast IPv4 to unknown group, allmulti" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv4 to unknown group, allmulti" \ In local_termination.sh line 290: check_rcv $rcv_if_name "Multicast IPv6 to joined group" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv6 to joined group" \ In local_termination.sh line 295: check_rcv $rcv_if_name "Multicast IPv6 to unknown group" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv6 to unknown group" \ In local_termination.sh line 299: check_rcv $rcv_if_name "Multicast IPv6 to unknown group, promisc" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv6 to unknown group, promisc" \ In local_termination.sh line 303: check_rcv $rcv_if_name "Multicast IPv6 to unknown group, allmulti" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "Multicast IPv6 to unknown group, allmulti" \ In local_termination.sh line 307: if [ $skip_ptp = false ]; then ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$skip_ptp" = false ]; then In local_termination.sh line 308: check_rcv $rcv_if_name "1588v2 over L2 transport, Sync" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over L2 transport, Sync" \ In local_termination.sh line 312: check_rcv $rcv_if_name "1588v2 over L2 transport, Follow-Up" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over L2 transport, Follow-Up" \ In local_termination.sh line 316: check_rcv $rcv_if_name "1588v2 over L2 transport, Peer Delay Request" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over L2 transport, Peer Delay Request" \ In local_termination.sh line 320: check_rcv $rcv_if_name "1588v2 over IPv4, Sync" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv4, Sync" \ In local_termination.sh line 324: check_rcv $rcv_if_name "1588v2 over IPv4, Follow-Up" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv4, Follow-Up" \ In local_termination.sh line 328: check_rcv $rcv_if_name "1588v2 over IPv4, Peer Delay Request" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv4, Peer Delay Request" \ In local_termination.sh line 332: check_rcv $rcv_if_name "1588v2 over IPv6, Sync" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv6, Sync" \ In local_termination.sh line 336: check_rcv $rcv_if_name "1588v2 over IPv6, Follow-Up" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv6, Follow-Up" \ In local_termination.sh line 340: check_rcv $rcv_if_name "1588v2 over IPv6, Peer Delay Request" \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_rcv "$rcv_if_name" "1588v2 over IPv6, Peer Delay Request" \ In local_termination.sh line 345: tcpdump_cleanup $rcv_if_name ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_cleanup "$rcv_if_name" In local_termination.sh line 350: simple_if_init $h1 $H1_IPV4/24 $H1_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" "$H1_IPV4"/24 "$H1_IPV6"/64 In local_termination.sh line 355: simple_if_fini $h1 $H1_IPV4/24 $H1_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" "$H1_IPV4"/24 "$H1_IPV6"/64 In local_termination.sh line 360: simple_if_init $h2 $H2_IPV4/24 $H2_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 365: simple_if_fini $h2 $H2_IPV4/24 $H2_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 370: simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" In local_termination.sh line 371: vlan_create $h1 100 v$h1 $H1_IPV4/24 $H1_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h1" 100 v"$h1" "$H1_IPV4"/24 "$H1_IPV6"/64 In local_termination.sh line 376: vlan_destroy $h1 100 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_destroy "$h1" 100 In local_termination.sh line 377: simple_if_fini $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" In local_termination.sh line 382: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In local_termination.sh line 383: vlan_create $h2 100 v$h2 $H2_IPV4/24 $H2_IPV6/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 100 v"$h2" "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 388: vlan_destroy $h2 100 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_destroy "$h2" 100 In local_termination.sh line 389: simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" In local_termination.sh line 396: ip link add br0 type bridge vlan_filtering $vlan_filtering ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add br0 type bridge vlan_filtering "$vlan_filtering" In local_termination.sh line 397: ip link set br0 address $BRIDGE_ADDR ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set br0 address "$BRIDGE_ADDR" In local_termination.sh line 400: ip link set $h2 master br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h2" master br0 In local_termination.sh line 401: ip link set $h2 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h2" up In local_termination.sh line 413: ip link add link $lower name macvlan0 type macvlan mode private ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add link "$lower" name macvlan0 type macvlan mode private In local_termination.sh line 414: ip link set macvlan0 address $MACVLAN_ADDR ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set macvlan0 address "$MACVLAN_ADDR" In local_termination.sh line 428: if [ $(has_unicast_flt $h2) = yes ]; then ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ $(has_unicast_flt "$h2") = yes ]; then In local_termination.sh line 434: macvlan_create $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: macvlan_create "$h2" In local_termination.sh line 436: run_test $h1 $h2 $skip_ptp $no_unicast_flt "$h2" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_test "$h1" "$h2" "$skip_ptp" "$no_unicast_flt" "$h2" In local_termination.sh line 450: bridge_create $vlan_filtering ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge_create "$vlan_filtering" In local_termination.sh line 451: simple_if_init br0 $H2_IPV4/24 $H2_IPV6/64 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init br0 "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 454: run_test $h1 br0 $skip_ptp $no_unicast_flt \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_test "$h1" br0 "$skip_ptp" "$no_unicast_flt" \ In local_termination.sh line 458: simple_if_fini br0 $H2_IPV4/24 $H2_IPV6/64 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini br0 "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 478: if [ $(has_unicast_flt $h2) = yes ]; then ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ $(has_unicast_flt "$h2") = yes ]; then In local_termination.sh line 484: macvlan_create $h2.100 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: macvlan_create "$h2".100 In local_termination.sh line 486: run_test $h1.100 $h2.100 $skip_ptp $no_unicast_flt "VLAN upper" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_test "$h1".100 "$h2".100 "$skip_ptp" "$no_unicast_flt" "VLAN upper" In local_termination.sh line 502: if [ $(has_unicast_flt $h2) = yes ] && [ $vlan_filtering = 1 ]; then ^--------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ $(has_unicast_flt "$h2") = yes ] && [ "$vlan_filtering" = 1 ]; then In local_termination.sh line 508: bridge_create $vlan_filtering ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge_create "$vlan_filtering" In local_termination.sh line 509: macvlan_create $h2.100 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: macvlan_create "$h2".100 In local_termination.sh line 511: run_test $h1.100 $h2.100 $skip_ptp $no_unicast_flt \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_test "$h1".100 "$h2".100 "$skip_ptp" "$no_unicast_flt" \ In local_termination.sh line 537: bridge_create $vlan_filtering ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge_create "$vlan_filtering" In local_termination.sh line 539: vlan_create br0 100 vbr0 $H2_IPV4/24 $H2_IPV6/64 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create br0 100 vbr0 "$H2_IPV4"/24 "$H2_IPV6"/64 In local_termination.sh line 542: if [ $vlan_filtering = 1 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$vlan_filtering" = 1 ]; then In local_termination.sh line 543: bridge vlan add dev $h2 vid 100 master ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge vlan add dev "$h2" vid 100 master In local_termination.sh line 547: run_test $h1.100 br0.100 $skip_ptp $no_unicast_flt \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_test "$h1".100 br0.100 "$skip_ptp" "$no_unicast_flt" \ In local_termination.sh line 550: if [ $vlan_filtering = 1 ]; then ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$vlan_filtering" = 1 ]; then In local_termination.sh line 552: bridge vlan del dev $h2 vid 100 master ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge vlan del dev "$h2" vid 100 master In local_termination.sh line 576: ip link set $h2 down ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h2" down In local_termination.sh line 577: ip link set $h1 down ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h1" down In local_termination.sh line 586: ip link set $h1 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h1" up In local_termination.sh line 587: ip link set $h2 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$h2" up In local_termination.sh line 597: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...