WARNING: 'actualy' may be misspelled - perhaps 'actually'? #6: We do not actualy test the bpf_override_return helper functionality ^^^^^^^ WARNING: line length of 100 exceeds 80 columns #65: FILE: tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c:576: + skel->links.test_override = bpf_program__attach_kprobe_multi_opts(skel->progs.test_override, CHECK: Alignment should match open parenthesis #66: FILE: tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c:577: + skel->links.test_override = bpf_program__attach_kprobe_multi_opts(skel->progs.test_override, + SYS_PREFIX "sys_prctl", NULL); WARNING: line length of 97 exceeds 80 columns #67: FILE: tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c:578: + if (!ASSERT_OK_PTR(skel->links.test_override, "bpf_program__attach_kprobe_multi_opts")) { WARNING: braces {} are not necessary for single statement blocks #67: FILE: tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c:578: + if (!ASSERT_OK_PTR(skel->links.test_override, "bpf_program__attach_kprobe_multi_opts")) { + goto cleanup; + } WARNING: line length of 103 exceeds 80 columns #78: FILE: tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c:589: + skel->links.test_kprobe_override = bpf_program__attach_kprobe(skel->progs.test_kprobe_override, WARNING: line length of 87 exceeds 80 columns #79: FILE: tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c:590: + false, SYS_PREFIX "sys_prctl"); CHECK: Alignment should match open parenthesis #79: FILE: tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c:590: + skel->links.test_kprobe_override = bpf_program__attach_kprobe(skel->progs.test_kprobe_override, + false, SYS_PREFIX "sys_prctl"); WARNING: line length of 93 exceeds 80 columns #80: FILE: tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c:591: + if (!ASSERT_OK_PTR(skel->links.test_kprobe_override, "bpf_program__attach_kprobe")) { WARNING: braces {} are not necessary for single statement blocks #80: FILE: tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c:591: + if (!ASSERT_OK_PTR(skel->links.test_kprobe_override, "bpf_program__attach_kprobe")) { + goto cleanup; + } total: 0 errors, 8 warnings, 2 checks, 101 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 00bf327b6970 ("selftests/bpf: Add test for bpf_override_return helper") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 8 warnings, 2 checks, 101 lines checked