WARNING: line length of 82 exceeds 80 columns #58: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:18: +static void __test_run(struct bpf_program *prog, void *ctx_in, size_t ctx_size_in) CHECK: Alignment should match open parenthesis #61: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:21: + LIBBPF_OPTS(bpf_test_run_opts, topts, + .ctx_in = ctx_in, WARNING: line length of 86 exceeds 80 columns #107: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:67: +/* validate that for two loads of the same jump table libbpf generates only one map */ WARNING: line length of 86 exceeds 80 columns #145: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:105: + if (!ASSERT_EQ(seen, false, "more than one INSN_ARRAY map")) { WARNING: line length of 91 exceeds 80 columns #174: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:134: + check_simple(skel, skel->progs.one_switch_non_zero_sec_off, in[i], out[i]); ERROR: space prohibited before that ',' (ctx:WxW) #200: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:160: + __u64 out[] = {12, 15, 7 , 15, 12, 15, 15}; ^ WARNING: line length of 81 exceeds 80 columns #204: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:164: + check_simple(skel, skel->progs.one_jump_two_maps, in[i], out[i]); WARNING: line length of 82 exceeds 80 columns #214: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:174: + check_simple(skel, skel->progs.use_static_global1, in[i], out[i]); WARNING: line length of 82 exceeds 80 columns #216: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:176: + check_simple(skel, skel->progs.use_static_global2, in[i], out[i]); WARNING: line length of 85 exceeds 80 columns #226: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:186: + check_simple(skel, skel->progs.use_nonstatic_global1, in[i], out[i]); WARNING: line length of 85 exceeds 80 columns #229: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:189: + check_simple(skel, skel->progs.use_nonstatic_global2, in[i], out[i]); WARNING: line length of 92 exceeds 80 columns #244: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:204: + check_simple_fentry(skel, skel->progs.simple_test_other_sec, in[i], out[i]); WARNING: line length of 98 exceeds 80 columns #261: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:221: + check_simple_fentry(skel, skel->progs.use_static_global_other_sec, in[i], out[i]); WARNING: line length of 101 exceeds 80 columns #278: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:238: + check_simple_fentry(skel, skel->progs.use_nonstatic_global_other_sec, in[i], out[i]); WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #547: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:209: +int big_jump_table(struct simple_ctx *ctx __attribute__((unused))) WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #586: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:248: +int one_jump_two_maps(struct simple_ctx *ctx __attribute__((unused))) WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #593: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:255: + volatile int ret = 0; WARNING: labels should not be indented #603: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:265: + l1: ret += 1; WARNING: labels should not be indented #604: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:266: + l2: ret += 3; WARNING: labels should not be indented #605: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:267: + l3: ret += 5; WARNING: labels should not be indented #606: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:268: + l4: ret += 7; WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #613: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:275: +int one_map_two_jumps(struct simple_ctx *ctx __attribute__((unused))) WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #619: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:281: + volatile int ret = 0; WARNING: labels should not be indented #627: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:289: + l1: ret += 3; WARNING: labels should not be indented #628: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:290: + l2: ret += 5; WARNING: labels should not be indented #629: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:291: + l3: ret += 7; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #636: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:298: +static __noinline int f0(volatile struct simple_ctx *ctx __arg_ctx) WARNING: Macros with flow control statements should be avoided #764: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:426: +#define SKIP_TEST(TEST_NAME) \ + SEC("syscall") int TEST_NAME(void *ctx) \ + { \ + return 0; \ + } total: 1 errors, 26 warnings, 1 checks, 750 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit b1f75daa72de ("selftests/bpf: add C-level selftests for indirect jumps") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.