WARNING: line length of 98 exceeds 80 columns
#128: FILE: tools/net/ynl/tests/test_ynl_cli.sh:29:
+	ifindex=$(ip netns exec "$testns" cat /sys/class/net/"$NSIM_DEV_NAME"/ifindex 2>/dev/null)

WARNING: line length of 94 exceeds 80 columns
#138: FILE: tools/net/ynl/tests/test_ynl_cli.sh:39:
+		echo "FAIL: YNL CLI netdev operations (netdev dev-get output missing ifindex)"

WARNING: line length of 83 exceeds 80 columns
#143: FILE: tools/net/ynl/tests/test_ynl_cli.sh:44:
+		--dump queue-get --json "{\"ifindex\": $ifindex}" &>/dev/null; then

WARNING: line length of 88 exceeds 80 columns
#144: FILE: tools/net/ynl/tests/test_ynl_cli.sh:45:
+		echo "FAIL: YNL CLI netdev operations (failed to get netdev queue info)"

WARNING: line length of 101 exceeds 80 columns
#157: FILE: tools/net/ynl/tests/test_ynl_cli.sh:58:
+		--do rings-get --json "{\"header\": {\"dev-name\": \"$NSIM_DEV_NAME\"}}" 2>/dev/null)

WARNING: line length of 97 exceeds 80 columns
#160: FILE: tools/net/ynl/tests/test_ynl_cli.sh:61:
+		echo "FAIL: YNL CLI ethtool operations (ethtool rings-get output missing header)"

WARNING: line length of 97 exceeds 80 columns
#165: FILE: tools/net/ynl/tests/test_ynl_cli.sh:66:
+		--do linkinfo-get --json "{\"header\": {\"dev-name\": \"$VETH_A\"}}" 2>/dev/null)

WARNING: line length of 100 exceeds 80 columns
#168: FILE: tools/net/ynl/tests/test_ynl_cli.sh:69:
+		echo "FAIL: YNL CLI ethtool operations (ethtool linkinfo-get output missing header)"

WARNING: line length of 81 exceeds 80 columns
#180: FILE: tools/net/ynl/tests/test_ynl_cli.sh:81:
+		echo "SKIP: YNL CLI rt-* operations (no rt-* families available)"

WARNING: line length of 98 exceeds 80 columns
#184: FILE: tools/net/ynl/tests/test_ynl_cli.sh:85:
+	ifindex=$(ip netns exec "$testns" cat /sys/class/net/"$NSIM_DEV_NAME"/ifindex 2>/dev/null)

WARNING: line length of 90 exceeds 80 columns
#194: FILE: tools/net/ynl/tests/test_ynl_cli.sh:95:
+		if ip netns exec "$testns" $ynl --family rt-route --do newroute --create \

WARNING: line length of 212 exceeds 80 columns
#195: FILE: tools/net/ynl/tests/test_ynl_cli.sh:96:
+			--json "{\"dst\": \"192.0.2.0\", \"oif\": $ifindex, \"rtm-dst-len\": 24, \"rtm-family\": 2, \"rtm-scope\": 253, \"rtm-type\": 1, \"rtm-protocol\": 3, \"rtm-table\": 254}" &>/dev/null; then

WARNING: line length of 114 exceeds 80 columns
#198: FILE: tools/net/ynl/tests/test_ynl_cli.sh:99:
+			route_output=$(ip netns exec "$testns" $ynl --family rt-route --dump getroute 2>/dev/null)

WARNING: line length of 97 exceeds 80 columns
#202: FILE: tools/net/ynl/tests/test_ynl_cli.sh:103:
+				echo "FAIL: YNL CLI rt-route operations (failed to verify route)"

WARNING: line length of 86 exceeds 80 columns
#205: FILE: tools/net/ynl/tests/test_ynl_cli.sh:106:
+			ip netns exec "$testns" $ynl --family rt-route --do delroute \

WARNING: line length of 214 exceeds 80 columns
#206: FILE: tools/net/ynl/tests/test_ynl_cli.sh:107:
+				--json "{\"dst\": \"192.0.2.0\", \"oif\": $ifindex, \"rtm-dst-len\": 24, \"rtm-family\": 2, \"rtm-scope\": 253, \"rtm-type\": 1, \"rtm-protocol\": 3, \"rtm-table\": 254}" &>/dev/null

WARNING: line length of 86 exceeds 80 columns
#208: FILE: tools/net/ynl/tests/test_ynl_cli.sh:109:
+			echo "FAIL: YNL CLI rt-route operations (failed to add route)"

WARNING: line length of 88 exceeds 80 columns
#211: FILE: tools/net/ynl/tests/test_ynl_cli.sh:112:
+		echo "SKIP: YNL CLI rt-route operations (rt-route family not available)"

WARNING: line length of 146 exceeds 80 columns
#217: FILE: tools/net/ynl/tests/test_ynl_cli.sh:118:
+			--json "{\"ifa-index\": $ifindex, \"local\": \"192.0.2.100\", \"ifa-prefixlen\": 24, \"ifa-family\": 2}" &>/dev/null; then

WARNING: line length of 111 exceeds 80 columns
#220: FILE: tools/net/ynl/tests/test_ynl_cli.sh:121:
+			addr_output=$(ip netns exec "$testns" $ynl --family rt-addr --dump getaddr 2>/dev/null)

WARNING: line length of 98 exceeds 80 columns
#224: FILE: tools/net/ynl/tests/test_ynl_cli.sh:125:
+				echo "FAIL: YNL CLI rt-addr operations (failed to verify address)"

WARNING: line length of 84 exceeds 80 columns
#227: FILE: tools/net/ynl/tests/test_ynl_cli.sh:128:
+			ip netns exec "$testns" $ynl --family rt-addr --do deladdr \

WARNING: line length of 148 exceeds 80 columns
#228: FILE: tools/net/ynl/tests/test_ynl_cli.sh:129:
+				--json "{\"ifa-index\": $ifindex, \"local\": \"192.0.2.100\", \"ifa-prefixlen\": 24, \"ifa-family\": 2}" &>/dev/null

WARNING: line length of 87 exceeds 80 columns
#230: FILE: tools/net/ynl/tests/test_ynl_cli.sh:131:
+			echo "FAIL: YNL CLI rt-addr operations (failed to add address)"

WARNING: line length of 86 exceeds 80 columns
#233: FILE: tools/net/ynl/tests/test_ynl_cli.sh:134:
+		echo "SKIP: YNL CLI rt-addr operations (rt-addr family not available)"

WARNING: line length of 88 exceeds 80 columns
#238: FILE: tools/net/ynl/tests/test_ynl_cli.sh:139:
+		if ip netns exec "$testns" $ynl --family rt-link --do newlink --create \

WARNING: line length of 112 exceeds 80 columns
#239: FILE: tools/net/ynl/tests/test_ynl_cli.sh:140:
+			--json "{\"ifname\": \"dummy0\", \"linkinfo\": {\"kind\": \"dummy\"}}" &>/dev/null; then

WARNING: line length of 111 exceeds 80 columns
#242: FILE: tools/net/ynl/tests/test_ynl_cli.sh:143:
+			link_output=$(ip netns exec "$testns" $ynl --family rt-link --dump getlink 2>/dev/null)

WARNING: line length of 121 exceeds 80 columns
#243: FILE: tools/net/ynl/tests/test_ynl_cli.sh:144:
+			if echo "$link_output" | grep -q "$NSIM_DEV_NAME" && echo "$link_output" | grep -q "dummy0"; then

WARNING: line length of 95 exceeds 80 columns
#246: FILE: tools/net/ynl/tests/test_ynl_cli.sh:147:
+				echo "FAIL: YNL CLI rt-link operations (failed to verify link)"

WARNING: line length of 84 exceeds 80 columns
#249: FILE: tools/net/ynl/tests/test_ynl_cli.sh:150:
+			ip netns exec "$testns" $ynl --family rt-link --do dellink \

WARNING: line length of 84 exceeds 80 columns
#252: FILE: tools/net/ynl/tests/test_ynl_cli.sh:153:
+			echo "FAIL: YNL CLI rt-link operations (failed to add link)"

WARNING: line length of 86 exceeds 80 columns
#255: FILE: tools/net/ynl/tests/test_ynl_cli.sh:156:
+		echo "SKIP: YNL CLI rt-link operations (rt-link family not available)"

WARNING: line length of 89 exceeds 80 columns
#260: FILE: tools/net/ynl/tests/test_ynl_cli.sh:161:
+		# Add neighbor: 192.0.2.1 dev nsim1338 lladdr 11:22:33:44:55:66 PERMANENT

WARNING: line length of 90 exceeds 80 columns
#261: FILE: tools/net/ynl/tests/test_ynl_cli.sh:162:
+		if ip netns exec "$testns" $ynl --family rt-neigh --do newneigh --create \

WARNING: line length of 176 exceeds 80 columns
#262: FILE: tools/net/ynl/tests/test_ynl_cli.sh:163:
+			--json "{\"ndm-ifindex\": $ifindex, \"dst\": \"192.0.2.1\", \"lladdr\": \"11:22:33:44:55:66\", \"ndm-family\": 2, \"ndm-state\": 128}" &>/dev/null; then

WARNING: line length of 114 exceeds 80 columns
#265: FILE: tools/net/ynl/tests/test_ynl_cli.sh:166:
+			neigh_output=$(ip netns exec "$testns" $ynl --family rt-neigh --dump getneigh 2>/dev/null)

WARNING: line length of 100 exceeds 80 columns
#269: FILE: tools/net/ynl/tests/test_ynl_cli.sh:170:
+				echo "FAIL: YNL CLI rt-neigh operations (failed to verify neighbor)"

WARNING: line length of 86 exceeds 80 columns
#272: FILE: tools/net/ynl/tests/test_ynl_cli.sh:173:
+			ip netns exec "$testns" $ynl --family rt-neigh --do delneigh \

WARNING: line length of 158 exceeds 80 columns
#273: FILE: tools/net/ynl/tests/test_ynl_cli.sh:174:
+				--json "{\"ndm-ifindex\": $ifindex, \"dst\": \"192.0.2.1\", \"lladdr\": \"11:22:33:44:55:66\", \"ndm-family\": 2}" &>/dev/null

WARNING: line length of 89 exceeds 80 columns
#275: FILE: tools/net/ynl/tests/test_ynl_cli.sh:176:
+			echo "FAIL: YNL CLI rt-neigh operations (failed to add neighbor)"

WARNING: line length of 88 exceeds 80 columns
#278: FILE: tools/net/ynl/tests/test_ynl_cli.sh:179:
+		echo "SKIP: YNL CLI rt-neigh operations (rt-neigh family not available)"

WARNING: line length of 123 exceeds 80 columns
#285: FILE: tools/net/ynl/tests/test_ynl_cli.sh:186:
+			--json "{\"family\": 2, \"src-len\": 24, \"src\": \"192.0.2.0\", \"table\": 100}" &>/dev/null; then

WARNING: line length of 111 exceeds 80 columns
#288: FILE: tools/net/ynl/tests/test_ynl_cli.sh:189:
+			rule_output=$(ip netns exec "$testns" $ynl --family rt-rule --dump getrule 2>/dev/null)

WARNING: line length of 95 exceeds 80 columns
#292: FILE: tools/net/ynl/tests/test_ynl_cli.sh:193:
+				echo "FAIL: YNL CLI rt-rule operations (failed to verify rule)"

WARNING: line length of 84 exceeds 80 columns
#295: FILE: tools/net/ynl/tests/test_ynl_cli.sh:196:
+			ip netns exec "$testns" $ynl --family rt-rule --do delrule \

WARNING: line length of 125 exceeds 80 columns
#296: FILE: tools/net/ynl/tests/test_ynl_cli.sh:197:
+				--json "{\"family\": 2, \"src-len\": 24, \"src\": \"192.0.2.0\", \"table\": 100}" &>/dev/null

WARNING: line length of 84 exceeds 80 columns
#298: FILE: tools/net/ynl/tests/test_ynl_cli.sh:199:
+			echo "FAIL: YNL CLI rt-rule operations (failed to add rule)"

WARNING: line length of 86 exceeds 80 columns
#301: FILE: tools/net/ynl/tests/test_ynl_cli.sh:202:
+		echo "SKIP: YNL CLI rt-rule operations (rt-rule family not available)"

WARNING: line length of 88 exceeds 80 columns
#311: FILE: tools/net/ynl/tests/test_ynl_cli.sh:212:
+		--do getfamily --json "{\"family-name\": \"netdev\"}" 2>/dev/null); then

WARNING: line length of 88 exceeds 80 columns
#312: FILE: tools/net/ynl/tests/test_ynl_cli.sh:213:
+		echo "FAIL: YNL CLI nlctrl getfamily (failed to get nlctrl family info)"

WARNING: line length of 99 exceeds 80 columns
#317: FILE: tools/net/ynl/tests/test_ynl_cli.sh:218:
+		echo "FAIL: YNL CLI nlctrl getfamily (nlctrl getfamily output missing family-name)"

WARNING: line length of 97 exceeds 80 columns
#322: FILE: tools/net/ynl/tests/test_ynl_cli.sh:223:
+		echo "FAIL: YNL CLI nlctrl getfamily (nlctrl getfamily output missing family-id)"

WARNING: line length of 106 exceeds 80 columns
#340: FILE: tools/net/ynl/tests/test_ynl_cli.sh:241:
+	echo "$NSIM_ID 1" | ip netns exec "$testns" tee /sys/bus/netdevsim/new_device >/dev/null 2>&1 || {

WARNING: line length of 82 exceeds 80 columns
#341: FILE: tools/net/ynl/tests/test_ynl_cli.sh:242:
+		echo "SKIP: all YNL CLI tests (failed to create netdevsim device)"

WARNING: line length of 112 exceeds 80 columns
#346: FILE: tools/net/ynl/tests/test_ynl_cli.sh:247:
+	dev=$(ip netns exec "$testns" ls /sys/bus/netdevsim/devices/netdevsim$NSIM_ID/net 2>/dev/null | head -1)

WARNING: line length of 86 exceeds 80 columns
#352: FILE: tools/net/ynl/tests/test_ynl_cli.sh:253:
+	ip -netns "$testns" link set dev "$dev" name "$NSIM_DEV_NAME" 2>/dev/null || {

WARNING: line length of 82 exceeds 80 columns
#353: FILE: tools/net/ynl/tests/test_ynl_cli.sh:254:
+		echo "SKIP: all YNL CLI tests (failed to rename netdevsim device)"

WARNING: line length of 95 exceeds 80 columns
#359: FILE: tools/net/ynl/tests/test_ynl_cli.sh:260:
+	if ! ip -n "$testns" link add "$VETH_A" type veth peer name "$VETH_B" 2>/dev/null; then

WARNING: line length of 115 exceeds 80 columns
#370: FILE: tools/net/ynl/tests/test_ynl_cli.sh:271:
+		ip netns exec "$testns" bash -c "echo $NSIM_ID > /sys/bus/netdevsim/del_device" 2>/dev/null || true

WARNING: line length of 82 exceeds 80 columns
#400: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:5:
+# Default ynl-ethtool path for direct execution, can be overridden by make install

WARNING: line length of 81 exceeds 80 columns
#414: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:19:
+	info_output=$(ip netns exec "$testns" $ynl_ethtool "$VETH_A" 2>/dev/null)

WARNING: line length of 98 exceeds 80 columns
#417: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:22:
+		echo "FAIL: YNL ethtool device info (device info output missing expected content)"

WARNING: line length of 102 exceeds 80 columns
#427: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:32:
+	stats_output=$(ip netns exec "$testns" $ynl_ethtool --statistics "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 85 exceeds 80 columns
#429: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:34:
+	if ! echo "$stats_output" | grep -q -E "(NIC statistics|packets|bytes)"; then

WARNING: line length of 96 exceeds 80 columns
#430: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:35:
+		echo "FAIL: YNL ethtool statistics (statistics output missing expected content)"

WARNING: line length of 100 exceeds 80 columns
#440: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:45:
+	ring_output=$(ip netns exec "$testns" $ynl_ethtool --show-ring "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 106 exceeds 80 columns
#443: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:48:
+		echo "FAIL: YNL ethtool ring parameters (ring parameters output missing expected content)"

WARNING: line length of 101 exceeds 80 columns
#447: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:52:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-ring "$NSIM_DEV_NAME" rx 64 2>/dev/null; then

WARNING: line length of 95 exceeds 80 columns
#448: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:53:
+		echo "FAIL: YNL ethtool ring parameters (set-ring command failed unexpectedly)"

WARNING: line length of 100 exceeds 80 columns
#456: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:61:
+	if ! ip netns exec "$testns" $ynl_ethtool --show-coalesce "$NSIM_DEV_NAME" &>/dev/null; then

WARNING: line length of 96 exceeds 80 columns
#457: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:62:
+		echo "FAIL: YNL ethtool coalesce parameters (failed to get coalesce parameters)"

WARNING: line length of 111 exceeds 80 columns
#461: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:66:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-coalesce "$NSIM_DEV_NAME" rx-usecs 50 2>/dev/null; then

WARNING: line length of 103 exceeds 80 columns
#462: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:67:
+		echo "FAIL: YNL ethtool coalesce parameters (set-coalesce command failed unexpectedly)"

WARNING: line length of 97 exceeds 80 columns
#470: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:75:
+	if ! ip netns exec "$testns" $ynl_ethtool --show-pause "$NSIM_DEV_NAME" &>/dev/null; then

WARNING: line length of 90 exceeds 80 columns
#471: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:76:
+		echo "FAIL: YNL ethtool pause parameters (failed to get pause parameters)"

WARNING: line length of 106 exceeds 80 columns
#475: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:80:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-pause "$NSIM_DEV_NAME" tx 1 rx 1 2>/dev/null; then

WARNING: line length of 97 exceeds 80 columns
#476: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:81:
+		echo "FAIL: YNL ethtool pause parameters (set-pause command failed unexpectedly)"

WARNING: line length of 108 exceeds 80 columns
#486: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:91:
+	features_output=$(ip netns exec "$testns" $ynl_ethtool --show-features "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 97 exceeds 80 columns
#489: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:94:
+		echo "FAIL: YNL ethtool features info (features output missing expected content)"

WARNING: line length of 108 exceeds 80 columns
#499: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:104:
+	channels_output=$(ip netns exec "$testns" $ynl_ethtool --show-channels "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 82 exceeds 80 columns
#501: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:106:
+	if ! echo "$channels_output" | grep -q -E "(Channel|Combined|RX|TX)"; then

WARNING: line length of 97 exceeds 80 columns
#502: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:107:
+		echo "FAIL: YNL ethtool channels info (channels output missing expected content)"

WARNING: line length of 116 exceeds 80 columns
#506: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:111:
+	if ! ip netns exec "$testns" $ynl_ethtool --set-channels "$NSIM_DEV_NAME" combined-count 1 2>/dev/null; then

WARNING: line length of 97 exceeds 80 columns
#507: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:112:
+		echo "FAIL: YNL ethtool channels info (set-channels command failed unexpectedly)"

WARNING: line length of 107 exceeds 80 columns
#517: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:122:
+	ts_output=$(ip netns exec "$testns" $ynl_ethtool --show-time-stamping "$NSIM_DEV_NAME" 2>/dev/null)

WARNING: line length of 97 exceeds 80 columns
#519: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:124:
+	if ! echo "$ts_output" | grep -q -E "(Time stamping|timestamping|SOF_TIMESTAMPING)"; then

WARNING: line length of 102 exceeds 80 columns
#520: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:125:
+		echo "FAIL: YNL ethtool time stamping (time stamping output missing expected content)"

WARNING: line length of 83 exceeds 80 columns
#529: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:134:
+		echo "SKIP: all YNL ethtool tests (netdevsim module not available)"

WARNING: line length of 84 exceeds 80 columns
#534: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:139:
+		echo "SKIP: all YNL ethtool tests (failed to create test namespace)"

WARNING: line length of 106 exceeds 80 columns
#538: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:143:
+	echo "$NSIM_ID 1" | ip netns exec "$testns" tee /sys/bus/netdevsim/new_device >/dev/null 2>&1 || {

WARNING: line length of 86 exceeds 80 columns
#539: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:144:
+		echo "SKIP: all YNL ethtool tests (failed to create netdevsim device)"

WARNING: line length of 112 exceeds 80 columns
#544: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:149:
+	dev=$(ip netns exec "$testns" ls /sys/bus/netdevsim/devices/netdevsim$NSIM_ID/net 2>/dev/null | head -1)

WARNING: line length of 84 exceeds 80 columns
#546: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:151:
+		echo "SKIP: all YNL ethtool tests (failed to find netdevsim device)"

WARNING: line length of 86 exceeds 80 columns
#550: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:155:
+	ip -netns "$testns" link set dev "$dev" name "$NSIM_DEV_NAME" 2>/dev/null || {

WARNING: line length of 86 exceeds 80 columns
#551: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:156:
+		echo "SKIP: all YNL ethtool tests (failed to rename netdevsim device)"

WARNING: line length of 95 exceeds 80 columns
#557: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:162:
+	if ! ip -n "$testns" link add "$VETH_A" type veth peer name "$VETH_B" 2>/dev/null; then

WARNING: line length of 115 exceeds 80 columns
#568: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:173:
+		ip netns exec "$testns" bash -c "echo $NSIM_ID > /sys/bus/netdevsim/del_device" 2>/dev/null || true

WARNING: line length of 88 exceeds 80 columns
#575: FILE: tools/net/ynl/tests/test_ynl_ethtool.sh:180:
+	echo "SKIP: all YNL ethtool tests (ynl-ethtool command not found: $ynl_ethtool)"

total: 0 errors, 99 warnings, 0 checks, 529 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 375b7bbdb460 ("tools: ynl: add YNL test framework") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 99 warnings, 0 checks, 529 lines checked