WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#139: FILE: tools/net/ynl/ynltool/json_writer.c:23:
+	unsigned	depth;

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#146: FILE: tools/net/ynl/ynltool/json_writer.c:30:
+	unsigned i;

WARNING: Missing a blank line after declarations
#147: FILE: tools/net/ynl/ynltool/json_writer.c:31:
+	unsigned i;
+	for (i = 0; i < self->depth; ++i)

WARNING: Missing a blank line after declarations
#202: FILE: tools/net/ynl/ynltool/json_writer.c:86:
+	json_writer_t *self = malloc(sizeof(*self));
+	if (self) {

CHECK: Concatenated strings should use spaces between elements
#334: FILE: tools/net/ynl/ynltool/json_writer.c:218:
+	jsonw_printf(self, "%"PRIu64, num);

WARNING: Prefer 'unsigned long long' over 'unsigned long long int' as the int is unnecessary
#337: FILE: tools/net/ynl/ynltool/json_writer.c:221:
+void jsonw_lluint(json_writer_t *self, unsigned long long int num)

CHECK: Concatenated strings should use spaces between elements
#344: FILE: tools/net/ynl/ynltool/json_writer.c:228:
+	jsonw_printf(self, "%"PRId64, num);

WARNING: Prefer 'unsigned long long' over 'unsigned long long int' as the int is unnecessary
#388: FILE: tools/net/ynl/ynltool/json_writer.c:272:
+			unsigned long long int num)

WARNING: do not add new typedefs
#430: FILE: tools/net/ynl/ynltool/json_writer.h:20:
+typedef struct json_writer json_writer_t;

WARNING: line length of 85 exceeds 80 columns
#447: FILE: tools/net/ynl/ynltool/json_writer.h:37:
+void __attribute__((format(printf, 2, 0))) jsonw_vprintf_enquote(json_writer_t *self,

WARNING: Prefer __printf(2, 0) over __attribute__((format(printf, 2, 0)))
#447: FILE: tools/net/ynl/ynltool/json_writer.h:37:
+void __attribute__((format(printf, 2, 0))) jsonw_vprintf_enquote(json_writer_t *self,

WARNING: line length of 81 exceeds 80 columns
#448: FILE: tools/net/ynl/ynltool/json_writer.h:38:
+								 const char *fmt,

WARNING: Prefer __printf(2, 3) over __attribute__((format(printf, 2, 3)))
#450: FILE: tools/net/ynl/ynltool/json_writer.h:40:
+void __attribute__((format(printf, 2, 3))) jsonw_printf(json_writer_t *self,

WARNING: Prefer 'unsigned long long' over 'unsigned long long int' as the int is unnecessary
#460: FILE: tools/net/ynl/ynltool/json_writer.h:50:
+void jsonw_lluint(json_writer_t *self, unsigned long long int num);

WARNING: Prefer 'unsigned long long' over 'unsigned long long int' as the int is unnecessary
#471: FILE: tools/net/ynl/ynltool/json_writer.h:61:
+			unsigned long long int num);

WARNING: Prefer __noreturn over __attribute__((noreturn))
#514: FILE: tools/net/ynl/ynltool/main.c:23:
+static void __attribute__((noreturn)) clean_and_exit(int i)

WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__))
#529: FILE: tools/net/ynl/ynltool/main.c:38:
+static int do_help(int argc __attribute__((unused)),

WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__))
#530: FILE: tools/net/ynl/ynltool/main.c:39:
+		   char **argv __attribute__((unused)))

WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__))
#549: FILE: tools/net/ynl/ynltool/main.c:58:
+static int do_version(int argc __attribute__((unused)),

WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__))
#550: FILE: tools/net/ynl/ynltool/main.c:59:
+		      char **argv __attribute__((unused)))

WARNING: line length of 84 exceeds 80 columns
#584: FILE: tools/net/ynl/ynltool/main.c:93:
+				p_err("command '%s' is not available", cmds[i].cmd);

WARNING: Prefer 'fallthrough;' over fallthrough comment
#696: FILE: tools/net/ynl/ynltool/main.c:205:
+			/* fall through */

WARNING: Prefer __printf(1, 2) over __attribute__((format(printf, 1, 2)))
#784: FILE: tools/net/ynl/ynltool/main.h:47:
+void __attribute__((format(printf, 1, 2))) p_err(const char *fmt, ...);

WARNING: Prefer __printf(1, 2) over __attribute__((format(printf, 1, 2)))
#785: FILE: tools/net/ynl/ynltool/main.h:48:
+void __attribute__((format(printf, 1, 2))) p_info(const char *fmt, ...);

WARNING: Prefer __noreturn over __attribute__((noreturn))
#789: FILE: tools/net/ynl/ynltool/main.h:52:
+void usage(void) __attribute__((noreturn));

WARNING: function definition argument 'void' should also have an identifier name
#789: FILE: tools/net/ynl/ynltool/main.h:52:
+void usage(void) __attribute__((noreturn));

total: 0 errors, 24 warnings, 2 checks, 722 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 07bf6fd87d57 ("tools: ynltool: create skeleton for the C command") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 24 warnings, 2 checks, 722 lines checked