ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.biEnQPVYom and /tmp/tmp.zDUKy50TSo
Tree base:
62aec1b20c09 ("net: bridge: fix use-after-free due to MST port state bypass")
Now at:
d8b824dbf2b6 ("selftests: forwarding: bridge: add a state bypass with disabled VLAN filtering test")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/forwarding/bridge_vlan_unaware.sh - f8019d0e5b6ae14a9b2583b22b850b2786c70b92215e2fa64fa682a0b80daaae


In bridge_vlan_unaware.sh line 10:
	simple_if_init $h1 192.0.2.1/24 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	simple_if_init "$h1" 192.0.2.1/24 2001:db8:1::1/64


In bridge_vlan_unaware.sh line 15:
	simple_if_fini $h1 192.0.2.1/24 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	simple_if_fini "$h1" 192.0.2.1/24 2001:db8:1::1/64


In bridge_vlan_unaware.sh line 20:
	simple_if_init $h2 192.0.2.2/24 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	simple_if_init "$h2" 192.0.2.2/24 2001:db8:1::2/64


In bridge_vlan_unaware.sh line 25:
	simple_if_fini $h2 192.0.2.2/24 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	simple_if_fini "$h2" 192.0.2.2/24 2001:db8:1::2/64


In bridge_vlan_unaware.sh line 31:
		ageing_time $LOW_AGEING_TIME \
                            ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ageing_time "$LOW_AGEING_TIME" \


In bridge_vlan_unaware.sh line 34:
	ip link set dev $swp1 master br0
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp1" master br0


In bridge_vlan_unaware.sh line 35:
	ip link set dev $swp2 master br0
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp2" master br0


In bridge_vlan_unaware.sh line 38:
	ip link set dev $swp1 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp1" up


In bridge_vlan_unaware.sh line 39:
	ip link set dev $swp2 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp2" up


In bridge_vlan_unaware.sh line 44:
	ip link set dev $swp2 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp2" down


In bridge_vlan_unaware.sh line 45:
	ip link set dev $swp1 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp1" down


In bridge_vlan_unaware.sh line 82:
	ping_test $h1 192.0.2.2 "$msg"
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping_test "$h1" 192.0.2.2 "$msg"


In bridge_vlan_unaware.sh line 89:
	ping6_test $h1 2001:db8:1::2 "$msg"
                   ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping6_test "$h1" 2001:db8:1::2 "$msg"


In bridge_vlan_unaware.sh line 94:
	learning_test "br0" $swp1 $h1 $h2
                            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	learning_test "br0" "$swp1" "$h1" "$h2"


In bridge_vlan_unaware.sh line 99:
	flood_test $swp2 $h1 $h2
                   ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_test "$swp2" "$h1" "$h2"


In bridge_vlan_unaware.sh line 106:
	bridge vlan add vid 3 dev $swp1 pvid untagged
                                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge vlan add vid 3 dev "$swp1" pvid untagged


In bridge_vlan_unaware.sh line 111:
	bridge vlan del vid 3 dev $swp1
                                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge vlan del vid 3 dev "$swp1"


In bridge_vlan_unaware.sh line 124:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/forwarding/bridge_vlan_unaware.sh - f8019d0e5b6ae14a9b2583b22b850b2786c70b92215e2fa64fa682a0b80daaae


In bridge_vlan_unaware.sh line 10:
	simple_if_init $h1 192.0.2.1/24 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	simple_if_init "$h1" 192.0.2.1/24 2001:db8:1::1/64


In bridge_vlan_unaware.sh line 15:
	simple_if_fini $h1 192.0.2.1/24 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	simple_if_fini "$h1" 192.0.2.1/24 2001:db8:1::1/64


In bridge_vlan_unaware.sh line 20:
	simple_if_init $h2 192.0.2.2/24 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	simple_if_init "$h2" 192.0.2.2/24 2001:db8:1::2/64


In bridge_vlan_unaware.sh line 25:
	simple_if_fini $h2 192.0.2.2/24 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	simple_if_fini "$h2" 192.0.2.2/24 2001:db8:1::2/64


In bridge_vlan_unaware.sh line 31:
		ageing_time $LOW_AGEING_TIME \
                            ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ageing_time "$LOW_AGEING_TIME" \


In bridge_vlan_unaware.sh line 34:
	ip link set dev $swp1 master br0
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp1" master br0


In bridge_vlan_unaware.sh line 35:
	ip link set dev $swp2 master br0
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp2" master br0


In bridge_vlan_unaware.sh line 38:
	ip link set dev $swp1 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp1" up


In bridge_vlan_unaware.sh line 39:
	ip link set dev $swp2 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp2" up


In bridge_vlan_unaware.sh line 44:
	ip link set dev $swp2 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp2" down


In bridge_vlan_unaware.sh line 45:
	ip link set dev $swp1 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$swp1" down


In bridge_vlan_unaware.sh line 82:
	ping_test $h1 192.0.2.2 "$msg"
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping_test "$h1" 192.0.2.2 "$msg"


In bridge_vlan_unaware.sh line 89:
	ping6_test $h1 2001:db8:1::2 "$msg"
                   ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping6_test "$h1" 2001:db8:1::2 "$msg"


In bridge_vlan_unaware.sh line 94:
	learning_test "br0" $swp1 $h1 $h2
                            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	learning_test "br0" "$swp1" "$h1" "$h2"


In bridge_vlan_unaware.sh line 99:
	flood_test $swp2 $h1 $h2
                   ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_test "$swp2" "$h1" "$h2"


In bridge_vlan_unaware.sh line 106:
	bridge vlan add vid 3 dev $swp1 pvid untagged
                                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge vlan add vid 3 dev "$swp1" pvid untagged


In bridge_vlan_unaware.sh line 111:
	bridge vlan del vid 3 dev $swp1
                                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge vlan del vid 3 dev "$swp1"


In bridge_vlan_unaware.sh line 126:
	bridge vlan del vid 1 dev $swp1
                                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge vlan del vid 1 dev "$swp1"


In bridge_vlan_unaware.sh line 127:
	bridge vlan del vid 1 dev $swp2
                                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge vlan del vid 1 dev "$swp2"


In bridge_vlan_unaware.sh line 133:
	bridge link set dev $swp1 state disabled
                            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$swp1" state disabled


In bridge_vlan_unaware.sh line 136:
	$MZ $h1 -c 1 -p 64 -a $mac -t ip -q
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$h1" -c 1 -p 64 -a "$mac" -t ip -q


In bridge_vlan_unaware.sh line 138:
	bridge fdb show brport $swp1 | grep -q de:ad:be:ef:13:37
                               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge fdb show brport "$swp1" | grep -q de:ad:be:ef:13:37


In bridge_vlan_unaware.sh line 144:
	bridge link set dev $swp1 state forwarding
                            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$swp1" state forwarding


In bridge_vlan_unaware.sh line 145:
	bridge vlan add vid 1 dev $swp1 pvid untagged
                                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge vlan add vid 1 dev "$swp1" pvid untagged


In bridge_vlan_unaware.sh line 146:
	bridge vlan add vid 1 dev $swp2 pvid untagged
                                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge vlan add vid 1 dev "$swp2" pvid untagged


In bridge_vlan_unaware.sh line 157:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...