WARNING: line length of 87 exceeds 80 columns #74: FILE: arch/x86/net/bpf_jit_comp.c:2632: + emit_indirect_jump(&prog, insn->dst_reg, image + addrs[i - 1]); WARNING: line length of 86 exceeds 80 columns #99: FILE: include/linux/bpf_verifier.h:530: + struct bpf_iarray *jt; /* jump table for gotox instruction */ WARNING: line length of 89 exceeds 80 columns #133: FILE: kernel/bpf/bpf_insn_array.c:117: +static int insn_array_map_direct_value_addr(const struct bpf_map *map, u64 *imm, u32 off) WARNING: line length of 90 exceeds 80 columns #229: FILE: kernel/bpf/verifier.c:6034: + err = check_mem_region_access(env, regno, off, size, mem_size, zero_size_allowed); WARNING: line length of 92 exceeds 80 columns #247: FILE: kernel/bpf/verifier.c:7505: + err = check_ptr_alignment(env, reg, off, size, strict_alignment_once || insn_array); WARNING: line length of 98 exceeds 80 columns #269: FILE: kernel/bpf/verifier.c:7567: + verbose(env, "Invalid read of %d bytes from insn_array\n", CHECK: Alignment should match open parenthesis #270: FILE: kernel/bpf/verifier.c:7568: + verbose(env, "Invalid read of %d bytes from insn_array\n", + size); WARNING: line length of 82 exceeds 80 columns #328: FILE: kernel/bpf/verifier.c:17900: +static int copy_insn_array_uniq(struct bpf_map *map, u32 start, u32 end, u32 *off) WARNING: line length of 90 exceeds 80 columns #399: FILE: kernel/bpf/verifier.c:17971: + if (jt_cur->items[0] >= subprog_start && jt_cur->items[0] < subprog_end) { WARNING: Missing a blank line after declarations #401: FILE: kernel/bpf/verifier.c:17973: + u32 old_cnt = jt ? jt->cnt : 0; + jt = iarray_realloc(jt, old_cnt + jt_cur->cnt); WARNING: line length of 85 exceeds 80 columns #406: FILE: kernel/bpf/verifier.c:17978: + memcpy(jt->items + old_cnt, jt_cur->items, jt_cur->cnt << 2); WARNING: line length of 97 exceeds 80 columns #413: FILE: kernel/bpf/verifier.c:17985: + verbose(env, "no jump tables found for subprog starting at %u\n", subprog_start); WARNING: line length of 93 exceeds 80 columns #436: FILE: kernel/bpf/verifier.c:18008: + /* Check that the every element of the jump table fits within the given subprogram */ WARNING: line length of 82 exceeds 80 columns #438: FILE: kernel/bpf/verifier.c:18010: + if (jt->items[i] < subprog_start || jt->items[i] >= subprog_end) { WARNING: line length of 102 exceeds 80 columns #439: FILE: kernel/bpf/verifier.c:18011: + verbose(env, "jump table for insn %d points outside of the subprog [%u,%u]\n", CHECK: Alignment should match open parenthesis #440: FILE: kernel/bpf/verifier.c:18012: + verbose(env, "jump table for insn %d points outside of the subprog [%u,%u]\n", + t, subprog_start, subprog_end); WARNING: line length of 94 exceeds 80 columns #471: FILE: kernel/bpf/verifier.c:18043: + verbose(env, "indirect jump out of range from insn %d to %d\n", t, w); WARNING: line length of 90 exceeds 80 columns #511: FILE: kernel/bpf/verifier.c:19087: + return memcmp(rold, rcur, offsetof(struct bpf_reg_state, var_off)) == 0 && CHECK: Alignment should match open parenthesis #531: FILE: kernel/bpf/verifier.c:20109: + if (check_add_overflow(reg->umin_value, reg->off, &min_index) || + (min_index > (u64) U32_MAX * size)) { CHECK: No space is necessary after a cast #531: FILE: kernel/bpf/verifier.c:20109: + (min_index > (u64) U32_MAX * size)) { WARNING: line length of 86 exceeds 80 columns #532: FILE: kernel/bpf/verifier.c:20110: + verbose(env, "the sum of R%u umin_value %llu and off %u is too big\n", CHECK: Alignment should match open parenthesis #533: FILE: kernel/bpf/verifier.c:20111: + verbose(env, "the sum of R%u umin_value %llu and off %u is too big\n", + regno, reg->umin_value, reg->off); CHECK: Alignment should match open parenthesis #537: FILE: kernel/bpf/verifier.c:20115: + if (check_add_overflow(reg->umax_value, reg->off, &max_index) || + (max_index > (u64) U32_MAX * size)) { CHECK: No space is necessary after a cast #537: FILE: kernel/bpf/verifier.c:20115: + (max_index > (u64) U32_MAX * size)) { WARNING: line length of 86 exceeds 80 columns #538: FILE: kernel/bpf/verifier.c:20116: + verbose(env, "the sum of R%u umax_value %llu and off %u is too big\n", CHECK: Alignment should match open parenthesis #539: FILE: kernel/bpf/verifier.c:20117: + verbose(env, "the sum of R%u umax_value %llu and off %u is too big\n", + regno, reg->umax_value, reg->off); WARNING: line length of 97 exceeds 80 columns #547: FILE: kernel/bpf/verifier.c:20125: + verbose(env, "R%u points to outside of jump table: [%llu,%llu] max_entries %u\n", CHECK: Alignment should match open parenthesis #548: FILE: kernel/bpf/verifier.c:20126: + verbose(env, "R%u points to outside of jump table: [%llu,%llu] max_entries %u\n", + regno, min_index, max_index, map->max_entries); WARNING: line length of 83 exceeds 80 columns #558: FILE: kernel/bpf/verifier.c:20136: +static int check_indirect_jump(struct bpf_verifier_env *env, struct bpf_insn *insn) CHECK: Alignment should match open parenthesis #571: FILE: kernel/bpf/verifier.c:20149: + verbose(env, "R%d has type %s, expected PTR_TO_INSN\n", + insn->dst_reg, reg_type_str(env, dst_reg->type)); WARNING: line length of 86 exceeds 80 columns #576: FILE: kernel/bpf/verifier.c:20154: + if (verifier_bug_if(!map, env, "R%d has an empty map pointer", insn->dst_reg)) WARNING: line length of 91 exceeds 80 columns #580: FILE: kernel/bpf/verifier.c:20158: + "R%d has incorrect map type %d", insn->dst_reg, map->map_type)) WARNING: line length of 91 exceeds 80 columns #583: FILE: kernel/bpf/verifier.c:20161: + err = indirect_jump_min_max_index(env, insn->dst_reg, map, &min_index, &max_index); WARNING: line length of 89 exceeds 80 columns #588: FILE: kernel/bpf/verifier.c:20166: + if (!env->gotox_tmp_buf || env->gotox_tmp_buf->cnt < max_index - min_index + 1) { WARNING: line length of 87 exceeds 80 columns #595: FILE: kernel/bpf/verifier.c:20173: + n = copy_insn_array_uniq(map, min_index, max_index, env->gotox_tmp_buf->items); WARNING: line length of 87 exceeds 80 columns #599: FILE: kernel/bpf/verifier.c:20177: + verbose(env, "register R%d doesn't point to any offset in map id=%d\n", CHECK: Alignment should match open parenthesis #600: FILE: kernel/bpf/verifier.c:20178: + verbose(env, "register R%d doesn't point to any offset in map id=%d\n", + insn->dst_reg, map->id); WARNING: line length of 86 exceeds 80 columns #606: FILE: kernel/bpf/verifier.c:20184: + env->insn_idx, env->cur_state->speculative); CHECK: spaces preferred around that '-' (ctx:VxV) #610: FILE: kernel/bpf/verifier.c:20188: + env->insn_idx = env->gotox_tmp_buf->items[n-1]; ^ WARNING: line length of 92 exceeds 80 columns #624: FILE: kernel/bpf/verifier.c:20297: + verbose(env, "BPF_JA|BPF_X uses reserved fields\n"); WARNING: line length of 82 exceeds 80 columns #646: FILE: kernel/bpf/verifier.c:21378: + * Clean up dynamically allocated fields of aux data for instructions [start, ...] WARNING: line length of 81 exceeds 80 columns #648: FILE: kernel/bpf/verifier.c:21380: +static void clear_insn_aux_data(struct bpf_verifier_env *env, int start, int len) total: 0 errors, 30 warnings, 12 checks, 578 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit a37217ea7aca ("bpf, x86: add support for indirect jumps") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 30 warnings, 12 checks, 578 lines checked