ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.9ykqHMhKb8 and /tmp/tmp.uJLyamYo0v
Tree base:
6a2108c78069 ("net: devmem: refresh devmem TX dst in case of route invalidation")
Now at:
7738f9a1e2f3 ("selftests: netdevsim: Fix ethtool-features.sh fail")
 ====== Checking before the patch ======
Checking tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh - c7ef187d33858f1329467915fcc58d443dcfe57a8921744a5eae4610f343e69c


In ethtool-features.sh line 4:
source ethtool-common.sh
       ^---------------^ SC1094 (warning): Parsing of sourced file failed. Ignoring it.


In ethtool-features.sh line 18:
    s=$(ethtool --json -k $NSIM_NETDEV | jq ".[].\"$feat\".active" 2>/dev/null)
                          ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    s=$(ethtool --json -k "$NSIM_NETDEV" | jq ".[].\"$feat\".active" 2>/dev/null)


In ethtool-features.sh line 21:
    s=$(ethtool --json -k $NSIM_NETDEV | jq ".[].\"$feat\".fixed" 2>/dev/null)
                          ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    s=$(ethtool --json -k "$NSIM_NETDEV" | jq ".[].\"$feat\".fixed" 2>/dev/null)


In ethtool-features.sh line 25:
if [ $num_errors -eq 0 ]; then
     ^---------^ SC2154 (warning): num_errors is referenced but not assigned.
     ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
if [ "$num_errors" -eq 0 ]; then


In ethtool-features.sh line 26:
    echo "PASSED all $((num_passes)) checks"
                        ^--------^ SC2154 (warning): num_passes is referenced but not assigned.

For more information:
  https://www.shellcheck.net/wiki/SC1094 -- Parsing of sourced file failed. I...
  https://www.shellcheck.net/wiki/SC2154 -- num_errors is referenced but not ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh - c7ef187d33858f1329467915fcc58d443dcfe57a8921744a5eae4610f343e69c


In ethtool-features.sh line 4:
source ethtool-common.sh
       ^---------------^ SC1094 (warning): Parsing of sourced file failed. Ignoring it.


In ethtool-features.sh line 10:
if ! ethtool --json -k $NSIM_NETDEV > /dev/null 2>&1; then
                       ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
if ! ethtool --json -k "$NSIM_NETDEV" > /dev/null 2>&1; then


In ethtool-features.sh line 12:
	exit $ksft_skip
             ^--------^ SC2154 (warning): ksft_skip is referenced but not assigned.
             ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	exit "$ksft_skip"


In ethtool-features.sh line 23:
    s=$(ethtool --json -k $NSIM_NETDEV | jq ".[].\"$feat\".active" 2>/dev/null)
                          ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    s=$(ethtool --json -k "$NSIM_NETDEV" | jq ".[].\"$feat\".active" 2>/dev/null)


In ethtool-features.sh line 26:
    s=$(ethtool --json -k $NSIM_NETDEV | jq ".[].\"$feat\".fixed" 2>/dev/null)
                          ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    s=$(ethtool --json -k "$NSIM_NETDEV" | jq ".[].\"$feat\".fixed" 2>/dev/null)


In ethtool-features.sh line 30:
if [ $num_errors -eq 0 ]; then
     ^---------^ SC2154 (warning): num_errors is referenced but not assigned.
     ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
if [ "$num_errors" -eq 0 ]; then


In ethtool-features.sh line 31:
    echo "PASSED all $((num_passes)) checks"
                        ^--------^ SC2154 (warning): num_passes is referenced but not assigned.

For more information:
  https://www.shellcheck.net/wiki/SC1094 -- Parsing of sourced file failed. I...
  https://www.shellcheck.net/wiki/SC2154 -- ksft_skip is referenced but not a...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...