WARNING: line length of 82 exceeds 80 columns #126: FILE: net/quic/path.c:51: + struct quic_udp_sock *us = container_of(work, struct quic_udp_sock, work); WARNING: line length of 81 exceeds 80 columns #130: FILE: net/quic/path.c:55: + /* Hold the sock to safely access it in quic_udp_sock_lookup() even after WARNING: line length of 81 exceeds 80 columns #131: FILE: net/quic/path.c:56: + * udp_tunnel_sock_release(). The release must occur before __hlist_del() WARNING: line length of 82 exceeds 80 columns #132: FILE: net/quic/path.c:57: + * so a new UDP tunnel socket can be created for the same address and port WARNING: line length of 82 exceeds 80 columns #135: FILE: net/quic/path.c:60: + * Note: udp_tunnel_sock_release() cannot be called under the mutex due to WARNING: line length of 86 exceeds 80 columns #150: FILE: net/quic/path.c:75: +static struct quic_udp_sock *quic_udp_sock_create(struct sock *sk, union quic_addr *a) WARNING: line length of 94 exceeds 80 columns #198: FILE: net/quic/path.c:123: +/* Lookup a quic_udp_sock in the global hash table by port or address. If 'a' is provided, it WARNING: line length of 95 exceeds 80 columns #199: FILE: net/quic/path.c:124: + * searches for a socket whose local address matches 'a' and, if applicable, matches the device WARNING: line length of 96 exceeds 80 columns #202: FILE: net/quic/path.c:127: +static struct quic_udp_sock *quic_udp_sock_lookup(struct sock *sk, union quic_addr *a, u16 port) WARNING: line length of 82 exceeds 80 columns #225: FILE: net/quic/path.c:150: +static void quic_path_set_udp_sk(struct quic_path *path, struct quic_udp_sock *us) WARNING: line length of 96 exceeds 80 columns #256: FILE: net/quic/path.c:181: + if (!quic_udp_sock_get(us)) { /* Releasing in workqueue; retry later. */ WARNING: line length of 89 exceeds 80 columns #309: FILE: net/quic/path.c:234: + * Promotes the alternate path (path[1]) to become the new active path (path[0]). If the WARNING: line length of 90 exceeds 80 columns #310: FILE: net/quic/path.c:235: + * alternate path has a valid UDP socket, the entire path is swapped. Otherwise, only the WARNING: line length of 93 exceeds 80 columns #311: FILE: net/quic/path.c:236: + * destination address is exchanged, assuming the source address is the same and no rebind is WARNING: line length of 87 exceeds 80 columns #335: FILE: net/quic/path.c:260: + * This is used for cleanup during error handling or when the path is no longer needed. WARNING: line length of 92 exceeds 80 columns #350: FILE: net/quic/path.c:275: + * If the new source or destination address differs from the active path, and alternate path WARNING: line length of 93 exceeds 80 columns #351: FILE: net/quic/path.c:276: + * detection is not disabled, the function updates the alternate path slot (path[1]) with the WARNING: line length of 93 exceeds 80 columns #354: FILE: net/quic/path.c:279: + * This is typically called on packet receive to detect new possible network paths (e.g., NAT WARNING: line length of 97 exceeds 80 columns #359: FILE: net/quic/path.c:284: +int quic_path_detect_alt(struct quic_path_group *paths, union quic_addr *sa, union quic_addr *da, WARNING: line length of 98 exceeds 80 columns #362: FILE: net/quic/path.c:287: + if ((!quic_cmp_sk_addr(sk, quic_path_saddr(paths, 0), sa) && !paths->disable_saddr_alt) || WARNING: line length of 98 exceeds 80 columns #363: FILE: net/quic/path.c:288: + (!quic_cmp_sk_addr(sk, quic_path_daddr(paths, 0), da) && !paths->disable_daddr_alt)) { WARNING: line length of 87 exceeds 80 columns #378: FILE: net/quic/path.c:303: +void quic_path_get_param(struct quic_path_group *paths, struct quic_transport_param *p) WARNING: line length of 87 exceeds 80 columns #387: FILE: net/quic/path.c:312: +void quic_path_set_param(struct quic_path_group *paths, struct quic_transport_param *p) WARNING: line length of 92 exceeds 80 columns #416: FILE: net/quic/path.c:341: + * Called immediately after sending a probe packet in QUIC Path MTU Discovery. Tracks probe WARNING: line length of 93 exceeds 80 columns #417: FILE: net/quic/path.c:342: + * count and manages state transitions based on the number of probes sent and current PLPMTUD WARNING: line length of 92 exceeds 80 columns #418: FILE: net/quic/path.c:343: + * state (BASE, SEARCH, COMPLETE, ERROR). Detects probe failures and black holes, adjusting WARNING: line length of 99 exceeds 80 columns #433: FILE: net/quic/path.c:358: + if (paths->pl.probe_size == QUIC_BASE_PLPMTU) { /* BASE_PLPMTU Confirming Failed */ WARNING: line length of 87 exceeds 80 columns #440: FILE: net/quic/path.c:365: + if (paths->pl.pmtu == paths->pl.probe_size) { /* Black Hole Detected */ WARNING: line length of 87 exceeds 80 columns #452: FILE: net/quic/path.c:377: + if (paths->pl.pmtu == paths->pl.probe_size) { /* Black Hole Detected */ WARNING: line length of 86 exceeds 80 columns #453: FILE: net/quic/path.c:378: + paths->pl.state = QUIC_PL_BASE; /* Search Complete -> Base */ WARNING: line length of 91 exceeds 80 columns #462: FILE: net/quic/path.c:387: + pr_debug("%s: dst: %p, state: %d, pmtu: %d, size: %d, high: %d\n", __func__, paths, WARNING: line length of 94 exceeds 80 columns #463: FILE: net/quic/path.c:388: + paths->pl.state, paths->pl.pmtu, paths->pl.probe_size, paths->pl.probe_high); WARNING: line length of 90 exceeds 80 columns #470: FILE: net/quic/path.c:395: + * Called when a probe packet is acknowledged. Updates probe size and transitions state if WARNING: line length of 86 exceeds 80 columns #471: FILE: net/quic/path.c:396: + * needed (e.g., from SEARCH to COMPLETE). Expands PMTU using binary or linear search WARNING: line length of 87 exceeds 80 columns #476: FILE: net/quic/path.c:401: +u32 quic_path_pl_recv(struct quic_path_group *paths, bool *raise_timer, bool *complete) WARNING: line length of 91 exceeds 80 columns #480: FILE: net/quic/path.c:405: + pr_debug("%s: dst: %p, state: %d, pmtu: %d, size: %d, high: %d\n", __func__, paths, WARNING: line length of 94 exceeds 80 columns #481: FILE: net/quic/path.c:406: + paths->pl.state, paths->pl.pmtu, paths->pl.probe_size, paths->pl.probe_high); WARNING: line length of 89 exceeds 80 columns #500: FILE: net/quic/path.c:425: + (u16)min(paths->pl.probe_size + QUIC_PL_BIG_STEP, WARNING: line length of 91 exceeds 80 columns #510: FILE: net/quic/path.c:435: + paths->pl.state = QUIC_PL_COMPLETE; /* Search -> Search Complete */ WARNING: line length of 83 exceeds 80 columns #517: FILE: net/quic/path.c:442: + /* Raise probe_size again after 30 * interval in Search Complete */ WARNING: line length of 81 exceeds 80 columns #518: FILE: net/quic/path.c:443: + paths->pl.state = QUIC_PL_SEARCH; /* Search Complete -> Search */ WARNING: line length of 88 exceeds 80 columns #519: FILE: net/quic/path.c:444: + paths->pl.probe_size = (u16)min(paths->pl.probe_size + QUIC_PL_MIN_STEP, WARNING: line length of 90 exceeds 80 columns #529: FILE: net/quic/path.c:454: + * Responds to an incoming ICMP error by reducing the probe size or falling back to a safe WARNING: line length of 89 exceeds 80 columns #530: FILE: net/quic/path.c:455: + * baseline PMTU depending on current state. Also handles cases where the PMTU hint lies WARNING: line length of 83 exceeds 80 columns #535: FILE: net/quic/path.c:460: +u32 quic_path_pl_toobig(struct quic_path_group *paths, u32 pmtu, bool *reset_timer) WARNING: line length of 90 exceeds 80 columns #539: FILE: net/quic/path.c:464: + pr_debug("%s: dst: %p, state: %d, pmtu: %d, size: %d, ptb: %d\n", __func__, paths, WARNING: line length of 92 exceeds 80 columns #562: FILE: net/quic/path.c:487: + } else if (pmtu > (u32)paths->pl.pmtu && pmtu < (u32)paths->pl.probe_size) { WARNING: line length of 92 exceeds 80 columns #583: FILE: net/quic/path.c:508: + * Resets all PLPMTUD-related state to its initial configuration. Called when a new path is WARNING: line length of 90 exceeds 80 columns #596: FILE: net/quic/path.c:521: + * Checks whether the last probe (tracked by .number) has been acknowledged. If the probe WARNING: line length of 83 exceeds 80 columns #601: FILE: net/quic/path.c:526: +bool quic_path_pl_confirm(struct quic_path_group *paths, s64 largest, s64 smallest) WARNING: line length of 95 exceeds 80 columns #603: FILE: net/quic/path.c:528: + return paths->pl.number && paths->pl.number >= smallest && paths->pl.number <= largest; WARNING: line length of 87 exceeds 80 columns #657: FILE: net/quic/path.h:42: + QUIC_PATH_ALT_NONE, /* No alternate path (migration complete or aborted) */ WARNING: line length of 85 exceeds 80 columns #658: FILE: net/quic/path.h:43: + QUIC_PATH_ALT_PENDING, /* Waiting for a new destination CID for migration */ WARNING: line length of 84 exceeds 80 columns #659: FILE: net/quic/path.h:44: + QUIC_PATH_ALT_PROBING, /* Validating the alternate path (PATH_CHALLENGE) */ WARNING: line length of 81 exceeds 80 columns #660: FILE: net/quic/path.h:45: + QUIC_PATH_ALT_SWAPPED, /* Alternate path is now active; roles swapped */ WARNING: line length of 84 exceeds 80 columns #664: FILE: net/quic/path.h:49: + struct work_struct work; /* Workqueue to destroy UDP tunnel socket */ WARNING: line length of 90 exceeds 80 columns #665: FILE: net/quic/path.h:50: + struct hlist_node node; /* Entry in address-based UDP socket hash table */ WARNING: line length of 92 exceeds 80 columns #666: FILE: net/quic/path.h:51: + union quic_addr addr; /* Source address of underlying UDP tunnel socket */ WARNING: line length of 93 exceeds 80 columns #676: FILE: net/quic/path.h:61: + struct quic_udp_sock *udp_sk; /* Wrapped UDP socket used to receive QUIC packets */ WARNING: line length of 93 exceeds 80 columns #677: FILE: net/quic/path.h:62: + /* Cached UDP tunnel socket and its source address for RCU-protected lookup/access */ WARNING: line length of 82 exceeds 80 columns #684: FILE: net/quic/path.h:69: + struct quic_conn_id retry_dcid; /* Source CID from Retry packet */ WARNING: line length of 88 exceeds 80 columns #685: FILE: net/quic/path.h:70: + struct quic_conn_id orig_dcid; /* Destination CID from first Initial */ WARNING: line length of 92 exceeds 80 columns #689: FILE: net/quic/path.h:74: + struct quic_path path[2]; /* Active path (0) and alternate path (1) */ WARNING: line length of 86 exceeds 80 columns #690: FILE: net/quic/path.h:75: + struct flowi fl; /* Flow info from routing decisions */ WARNING: line length of 82 exceeds 80 columns #697: FILE: net/quic/path.h:82: + u32 mtu_info; /* PMTU value from received ICMP, pending apply */ WARNING: line length of 92 exceeds 80 columns #709: FILE: net/quic/path.h:94: + u8 disable_saddr_alt:1; /* Remote disable_active_migration (rfc9000#section-18.2) */ WARNING: line length of 91 exceeds 80 columns #710: FILE: net/quic/path.h:95: + u8 disable_daddr_alt:1; /* Local disable_active_migration (rfc9000#section-18.2) */ WARNING: line length of 86 exceeds 80 columns #711: FILE: net/quic/path.h:96: + u8 pref_addr:1; /* Preferred address offered (rfc9000#section-18.2) */ WARNING: line length of 90 exceeds 80 columns #713: FILE: net/quic/path.h:98: + u8 alt_state; /* State for alternate path migration logic (see above) */ WARNING: line length of 86 exceeds 80 columns #722: FILE: net/quic/path.h:107: +static inline union quic_addr *quic_path_saddr(struct quic_path_group *paths, u8 path) WARNING: line length of 86 exceeds 80 columns #733: FILE: net/quic/path.h:118: +static inline union quic_addr *quic_path_daddr(struct quic_path_group *paths, u8 path) WARNING: line length of 86 exceeds 80 columns #744: FILE: net/quic/path.h:129: +static inline union quic_addr *quic_path_uaddr(struct quic_path_group *paths, u8 path) WARNING: line length of 82 exceeds 80 columns #749: FILE: net/quic/path.h:134: +static inline struct sock *quic_path_usock(struct quic_path_group *paths, u8 path) WARNING: line length of 83 exceeds 80 columns #759: FILE: net/quic/path.h:144: +static inline void quic_path_set_alt_state(struct quic_path_group *paths, u8 state) WARNING: line length of 84 exceeds 80 columns #764: FILE: net/quic/path.h:149: +/* Returns the destination Connection ID (DCID) used for identifying the connection. WARNING: line length of 88 exceeds 80 columns #765: FILE: net/quic/path.h:150: + * Per rfc9000#section-7.3, handshake packets are considered part of the same connection WARNING: line length of 85 exceeds 80 columns #768: FILE: net/quic/path.h:153: +static inline struct quic_conn_id *quic_path_orig_dcid(struct quic_path_group *paths) WARNING: line length of 97 exceeds 80 columns #773: FILE: net/quic/path.h:158: +int quic_path_detect_alt(struct quic_path_group *paths, union quic_addr *sa, union quic_addr *da, WARNING: line length of 88 exceeds 80 columns #779: FILE: net/quic/path.h:164: +u32 quic_path_pl_recv(struct quic_path_group *paths, bool *raise_timer, bool *complete); WARNING: line length of 84 exceeds 80 columns #780: FILE: net/quic/path.h:165: +u32 quic_path_pl_toobig(struct quic_path_group *paths, u32 pmtu, bool *reset_timer); WARNING: line length of 88 exceeds 80 columns #783: FILE: net/quic/path.h:168: +void quic_path_get_param(struct quic_path_group *paths, struct quic_transport_param *p); WARNING: line length of 88 exceeds 80 columns #784: FILE: net/quic/path.h:169: +void quic_path_set_param(struct quic_path_group *paths, struct quic_transport_param *p); WARNING: line length of 84 exceeds 80 columns #785: FILE: net/quic/path.h:170: +bool quic_path_pl_confirm(struct quic_path_group *paths, s64 largest, s64 smallest); total: 0 errors, 83 warnings, 0 checks, 807 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 15635524c9a8 ("quic: add path management") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 83 warnings, 0 checks, 807 lines checked