WARNING: Consider removing the code enclosed by this #if 0 and its #endif #58: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:18: +#if 0 WARNING: line length of 82 exceeds 80 columns #59: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:19: +static void __test_run(struct bpf_program *prog, void *ctx_in, size_t ctx_size_in) CHECK: Alignment should match open parenthesis #62: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:22: + LIBBPF_OPTS(bpf_test_run_opts, topts, + .ctx_in = ctx_in, WARNING: line length of 86 exceeds 80 columns #100: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:60: +/* validate that for two loads of the same jump table libbpf generates only one map */ WARNING: line length of 86 exceeds 80 columns #138: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:98: + if (!ASSERT_EQ(seen, false, "more than one INSN_ARRAY map")) { WARNING: line length of 91 exceeds 80 columns #167: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:127: + check_simple(skel, skel->progs.one_switch_non_zero_sec_off, in[i], out[i]); ERROR: space prohibited before that ',' (ctx:WxW) #193: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:153: + __u64 out[] = {12, 15, 7 , 15, 12, 15, 15}; ^ WARNING: line length of 81 exceeds 80 columns #197: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:157: + check_simple(skel, skel->progs.one_jump_two_maps, in[i], out[i]); WARNING: line length of 82 exceeds 80 columns #207: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:167: + check_simple(skel, skel->progs.use_static_global1, in[i], out[i]); WARNING: line length of 82 exceeds 80 columns #209: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:169: + check_simple(skel, skel->progs.use_static_global2, in[i], out[i]); WARNING: line length of 85 exceeds 80 columns #219: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:179: + check_simple(skel, skel->progs.use_nonstatic_global1, in[i], out[i]); WARNING: line length of 85 exceeds 80 columns #222: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:182: + check_simple(skel, skel->progs.use_nonstatic_global2, in[i], out[i]); WARNING: line length of 92 exceeds 80 columns #233: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:193: + check_simple_fentry(skel, skel->progs.simple_test_other_sec, in[i], out[i]); WARNING: line length of 98 exceeds 80 columns #244: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:204: + check_simple_fentry(skel, skel->progs.use_static_global_other_sec, in[i], out[i]); WARNING: line length of 101 exceeds 80 columns #255: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:215: + check_simple_fentry(skel, skel->progs.use_nonstatic_global_other_sec, in[i], out[i]); WARNING: Consider removing the code enclosed by this #if 0 and its #endif #331: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:9: +#if 0 WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #513: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:191: +int big_jump_table(struct simple_ctx *ctx __attribute__((unused))) WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #552: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:230: +int one_jump_two_maps(struct simple_ctx *ctx __attribute__((unused))) WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #559: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:237: + volatile int ret = 0; WARNING: labels should not be indented #569: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:247: + l1: ret += 1; WARNING: labels should not be indented #570: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:248: + l2: ret += 3; WARNING: labels should not be indented #571: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:249: + l3: ret += 5; WARNING: labels should not be indented #572: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:250: + l4: ret += 7; WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #579: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:257: +int one_map_two_jumps(struct simple_ctx *ctx __attribute__((unused))) WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #585: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:263: + volatile int ret = 0; WARNING: labels should not be indented #593: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:271: + l1: ret += 3; WARNING: labels should not be indented #594: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:272: + l2: ret += 5; WARNING: labels should not be indented #595: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:273: + l3: ret += 7; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #602: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:280: +static __noinline int f0(volatile struct simple_ctx *ctx __arg_ctx) total: 1 errors, 27 warnings, 1 checks, 687 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 048fec473959 ("selftests/bpf: add C-level selftests for indirect jumps") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.