ERROR: trailing whitespace
#24: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:51:
+#include <linux/printk.h> $

ERROR: code indent should use tabs where possible
#34: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:107:
+        netdev_err(dev, "scb_cmd timed out: %04x,%04x .. disabling i82586!!\n",$

WARNING: please, no spaces at the start of a line
#34: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:107:
+        netdev_err(dev, "scb_cmd timed out: %04x,%04x .. disabling i82586!!\n",$

ERROR: code indent should use tabs where possible
#35: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:108:
+           p->scb->cmd_cuc, p->scb->cus);$

CHECK: Alignment should match open parenthesis
#35: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:108:
+        netdev_err(dev, "scb_cmd timed out: %04x,%04x .. disabling i82586!!\n",
+           p->scb->cmd_cuc, p->scb->cus);

WARNING: please, no spaces at the start of a line
#35: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:108:
+           p->scb->cmd_cuc, p->scb->cus);$

ERROR: space required before the open parenthesis '('
#36: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:109:
+		if(!p->reseted) { p->reseted = 1; sun3_reset586(); } } } }

ERROR: trailing statements should be on next line
#36: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:109:
+		if(!p->reseted) { p->reseted = 1; sun3_reset586(); } } } }

WARNING: suspect code indent for conditional statements (4, 6)
#42: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:115:
     if(i == 16383) { \
+      netdev_err(dev, "scb_cmd (ruc) timed out: %04x,%04x .. disabling i82586!!\n",

WARNING: please, no spaces at the start of a line
#45: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:116:
+      netdev_err(dev, "scb_cmd (ruc) timed out: %04x,%04x .. disabling i82586!!\n",$

ERROR: code indent should use tabs where possible
#46: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:117:
+           p->scb->cmd_ruc, p->scb->rus);$

CHECK: Alignment should match open parenthesis
#46: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:117:
+      netdev_err(dev, "scb_cmd (ruc) timed out: %04x,%04x .. disabling i82586!!\n",
+           p->scb->cmd_ruc, p->scb->rus);

WARNING: please, no spaces at the start of a line
#46: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:117:
+           p->scb->cmd_ruc, p->scb->rus);$

ERROR: space required before the open parenthesis '('
#47: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:118:
+		if(!p->reseted) { p->reseted = 1; sun3_reset586(); } } } }

ERROR: trailing statements should be on next line
#47: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:118:
+		if(!p->reseted) { p->reseted = 1; sun3_reset586(); } } } }

ERROR: code indent should use tabs where possible
#76: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:365:
+           size);$

CHECK: Alignment should match open parenthesis
#76: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:365:
+		netdev_err(dev, "Illegal memory size %d. Allowed is 0x2000 or 0x4000 or 0x8000 bytes.\n",
+           size);

WARNING: please, no spaces at the start of a line
#76: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:365:
+           size);$

ERROR: code indent should use tabs where possible
#83: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:371:
+           dev->mem_start, size);$

CHECK: Alignment should match open parenthesis
#83: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:371:
+		netdev_err(dev, "memcheck: Can't find memory at 0x%lx with size %d!\n",
+           dev->mem_start, size);

WARNING: please, no spaces at the start of a line
#83: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:371:
+           dev->mem_start, size);$

ERROR: code indent should use tabs where possible
#93: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:393:
+            dev->mem_start, size, dev->irq);$

CHECK: Alignment should match open parenthesis
#93: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:393:
+	netdev_info(dev, "Memaddr: 0x%lx, Memsize: %d, IRQ %d\n",
+            dev->mem_start, size, dev->irq);

WARNING: please, no spaces at the start of a line
#93: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:393:
+            dev->mem_start, size, dev->irq);$

WARNING: line length of 95 exceeds 80 columns
#111: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:455:
+		netdev_err(dev, "configure command failed: %x\n", swab16(cfg_cmd->cmd_status));

ERROR: code indent should use tabs where possible
#121: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:480:
+           swab16(ias_cmd->cmd_status));$

CHECK: Alignment should match open parenthesis
#121: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:480:
+		netdev_err(dev, "(82586): individual address setup command failed: %04x\n",
+           swab16(ias_cmd->cmd_status));

WARNING: please, no spaces at the start of a line
#121: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:480:
+           swab16(ias_cmd->cmd_status));$

ERROR: trailing whitespace
#130: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:503:
+^I    netdev_warn(dev, "Problems while running the TDR.\n");^I$

WARNING: line length of 113 exceeds 80 columns
#142: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:518:
+			netdev_warn(dev, "TDR: No correct termination %d clocks away.\n", result & TDR_TIMEMASK);

WARNING: line length of 123 exceeds 80 columns
#147: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:522:
+				netdev_warn(dev, "TDR: Detected a short circuit %d clocks away.\n", result & TDR_TIMEMASK);

WARNING: suspect code indent for conditional statements (16, 15)
#158: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:550:
 		if( (swab16(mc_cmd->cmd_status) & (STAT_COMPL|STAT_OK)) != (STAT_COMPL|STAT_OK) )
+	       netdev_err(dev, "Can't apply multicast-address-list.\n");

ERROR: code indent should use tabs where possible
#197: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:727:
+            (int) stat, (int) p->scb->rus);$

CHECK: Alignment should match open parenthesis
#197: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:727:
+				netdev_warn(dev, "Receiver-Unit went 'NOT READY': %04x/%02x.\n",
+            (int) stat, (int) p->scb->rus);

CHECK: No space is necessary after a cast
#197: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:727:
+            (int) stat, (int) p->scb->rus);

WARNING: please, no spaces at the start of a line
#197: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:727:
+            (int) stat, (int) p->scb->rus);$

WARNING: suspect code indent for conditional statements (24, 21)
#204: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:738:
 			if(netif_running(dev))
+		     netdev_warn(dev, "oops! CU has left active state. stat: %04x/%02x.\n",

ERROR: code indent should use tabs where possible
#207: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:740:
+            (int) stat, (int) p->scb->cus);$

CHECK: Alignment should match open parenthesis
#207: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:740:
+		     netdev_warn(dev, "oops! CU has left active state. stat: %04x/%02x.\n",
+            (int) stat, (int) p->scb->cus);

CHECK: No space is necessary after a cast
#207: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:740:
+            (int) stat, (int) p->scb->cus);

WARNING: please, no spaces at the start of a line
#207: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:740:
+            (int) stat, (int) p->scb->cus);$

WARNING: line length of 107 exceeds 80 columns
#254: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:817:
+					netdev_warn(dev, "received oversized frame! length: %d\n", totlen);

WARNING: line length of 82 exceeds 80 columns
#261: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:823:
+			netdev_err(dev, "oops! rfd-error-status: %04x\n", status);

WARNING: suspect code indent for conditional statements (24, 23)
#277: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:854:
 			if(i == 1023)
+		       netdev_warn(dev, "RU hasn't fetched next RFD (not busy/complete)\n");

ERROR: code indent should use tabs where possible
#289: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:867:
+            status, old_at_least);$

CHECK: Alignment should match open parenthesis
#289: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:867:
+		netdev_warn(dev, "received a FC intr. without having a frame: %04x %d\n",
+            status, old_at_least);

WARNING: please, no spaces at the start of a line
#289: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:867:
+            status, old_at_least);$

WARNING: line length of 82 exceeds 80 columns
#295: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:872:
+			netdev_dbg(dev, "%04x:%04x ", rfds->status, rbds->status);

ERROR: code indent should use tabs where possible
#301: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:876:
+            (int)p->scb->rsc_errs, (int)p->scb->ovrn_errs, (int)p->scb->status);$

CHECK: Alignment should match open parenthesis
#301: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:876:
+		netdev_dbg(dev, "\nerrs: %04x %04x stat: %04x\n",
+            (int)p->scb->rsc_errs, (int)p->scb->ovrn_errs, (int)p->scb->status);

WARNING: please, no spaces at the start of a line
#301: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:876:
+            (int)p->scb->rsc_errs, (int)p->scb->ovrn_errs, (int)p->scb->status);$

WARNING: line length of 95 exceeds 80 columns
#303: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:878:
+            (int)p->scb->rsc_errs, (int)p->scb->ovrn_errs, (int)p->scb->rus, (int)p->scb->cus);

ERROR: code indent should use tabs where possible
#303: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:878:
+            (int)p->scb->rsc_errs, (int)p->scb->ovrn_errs, (int)p->scb->rus, (int)p->scb->cus);$

CHECK: Alignment should match open parenthesis
#303: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:878:
+		netdev_dbg(dev, "\nerrs: %04x %04x rus: %02x, cus: %02x\n",
+            (int)p->scb->rsc_errs, (int)p->scb->ovrn_errs, (int)p->scb->rus, (int)p->scb->cus);

WARNING: please, no spaces at the start of a line
#303: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:878:
+            (int)p->scb->rsc_errs, (int)p->scb->ovrn_errs, (int)p->scb->rus, (int)p->scb->cus);$

WARNING: please, no spaces at the start of a line
#320: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:905:
+    netdev_info(dev, "Receive-Unit restarted. Status: %04x\n", p->scb->rus);$

WARNING: line length of 81 exceeds 80 columns
#373: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:986:
+		netdev_dbg(dev, "%s: X0: %04x N0: %04x N1: %04x %d\n", dev->name,

CHECK: Alignment should match open parenthesis
#374: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:987:
+		netdev_dbg(dev, "%s: X0: %04x N0: %04x N1: %04x %d\n", dev->name,
+			(int)swab16(p->xmit_cmds[0]->cmd_status),

WARNING: line length of 97 exceeds 80 columns
#388: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1005:
+		netdev_warn(dev, "xmitter timed out, try to restart! stat: %02x\n", p->scb->cus);

WARNING: line length of 101 exceeds 80 columns
#389: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1006:
+        netdev_dbg(dev, "%s: command-stats: %04x\n", dev->name, swab16(p->xmit_cmds[0]->cmd_status));

ERROR: code indent should use tabs where possible
#389: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1006:
+        netdev_dbg(dev, "%s: command-stats: %04x\n", dev->name, swab16(p->xmit_cmds[0]->cmd_status));$

WARNING: please, no spaces at the start of a line
#389: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1006:
+        netdev_dbg(dev, "%s: command-stats: %04x\n", dev->name, swab16(p->xmit_cmds[0]->cmd_status));$

WARNING: line length of 102 exceeds 80 columns
#390: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1007:
+		netdev_dbg(dev, "%s: check, whether you set the right interrupt number!\n",dev->name);

ERROR: space required after that ',' (ctx:VxV)
#390: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1007:
+		netdev_dbg(dev, "%s: check, whether you set the right interrupt number!\n",dev->name);
 		                                                                          ^

ERROR: code indent should use tabs where possible
#400: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1031:
+            XMIT_BUFF_SIZE, skb->len);$

CHECK: Alignment should match open parenthesis
#400: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1031:
+		netdev_warn(dev, "Sorry, max. framelength is %d bytes. The length of your frame is %d bytes.\n",
+            XMIT_BUFF_SIZE, skb->len);

WARNING: please, no spaces at the start of a line
#400: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1031:
+            XMIT_BUFF_SIZE, skb->len);$

WARNING: line length of 126 exceeds 80 columns
#411: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1061:
+			netdev_dbg(dev, "%s: stat: %04x %04x\n", dev->name, p->scb->cus, swab16(p->xmit_cmds[0]->cmd_status));

WARNING: suspect code indent for conditional statements (8, 32)
#428: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1195:
 	if( (dump_cmd->cmd_status & (STAT_COMPL|STAT_OK)) != (STAT_COMPL|STAT_OK) )
+				netdev_err(dev, "Can't get dump information.\n");

WARNING: line length of 86 exceeds 80 columns
#434: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1199:
+		netdev_dbg(dev, "%02x ", (int) ((unsigned char *) (dump_cmd + 1))[i]);

CHECK: No space is necessary after a cast
#434: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1199:
+		netdev_dbg(dev, "%02x ", (int) ((unsigned char *) (dump_cmd + 1))[i]);

WARNING: adding a line without newline at end of file
#443: FILE: drivers/net/ethernet/i825xx/sun3_82586.c:1205:
+#endif

total: 21 errors, 35 warnings, 16 checks, 392 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

Commit 3b034ecee913 ("net: i825xx: replace printk() with pr_*() macros for cleaner logging") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.