pylint 3.3.7 astroid 3.3.8 Python 3.13.9 (main, Oct 14 2025, 00:00:00) [GCC 15.2.1 20250808 (Red Hat 15.2.1-1)] Redirect to /tmp/tmp.KhPblKI8r6 and /tmp/tmp.4VhCt0EqhB Tree base: 2ad2ae3e200b ("tools: ynl: fix indent issues in the main Python lib") Now at: 22afa9b06965 ("tools: ynl: rework the string representation of NlError") ====== Checking before the patch ====== ************* Module pyynl.lib.ynl tools/net/ynl/pyynl/lib/ynl.py:275:0: C0301: Line too long (113/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:769:0: C0301: Line too long (114/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:790:0: C0301: Line too long (107/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:822:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:837:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0302: Too many lines in module (1150/1000) (too-many-lines) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:102:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:111:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:115:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:137:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:138:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:144:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:145:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:148:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:152:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:150:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:155:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:158:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:161:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:161:25: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:162:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:169:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:190:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:190:0: R0902: Too many instance attributes (10/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:214:26: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:239:16: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:271:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:283:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:283:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:297:0: C0103: Constant name "genl_family_name_to_id" doesn't conform to UPPER_CASE naming style (invalid-name) tools/net/ynl/pyynl/lib/ynl.py:324:8: W0603: Using the global statement (global-statement) tools/net/ynl/pyynl/lib/ynl.py:325:33: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:338:22: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:347:39: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:327:8: R1702: Too many nested blocks (7/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:327:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:313:0: R0912: Too many branches (15/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:362:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:368:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:374:17: E1101: Instance of 'GenlMsg' has no 'raw_attrs' member (no-member) tools/net/ynl/pyynl/lib/ynl.py:379:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:390:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:390:38: W0613: Unused argument 'version' (unused-argument) tools/net/ynl/pyynl/lib/ynl.py:396:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:400:28: W0212: Access to a protected member _struct_size of a client class (protected-access) tools/net/ynl/pyynl/lib/ynl.py:404:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:406:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:409:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:413:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:417:8: W0602: Using global for 'genl_family_name_to_id' but no assignment is done (global-variable-not-assigned) tools/net/ynl/pyynl/lib/ynl.py:434:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:441:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:449:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:455:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:457:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:441:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:465:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:465:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:480:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Family '{self.yaml['name']}' not supported by the kernel") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:480:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:510:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:516:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:529:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0914: Too many local variables (18/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:591:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:553:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{space}' has no attribute '{name}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:553:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:594:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:620:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:622:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0912: Too many branches (28/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0915: Too many statements (65/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:709:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:723:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:730:31: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/lib/ynl.py:746:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:752:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:769:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:773:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:783:20: W0707: Consider explicitly re-raising using 'except (KeyError, UnboundLocalError) as exc' and 'raise Exception(f"Space '{space}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:783:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:790:94: E0606: Possibly using variable 'search_attrs' before assignment (possibly-used-before-assignment) tools/net/ynl/pyynl/lib/ynl.py:822:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:772:4: R0912: Too many branches (21/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:772:4: R0915: Too many statements (53/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:832:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/lib/ynl.py:832:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/lib/ynl.py:837:16: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{attr_set.name}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:837:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:854:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:858:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:892:20: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:882:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:908:20: W0622: Redefining built-in 'len' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:916:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:900:16: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:947:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:937:32: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:953:33: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/net/ynl/pyynl/lib/ynl.py:980:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:984:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:985:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:997:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1022:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1066:4: R0914: Too many local variables (20/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:1121:20: R1724: Unnecessary "else" after "continue", remove the "else" and de-indent the code inside it (no-else-continue) tools/net/ynl/pyynl/lib/ynl.py:1066:4: R0912: Too many branches (17/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:1066:4: R0915: Too many statements (54/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:1143:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1146:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1149:4: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 8.62/10 (previous run: 8.62/10, +0.00) ====== Checking the tree with the patch ====== ************* Module pyynl.lib.ynl tools/net/ynl/pyynl/lib/ynl.py:284:0: C0301: Line too long (113/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:778:0: C0301: Line too long (114/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:799:0: C0301: Line too long (107/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:831:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:846:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0302: Too many lines in module (1159/1000) (too-many-lines) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:102:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:120:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:124:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:146:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:147:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:153:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:154:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:157:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:161:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:159:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:164:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:167:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:170:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:170:25: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:171:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:178:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:199:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:199:0: R0902: Too many instance attributes (10/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:223:26: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:248:16: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:280:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:292:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:292:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:306:0: C0103: Constant name "genl_family_name_to_id" doesn't conform to UPPER_CASE naming style (invalid-name) tools/net/ynl/pyynl/lib/ynl.py:333:8: W0603: Using the global statement (global-statement) tools/net/ynl/pyynl/lib/ynl.py:334:33: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:347:22: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:356:39: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:336:8: R1702: Too many nested blocks (7/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:336:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:322:0: R0912: Too many branches (15/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:371:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:377:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:383:17: E1101: Instance of 'GenlMsg' has no 'raw_attrs' member (no-member) tools/net/ynl/pyynl/lib/ynl.py:388:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:399:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:399:38: W0613: Unused argument 'version' (unused-argument) tools/net/ynl/pyynl/lib/ynl.py:405:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:409:28: W0212: Access to a protected member _struct_size of a client class (protected-access) tools/net/ynl/pyynl/lib/ynl.py:413:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:415:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:418:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:422:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:426:8: W0602: Using global for 'genl_family_name_to_id' but no assignment is done (global-variable-not-assigned) tools/net/ynl/pyynl/lib/ynl.py:443:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:450:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:458:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:464:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:466:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:450:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:474:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:474:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:489:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Family '{self.yaml['name']}' not supported by the kernel") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:489:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:519:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:525:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:538:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:558:4: R0914: Too many local variables (18/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:600:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:562:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{space}' has no attribute '{name}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:562:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:603:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:629:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:631:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:558:4: R0912: Too many branches (28/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:558:4: R0915: Too many statements (65/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:718:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:732:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:739:31: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/lib/ynl.py:755:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:761:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:778:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:782:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:792:20: W0707: Consider explicitly re-raising using 'except (KeyError, UnboundLocalError) as exc' and 'raise Exception(f"Space '{space}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:792:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:799:94: E0606: Possibly using variable 'search_attrs' before assignment (possibly-used-before-assignment) tools/net/ynl/pyynl/lib/ynl.py:831:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:781:4: R0912: Too many branches (21/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:781:4: R0915: Too many statements (53/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:841:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/lib/ynl.py:841:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/lib/ynl.py:846:16: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{attr_set.name}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:846:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:863:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:867:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:901:20: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:891:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:917:20: W0622: Redefining built-in 'len' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:925:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:909:16: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:956:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:946:32: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:962:33: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/net/ynl/pyynl/lib/ynl.py:989:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:993:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:994:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:1006:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1031:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1075:4: R0914: Too many local variables (20/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:1130:20: R1724: Unnecessary "else" after "continue", remove the "else" and de-indent the code inside it (no-else-continue) tools/net/ynl/pyynl/lib/ynl.py:1075:4: R0912: Too many branches (17/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:1075:4: R0915: Too many statements (54/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:1152:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1155:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1158:4: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 8.63/10 (previous run: 8.62/10, +0.01)