ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.zdXuaAuOIk and /tmp/tmp.M1hMjAyDCT Tree base: bfe62db5422b ("Merge branch 'dwmac-support-for-rockchip-rk3506'") Now at: cab416605707 ("selftests: net: use BASH for bareudp testing") ====== Checking before the patch ====== Checking tools/testing/selftests/net/bareudp.sh - c7752fb4f8aa522406bf3b1c9b580ca90e7ddb792c43da4283cbe7e1fe4d9104 In bareudp.sh line 149: local NS="${1}"; readonly NS ^------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 150: local DEV="${2}"; readonly DEV ^-------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 151: local LOCAL_IP4="${3}"; readonly LOCAL_IP4 ^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 152: local PEER_IP4="${4}"; readonly PEER_IP4 ^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 153: local LOCAL_IP6="${5}"; readonly LOCAL_IP6 ^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 154: local PEER_IP6="${6}"; readonly PEER_IP6 ^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 260: local PING="$1"; readonly PING ^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 261: local IP="$2"; readonly IP ^------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 262: local MSG="$3"; readonly MSG ^-------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 263: local RET ^-------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 279: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In bareudp.sh line 298: local UNDERLAY="$1"; readonly UNDERLAY ^------------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 299: local MODE ^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 300: local MSG ^-------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 328: local ETHERTYPE="$1"; readonly ETHERTYPE ^-------------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 329: local MULTIPROTO="$2"; readonly MULTIPROTO ^--------------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 330: local IPV4 ^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 331: local IPV6 ^--------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 332: local MPLS_UC ^-----------^ SC3043 (warning): In POSIX sh, 'local' is undefined. In bareudp.sh line 467: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC3043 -- In POSIX sh, 'local' is undefined. https://www.shellcheck.net/wiki/SC2162 -- read without -r will mangle backs... https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/bareudp.sh - c7752fb4f8aa522406bf3b1c9b580ca90e7ddb792c43da4283cbe7e1fe4d9104 In bareudp.sh line 279: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In bareudp.sh line 467: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC2162 -- read without -r will mangle backs... https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...