========== checkpatch - FAILED ERROR: that open brace { should be on the previous line #27: FILE: drivers/net/ethernet/emulex/benet/be_ethtool.c:227: else + { ERROR: trailing whitespace #34: FILE: drivers/net/ethernet/emulex/benet/be_ethtool.c:232: +^I^I/* $ WARNING: Block comments should align the * on each line #35: FILE: drivers/net/ethernet/emulex/benet/be_ethtool.c:233: + /* + * Report fw_on_flash in ethtool's erom_version field. WARNING: line length of 82 exceeds 80 columns #242: FILE: drivers/net/ethernet/emulex/benet/be_ethtool.c:1253: + (ch->rx_count + ch->combined_count) > be_max_rx_irqs(adapter)) || total: 2 errors, 2 warnings, 0 checks, 273 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 47ec66059619 ("net: ethernet: emulex: benet: fix adapter->fw_on_flash truncation warning") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.