pylint 3.3.7 astroid 3.3.8 Python 3.13.7 (main, Aug 14 2025, 00:00:00) [GCC 15.2.1 20250808 (Red Hat 15.2.1-1)] Redirect to /tmp/tmp.EgkPxsSC6V and /tmp/tmp.HHGH2bJJM3 Tree base: 1ab665817448 ("virtio-net: drop the multi-buffer XDP packet in zerocopy") Now at: de7293b1743d ("tools: ynl: avoid print_field when there is no reply") ====== Checking before the patch ====== ************* Module pyynl.ethtool tools/net/ynl/pyynl/ethtool.py:144:5: W0511: TODO: --show-tunnels tunnel-info-get (fixme) tools/net/ynl/pyynl/ethtool.py:145:5: W0511: TODO: --show-module module-get (fixme) tools/net/ynl/pyynl/ethtool.py:146:5: W0511: TODO: --get-plca-cfg plca-get (fixme) tools/net/ynl/pyynl/ethtool.py:147:5: W0511: TODO: --get-plca-status plca-get-status (fixme) tools/net/ynl/pyynl/ethtool.py:148:5: W0511: TODO: --show-mm mm-get (fixme) tools/net/ynl/pyynl/ethtool.py:149:5: W0511: TODO: --show-fec fec-get (fixme) tools/net/ynl/pyynl/ethtool.py:150:5: W0511: TODO: --dump-module-eerpom module-eeprom-get (fixme) tools/net/ynl/pyynl/ethtool.py:151:5: W0511: TODO: pse-get (fixme) tools/net/ynl/pyynl/ethtool.py:152:5: W0511: TODO: rss-get (fixme) tools/net/ynl/pyynl/ethtool.py:164:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:178:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:301:9: W0511: TODO: pass id? (fixme) tools/net/ynl/pyynl/ethtool.py:310:17: W0511: TODO: support passing the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:439:5: W0511: TODO: wol-get (fixme) tools/net/ynl/pyynl/ethtool.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/ethtool.py:12:0: C0413: Import "from lib import YnlFamily" should be placed at the top of the module (wrong-import-position) tools/net/ynl/pyynl/ethtool.py:12:0: E0611: No name 'YnlFamily' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ethtool.py:13:0: E0401: Unable to import 'cli' (import-error) tools/net/ynl/pyynl/ethtool.py:13:0: C0413: Import "from cli import schema_dir, spec_dir" should be placed at the top of the module (wrong-import-position) tools/net/ynl/pyynl/ethtool.py:15:30: W0621: Redefining name 'args' from outer scope (line 156) (redefined-outer-name) tools/net/ynl/pyynl/ethtool.py:42:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) tools/net/ynl/pyynl/ethtool.py:75:14: W0621: Redefining name 'args' from outer scope (line 156) (redefined-outer-name) tools/net/ynl/pyynl/ethtool.py:88:0: W0102: Dangerous default value {} as argument (dangerous-default-value) tools/net/ynl/pyynl/ethtool.py:88:16: W0621: Redefining name 'args' from outer scope (line 156) (redefined-outer-name) tools/net/ynl/pyynl/ethtool.py:114:15: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ethtool.py:116:15: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ethtool.py:125:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ethtool.py:125:0: R0914: Too many local variables (40/15) (too-many-locals) tools/net/ynl/pyynl/ethtool.py:155:4: W0601: Global variable 'args' undefined at the module level (global-variable-undefined) tools/net/ynl/pyynl/ethtool.py:337:8: W0106: Expression "[print(f'\t{v}') for v in bits_to_dict(tsinfo['timestamping'])]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:343:12: W0106: Expression "[print(f'\t{v}') for v in bits_to_dict(tsinfo['tx-types'])]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:349:12: W0106: Expression "[print(f'\t{v}') for v in bits_to_dict(tsinfo['rx-filters'])]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:355:12: W0106: Expression "[print(f'\t{k}: {v}') for (k, v) in tsinfo['stats'].items()]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:125:0: R0911: Too many return statements (16/6) (too-many-return-statements) tools/net/ynl/pyynl/ethtool.py:125:0: R0912: Too many branches (37/12) (too-many-branches) tools/net/ynl/pyynl/ethtool.py:125:0: R0915: Too many statements (167/50) (too-many-statements) tools/net/ynl/pyynl/ethtool.py:125:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) tools/net/ynl/pyynl/ethtool.py:13:0: C0411: third party import "cli.schema_dir" should be placed before first party import "lib.YnlFamily" (wrong-import-order) ------------------------------------------------------------------ Your code has been rated at 8.21/10 (previous run: 8.21/10, +0.00) ====== Checking the tree with the patch ====== ************* Module pyynl.ethtool tools/net/ynl/pyynl/ethtool.py:147:5: W0511: TODO: --show-tunnels tunnel-info-get (fixme) tools/net/ynl/pyynl/ethtool.py:148:5: W0511: TODO: --show-module module-get (fixme) tools/net/ynl/pyynl/ethtool.py:149:5: W0511: TODO: --get-plca-cfg plca-get (fixme) tools/net/ynl/pyynl/ethtool.py:150:5: W0511: TODO: --get-plca-status plca-get-status (fixme) tools/net/ynl/pyynl/ethtool.py:151:5: W0511: TODO: --show-mm mm-get (fixme) tools/net/ynl/pyynl/ethtool.py:152:5: W0511: TODO: --show-fec fec-get (fixme) tools/net/ynl/pyynl/ethtool.py:153:5: W0511: TODO: --dump-module-eerpom module-eeprom-get (fixme) tools/net/ynl/pyynl/ethtool.py:154:5: W0511: TODO: pse-get (fixme) tools/net/ynl/pyynl/ethtool.py:155:5: W0511: TODO: rss-get (fixme) tools/net/ynl/pyynl/ethtool.py:167:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:181:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:304:9: W0511: TODO: pass id? (fixme) tools/net/ynl/pyynl/ethtool.py:313:17: W0511: TODO: support passing the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:442:5: W0511: TODO: wol-get (fixme) tools/net/ynl/pyynl/ethtool.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/ethtool.py:12:0: C0413: Import "from lib import YnlFamily" should be placed at the top of the module (wrong-import-position) tools/net/ynl/pyynl/ethtool.py:12:0: E0611: No name 'YnlFamily' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ethtool.py:13:0: E0401: Unable to import 'cli' (import-error) tools/net/ynl/pyynl/ethtool.py:13:0: C0413: Import "from cli import schema_dir, spec_dir" should be placed at the top of the module (wrong-import-position) tools/net/ynl/pyynl/ethtool.py:15:30: W0621: Redefining name 'args' from outer scope (line 159) (redefined-outer-name) tools/net/ynl/pyynl/ethtool.py:42:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) tools/net/ynl/pyynl/ethtool.py:78:14: W0621: Redefining name 'args' from outer scope (line 159) (redefined-outer-name) tools/net/ynl/pyynl/ethtool.py:91:0: W0102: Dangerous default value {} as argument (dangerous-default-value) tools/net/ynl/pyynl/ethtool.py:91:16: W0621: Redefining name 'args' from outer scope (line 159) (redefined-outer-name) tools/net/ynl/pyynl/ethtool.py:117:15: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ethtool.py:119:15: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ethtool.py:128:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ethtool.py:128:0: R0914: Too many local variables (40/15) (too-many-locals) tools/net/ynl/pyynl/ethtool.py:158:4: W0601: Global variable 'args' undefined at the module level (global-variable-undefined) tools/net/ynl/pyynl/ethtool.py:340:8: W0106: Expression "[print(f'\t{v}') for v in bits_to_dict(tsinfo['timestamping'])]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:346:12: W0106: Expression "[print(f'\t{v}') for v in bits_to_dict(tsinfo['tx-types'])]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:352:12: W0106: Expression "[print(f'\t{v}') for v in bits_to_dict(tsinfo['rx-filters'])]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:358:12: W0106: Expression "[print(f'\t{k}: {v}') for (k, v) in tsinfo['stats'].items()]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:128:0: R0911: Too many return statements (16/6) (too-many-return-statements) tools/net/ynl/pyynl/ethtool.py:128:0: R0912: Too many branches (37/12) (too-many-branches) tools/net/ynl/pyynl/ethtool.py:128:0: R0915: Too many statements (167/50) (too-many-statements) tools/net/ynl/pyynl/ethtool.py:128:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) tools/net/ynl/pyynl/ethtool.py:13:0: C0411: third party import "cli.schema_dir" should be placed before first party import "lib.YnlFamily" (wrong-import-order) ------------------------------------------------------------------ Your code has been rated at 8.22/10 (previous run: 8.21/10, +0.01)