WARNING: line length of 90 exceeds 80 columns #48: FILE: include/net/xfrm.h:458: + int (*input_encap)(struct sk_buff *skb, struct xfrm_state *x); WARNING: line length of 95 exceeds 80 columns #52: FILE: include/net/xfrm.h:462: + int (*output_tcp_encap)(struct xfrm_state *x, struct sk_buff *skb); WARNING: please, no space before tabs #1171: FILE: net/ipv4/esp4.c:204: +^I.proto^I ^I^I= IPPROTO_ESP,$ WARNING: line length of 84 exceeds 80 columns #2595: FILE: net/xfrm/xfrm_esp.c:203: + XFRM_INC_STATS(xs_net(x), LINUX_MIB_XFRMOUTSTATEPROTOERROR); WARNING: line length of 99 exceeds 80 columns #2690: FILE: net/xfrm/xfrm_esp.c:298: + /* For IPv4 ESP with UDP encapsulation, if xo is not null, the skb is in the crypto offload WARNING: line length of 96 exceeds 80 columns #2691: FILE: net/xfrm/xfrm_esp.c:299: + * data path, which means that esp_output_udp_encap is called outside of the XFRM stack. WARNING: line length of 98 exceeds 80 columns #2692: FILE: net/xfrm/xfrm_esp.c:300: + * In this case, the mac header doesn't point to the IPv4 protocol field, so don't set it. CHECK: Please don't use multiple blank lines #2700: FILE: net/xfrm/xfrm_esp.c:308: + + CHECK: Alignment should match open parenthesis #2704: FILE: net/xfrm/xfrm_esp.c:312: +static struct ip_esp_hdr *esp_output_tcp_encap(struct xfrm_state *x, + struct sk_buff *skb, CHECK: Alignment should match open parenthesis #2732: FILE: net/xfrm/xfrm_esp.c:340: +static struct ip_esp_hdr *esp_output_tcp_encap(struct xfrm_state *x, + struct sk_buff *skb, WARNING: line length of 84 exceeds 80 columns #2773: FILE: net/xfrm/xfrm_esp.c:381: +int esp_output_head(struct xfrm_state *x, struct sk_buff *skb, struct esp_info *esp) CHECK: Logical continuations should be on the previous line #2802: FILE: net/xfrm/xfrm_esp.c:410: + } else if ((skb_shinfo(skb)->nr_frags < MAX_SKB_FRAGS) + && !skb_has_frag_list(skb)) { WARNING: line length of 92 exceeds 80 columns #2813: FILE: net/xfrm/xfrm_esp.c:421: + if (unlikely(!skb_page_frag_refill(allocsize, pfrag, GFP_ATOMIC))) { WARNING: line length of 90 exceeds 80 columns #2823: FILE: net/xfrm/xfrm_esp.c:431: + esp_output_fill_trailer(tail, esp->tfclen, esp->plen, esp->proto); WARNING: line length of 83 exceeds 80 columns #2852: FILE: net/xfrm/xfrm_esp.c:460: + esp->esph = (struct ip_esp_hdr *)(skb_transport_header(skb) + esph_offset); WARNING: line length of 84 exceeds 80 columns #2863: FILE: net/xfrm/xfrm_esp.c:471: +int esp_output_tail(struct xfrm_state *x, struct sk_buff *skb, struct esp_info *esp) ERROR: code indent should use tabs where possible #2910: FILE: net/xfrm/xfrm_esp.c:518: +^I^I (unsigned char *)esph - skb->data,$ CHECK: Alignment should match open parenthesis #2910: FILE: net/xfrm/xfrm_esp.c:518: + err = skb_to_sgvec(skb, sg, + (unsigned char *)esph - skb->data, ERROR: code indent should use tabs where possible #2911: FILE: net/xfrm/xfrm_esp.c:519: +^I^I assoclen + ivlen + esp->clen + alen);$ WARNING: line length of 84 exceeds 80 columns #2922: FILE: net/xfrm/xfrm_esp.c:530: + if (unlikely(!skb_page_frag_refill(allocsize, pfrag, GFP_ATOMIC))) { WARNING: line length of 81 exceeds 80 columns #2932: FILE: net/xfrm/xfrm_esp.c:540: + __skb_fill_page_desc(skb, 0, page, pfrag->offset, skb->data_len); ERROR: code indent should use tabs where possible #2938: FILE: net/xfrm/xfrm_esp.c:546: +^I^I^I (unsigned char *)esph - skb->data,$ CHECK: Alignment should match open parenthesis #2938: FILE: net/xfrm/xfrm_esp.c:546: + err = skb_to_sgvec(skb, dsg, + (unsigned char *)esph - skb->data, ERROR: code indent should use tabs where possible #2939: FILE: net/xfrm/xfrm_esp.c:547: +^I^I^I assoclen + ivlen + esp->clen + alen);$ WARNING: line length of 81 exceeds 80 columns #2953: FILE: net/xfrm/xfrm_esp.c:561: + memcpy(iv + ivlen - min(ivlen, 8), (u8 *)&esp->seqno + 8 - min(ivlen, 8), WARNING: please, no spaces at the start of a line #2986: FILE: net/xfrm/xfrm_esp.c:594: + int esp_output(struct xfrm_state *x, struct sk_buff *skb)$ WARNING: line length of 81 exceeds 80 columns #3009: FILE: net/xfrm/xfrm_esp.c:617: + padto = min(x->tfcpad, xfrm_state_mtu(x, dst->child_mtu_cached)); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #3052: FILE: net/xfrm/xfrm_esp.c:660: + BUG(); CHECK: Please don't use multiple blank lines #3078: FILE: net/xfrm/xfrm_esp.c:686: + + CHECK: Please don't use multiple blank lines #3141: FILE: net/xfrm/xfrm_esp.c:749: + + WARNING: line length of 91 exceeds 80 columns #3315: FILE: net/xfrm/xfrm_esp.c:923: + NL_SET_ERR_MSG(extack, "Kernel was unable to initialize cryptographic operations"); WARNING: line length of 99 exceeds 80 columns #3358: FILE: net/xfrm/xfrm_esp.c:966: + NL_SET_ERR_MSG(extack, "Kernel was unable to initialize cryptographic operations"); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #3385: FILE: net/xfrm/xfrm_esp.c:993: + BUG_ON(!aalg_desc); WARNING: line length of 107 exceeds 80 columns #3390: FILE: net/xfrm/xfrm_esp.c:998: + NL_SET_ERR_MSG(extack, "Kernel was unable to initialize cryptographic operations"); CHECK: Lines should not end with a '(' #3394: FILE: net/xfrm/xfrm_esp.c:1002: + err = crypto_aead_setauthsize( WARNING: line length of 107 exceeds 80 columns #3397: FILE: net/xfrm/xfrm_esp.c:1005: + NL_SET_ERR_MSG(extack, "Kernel was unable to initialize cryptographic operations"); total: 4 errors, 23 warnings, 9 checks, 3348 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit c32ad2130257 ("esp: Consolidate esp4 and esp6.") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.