ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.HZRsrqmR3r and /tmp/tmp.9RfbacEHJp
Tree base:
88af546bb727 ("selftests/vsock: reuse logic for vsock_test through wrapper functions")
Now at:
200f814fb0d7 ("selftests/vsock: avoid multi-VM pidfile collisions with QEMU")
 ====== Checking before the patch ======
Checking tools/testing/selftests/vsock/vmtest.sh - 3bbe24ed85577bc751e7e913126d8b44bb8554cc21519ace46c3118b1749f848


In vmtest.sh line 11:
readonly SCRIPT_DIR="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
         ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 12:
readonly KERNEL_CHECKOUT=$(realpath "${SCRIPT_DIR}"/../../../../)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 26:
readonly QEMU_PIDFILE=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid)
         ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 46:
readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log)
         ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 178:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null
        ^-- SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.

Did you mean: 
	pushd "${KERNEL_CHECKOUT}" &>/dev/null || exit


In vmtest.sh line 184:
	if ! make -j$(nproc); then
                    ^------^ SC2046 (warning): Quote this to prevent word splitting.


In vmtest.sh line 188:
	popd &>/dev/null
        ^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.

Did you mean: 
	popd &>/dev/null || exit


In vmtest.sh line 210:
		${kernel_opt} \
                ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		"${kernel_opt}" \


In vmtest.sh line 302:
			2>&1 | log_guest
                               ^-------^ SC2119 (info): Use log_guest "$@" if function's $1 should mean script's $1.


In vmtest.sh line 310:
			2>&1 | log_guest &
                               ^-------^ SC2119 (info): Use log_guest "$@" if function's $1 should mean script's $1.


In vmtest.sh line 315:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			return "$rc"


In vmtest.sh line 323:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	return "$rc"


In vmtest.sh line 349:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			return "$rc"


In vmtest.sh line 357:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	return "$rc"


In vmtest.sh line 388:
	LOG_PREFIX=host log $@
                            ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In vmtest.sh line 391:
log_guest() {
^-- SC2120 (warning): log_guest references arguments, but none are ever passed.


In vmtest.sh line 392:
	LOG_PREFIX=guest log $@
                             ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In vmtest.sh line 454:
	host_oops_cnt_after=$(dmesg | grep -i 'Oops' | wc -l)
                                      ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.


In vmtest.sh line 466:
	vm_oops_cnt_after=$(vm_ssh -- dmesg | grep -i 'Oops' | wc -l)
                                              ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.

For more information:
  https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2120 -- log_guest references arguments, b...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/vsock/vmtest.sh - 3bbe24ed85577bc751e7e913126d8b44bb8554cc21519ace46c3118b1749f848


In vmtest.sh line 11:
readonly SCRIPT_DIR="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
         ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 12:
readonly KERNEL_CHECKOUT=$(realpath "${SCRIPT_DIR}"/../../../../)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 40:
readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log)
         ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 161:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null
        ^-- SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.

Did you mean: 
	pushd "${KERNEL_CHECKOUT}" &>/dev/null || exit


In vmtest.sh line 167:
	if ! make -j$(nproc); then
                    ^------^ SC2046 (warning): Quote this to prevent word splitting.


In vmtest.sh line 171:
	popd &>/dev/null
        ^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.

Did you mean: 
	popd &>/dev/null || exit


In vmtest.sh line 216:
		${kernel_opt} \
                ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		"${kernel_opt}" \


In vmtest.sh line 308:
			2>&1 | log_guest
                               ^-------^ SC2119 (info): Use log_guest "$@" if function's $1 should mean script's $1.


In vmtest.sh line 316:
			2>&1 | log_guest &
                               ^-------^ SC2119 (info): Use log_guest "$@" if function's $1 should mean script's $1.


In vmtest.sh line 321:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			return "$rc"


In vmtest.sh line 329:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	return "$rc"


In vmtest.sh line 355:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			return "$rc"


In vmtest.sh line 363:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	return "$rc"


In vmtest.sh line 394:
	LOG_PREFIX=host log $@
                            ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In vmtest.sh line 397:
log_guest() {
^-- SC2120 (warning): log_guest references arguments, but none are ever passed.


In vmtest.sh line 398:
	LOG_PREFIX=guest log $@
                             ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In vmtest.sh line 460:
	host_oops_cnt_after=$(dmesg | grep -i 'Oops' | wc -l)
                                      ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.


In vmtest.sh line 472:
	vm_oops_cnt_after=$(vm_ssh -- dmesg | grep -i 'Oops' | wc -l)
                                              ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.

For more information:
  https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2120 -- log_guest references arguments, b...