ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.FTnMEmY1RL and /tmp/tmp.ha9ssg4PHU Tree base: ffff5c8fc2af ("net: phy: realtek: fix rtl8221b-vm-cg name") Now at: 0e9e35147889 ("selftests: netconsole: Add race condition test for userdata corruption") ====== Checking before the patch ====== ====== Checking the tree with the patch ====== Checking tools/testing/selftests/drivers/net/netcons_race_userdata.sh - 2b855c86ad30f05edf2044fe5b96adda28544689eba990e6bfff3845b3da032c In netcons_race_userdata.sh line 38: kill $child1 $child2 2> /dev/null || true ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "$child1" "$child2" 2> /dev/null || true In netcons_race_userdata.sh line 39: wait $child1 $child2 2> /dev/null || true ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait "$child1" "$child2" 2> /dev/null || true In netcons_race_userdata.sh line 54: set_network ^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1. In netcons_race_userdata.sh line 56: create_dynamic_target ^-------------------^ SC2119 (info): Use create_dynamic_target "$@" if function's $1 should mean script's $1. In netcons_race_userdata.sh line 71: while read line; do ^--^ SC2162 (info): read without -r will mangle backslashes. In netcons_race_userdata.sh line 74: exit ${ksft_pass} ^----------^ SC2154 (warning): ksft_pass is referenced but not assigned. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "${ksft_pass}" In netcons_race_userdata.sh line 80: exit ${ksft_fail} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "${ksft_fail}" In netcons_race_userdata.sh line 87: exit ${ksft_skip} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "${ksft_skip}" For more information: https://www.shellcheck.net/wiki/SC2154 -- ksft_pass is referenced but not a... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... https://www.shellcheck.net/wiki/SC2119 -- Use create_dynamic_target "$@" if...